Page MenuHomePhabricator

InstantCommons is broken
Closed, ResolvedPublicBUG REPORT

Description

List of steps to reproduce (step by step, including full links if applicable):

What happens?:

  • All the red links are supposed to be images at the top

What should have happened instead?:

  • Show images from Commons

Software version (if not a Wikimedia wiki), browser information, screenshots, other information, etc.:
Just updated to latest version of MediaWiki core and extension (last update was two weeks ago).

Event Timeline

twn:/srv/mediawiki/workdir (master)$ php maintenance/shell.php 
>>> var_dump( $wgUseInstantCommons );
bool(true)

Nothing related to instant commons in error or debug logs.

Nikerabbit triaged this task as Unbreak Now! priority.Feb 2 2022, 4:52 PM

cdf7207df823269bea217a50c765e36d5278786b is the first bad commit

commit cdf7207df823269bea217a50c765e36d5278786b
Author: Derk-Jan Hartman <hartman.wiki@gmail.com>
Date:   Wed Jan 26 01:01:36 2022 +0100

    Support audio on filepage in InstantCommons
    
    The transform for ForeignAPIFile generally delegates transforms to the
    thumburl of the remote. This works well, unless the file in question
    has no inherent visual area, like audio files. Audio files on the file
    description page when using InstantCommons have a 0x0 size, and the
    Commons API returns errors for thumbnails of 0 size.
    
    Instead, since we already know we don't need a thumbnail url for audio
    fragments, just skip that step directly and simply pass an empty
    string thumburl to the HTML generator of TMH.
    
    Bug: T300085
    Change-Id: Iea0e16de97e5e5da8c84bdbed8a2961ad194c040

 includes/filerepo/file/ForeignAPIFile.php | 19 +++++++++++++------
 1 file changed, 13 insertions(+), 6 deletions(-)
Nikerabbit added a subscriber: abi_.

I have reverted rMWcdf7207df823: Support audio on filepage in InstantCommons on translatewiki.net, so the example link no longer works.

Nikerabbit lowered the priority of this task from Unbreak Now! to High.Feb 2 2022, 5:52 PM

I'm lowering priority since this is mitigated at translatewiki.net. Feel free to adjust the priority further as is appropriate.

Change 758924 had a related patch set uploaded (by Ladsgroup; author: Ladsgroup):

[mediawiki/core@master] Revert \"Support audio on filepage in InstantCommons\"

https://gerrit.wikimedia.org/r/758924

Change 758925 had a related patch set uploaded (by Ladsgroup; author: Ladsgroup):

[mediawiki/core@wmf/1.38.0-wmf.20] Revert \"Support audio on filepage in InstantCommons\"

https://gerrit.wikimedia.org/r/758925

Change 758925 merged by jenkins-bot:

[mediawiki/core@wmf/1.38.0-wmf.20] Revert \"Support audio on filepage in InstantCommons\"

https://gerrit.wikimedia.org/r/758925

Mentioned in SAL (#wikimedia-operations) [2022-02-02T18:16:16Z] <ladsgroup@deploy1002> Synchronized php-1.38.0-wmf.20/includes/filerepo/file/ForeignAPIFile.php: Backport: [[gerrit:758925|Revert "Support audio on filepage in InstantCommons" (T300751)]] (duration: 00m 51s)

I'm lowering priority since this is mitigated at translatewiki.net. Feel free to adjust the priority further as is appropriate.

It was made a train blocker so should have remained UBN! It's no longer blocking the train though thanks to @Ladsgroup's revert

ugh. && should have been an || of course. Will fix

Change 759765 had a related patch set uploaded (by TheDJ; author: TheDJ):

[mediawiki/core@master] Correct condition for InstantCommons with 0 dimensions

https://gerrit.wikimedia.org/r/759765

Change 759765 merged by jenkins-bot:

[mediawiki/core@master] Correct condition for InstantCommons with 0 dimensions

https://gerrit.wikimedia.org/r/759765

Ladsgroup assigned this task to TheDJ.

Beta cluster seems fine now. Thanks.

Change 758924 abandoned by Ladsgroup:

[mediawiki/core@master] Revert \"Support audio on filepage in InstantCommons\"

Reason:

not needed

https://gerrit.wikimedia.org/r/758924