⚓ T299818 Fields for caption and alt text do not appear in media and gallery dialogs

	Subject	Repo	Branch	Lines +/-
	Fix showing caption and alt text fields in media and gallery dialogs	mediawiki/extensions/VisualEditor	wmf/1.38.0-wmf.18	+4 -4
	Fix showing caption and alt text fields in media and gallery dialogs	mediawiki/extensions/VisualEditor	master	+4 -4

matmarex created this task.Jan 22 2022, 2:13 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 22 2022, 2:13 AM

matmarex updated the task description. (Show Details)Jan 22 2022, 2:15 AM

Caused by https://gerrit.wikimedia.org/r/c/oojs/ui/+/748066

Change 756102 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/VisualEditor@master] Fix showing caption and alt text fields in media and gallery dialogs

https://gerrit.wikimedia.org/r/756102

gerritbot added a project: Patch-For-Review.Jan 22 2022, 2:28 AM

matmarex claimed this task.Jan 22 2022, 2:28 AM

matmarex added a project: Editing-team (Kanban Board).

matmarex moved this task from To Triage to Triaged on the VisualEditor board.

matmarex moved this task from Incoming to Code Review on the Editing-team (Kanban Board) board.

matmarex added a parent task: T293959: 1.38.0-wmf.18 deployment blockers.Jan 22 2022, 2:32 AM

matmarex updated the task description. (Show Details)

matmarex mentioned this in T299776: Check for OOUI breakage caused by addItems change for non-array parameters.Jan 22 2022, 2:36 AM

• ppelberg subscribed.Jan 22 2022, 2:51 AM

• ppelberg triaged this task as Unbreak Now! priority.Jan 22 2022, 4:08 AM

AntiCompositeNumber merged a task: T299821: Visual Editor - can't add caption .Jan 22 2022, 5:19 AM

AntiCompositeNumber added a subscriber: Kerry_Raymond.

Change 756102 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Fix showing caption and alt text fields in media and gallery dialogs

https://gerrit.wikimedia.org/r/756102

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.19; 2022-01-24).Jan 22 2022, 3:00 PM

Maintenance_bot removed a project: Patch-For-Review.Jan 22 2022, 3:10 PM

Change 756583 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/VisualEditor@wmf/1.38.0-wmf.18] Fix showing caption and alt text fields in media and gallery dialogs

https://gerrit.wikimedia.org/r/756583

gerritbot added a project: Patch-For-Review.Jan 24 2022, 6:17 PM

matmarex moved this task from Code Review to Doing on the Editing-team (Kanban Board) board.Jan 24 2022, 6:28 PM

brennen edited parent tasks, added: T293960: 1.38.0-wmf.19 deployment blockers; removed: T293959: 1.38.0-wmf.18 deployment blockers.Jan 24 2022, 6:40 PM

Change 756583 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@wmf/1.38.0-wmf.18] Fix showing caption and alt text fields in media and gallery dialogs

https://gerrit.wikimedia.org/r/756583

Mentioned in SAL (#wikimedia-operations) [2022-01-24T19:38:23Z] <urbanecm@deploy1002> Synchronized php-1.38.0-wmf.18/extensions/VisualEditor/modules/ve-mw/ui/dialogs/: rEVED531efd00b4ed: Fix showing caption and alt text fields in media and gallery dialogs (T299818) (duration: 00m 48s)

ReleaseTaggerBot edited projects, added MW-1.38-notes (1.38.0-wmf.18; 2022-01-17); removed MW-1.38-notes (1.38.0-wmf.19; 2022-01-24).Jan 24 2022, 8:00 PM

Maintenance_bot removed a project: Patch-For-Review.Jan 24 2022, 8:10 PM

This should be resolved everywhere now. Sorry about that…

The bug was caused by a maintenance release of the OOUI library, and one of the changes exposed a hidden bug in our code – we were displaying those two fields in the two dialogs into the page in an incorrect way, and it broke now even though it has been previously working fine since 2018 (f422ae2dcc0dc9c698cf37e90733ef25fbab9586).

matmarex lowered the priority of this task from Unbreak Now! to High.Jan 24 2022, 11:04 PM

Removing as train blocker.

brennen removed a parent task: T293960: 1.38.0-wmf.19 deployment blockers.Jan 25 2022, 4:12 PM

Confirmed!

Screenshot 2022-01-26 at 10.45.47.png (602×800 px, 42 KB)

Screenshot 2022-01-26 at 10.47.49.png (1×1 px, 88 KB)

EAkinloose edited projects, added Verified; removed Editing QA.Jan 26 2022, 9:48 AM

EAkinloose moved this task from QA to Ready for Sign Off on the Editing-team (Kanban Board) board.

EAkinloose mentioned this in T299620: Implement automated testing for core editing functionality.Jan 26 2022, 5:11 PM

• ppelberg closed this task as Resolved.Jan 29 2022, 1:30 AM

Fields for caption and alt text do not appear in media and gallery dialogs
Closed, ResolvedPublic
Actions

Description

Details

Related Objects

Event Timeline

	F34931270: Screenshot 2022-01-26 at 10.45.47.png
	Jan 26 2022, 9:48 AM

	F34931275: Screenshot 2022-01-26 at 10.47.49.png
	Jan 26 2022, 9:48 AM

Fields for caption and alt text do not appear in media and gallery dialogsClosed, ResolvedPublicActions

Description

Details

Related Objects

Event Timeline

Fields for caption and alt text do not appear in media and gallery dialogs
Closed, ResolvedPublic
Actions