Page MenuHomePhabricator

Mobile suggested edits module does not work when zero tasks are available in filters
Closed, ResolvedPublic

Description

Steps to reproduce:

  1. Select a topic/task type filter combination that results in zero tasks being available in your feed.
  2. Visit Special:Homepage on the mobile view

You'll see this:

image.png (960×640 px, 69 KB)

The module is not clickable. I'd expect to be able to view the subpage on mobile where I could then adjust my filters.

Event Timeline

kostajh triaged this task as High priority.Jan 21 2022, 8:38 AM
kostajh created this task.

@RHo should we show the "Show all suggestions" blue button at the footer when the user has filters that result in no tasks being available? Or should we restore the previous behavior where tapping anywhere on the card takes you to suggested edits?

Change 755939 had a related patch set uploaded (by Sergio Gimeno; author: Sergio Gimeno):

[mediawiki/extensions/GrowthExperiments@master] Suggested edits: allow to navigate to module full screen when zero tasks are available in filters

https://gerrit.wikimedia.org/r/755939

I checked how it currently works on wmf.18. The issue is not present there - the SE module is clickable.

The user scenario (to check :

  • a user confirms the filter selection that results in zero tasks by clicking on "Done" (it might be that the number of tasks might become zero by themselves).
  • a user will see that there are no tasks available:

Screen Shot 2022-01-21 at 9.58.31 AM.png (1×986 px, 713 KB)

  • a user returns to Homepage - the SE module is clickable (and the filter selection is preserved):

IMG_0625.PNG (1×640 px, 128 KB)

@RHo should we show the "Show all suggestions" blue button at the footer when the user has filters that result in no tasks being available? Or should we restore the previous behavior where tapping anywhere on the card takes you to suggested edits?

Hiya, per T264460 I think it should be the latter, where tapping anywhere on the card goes to suggested edits

I checked how it currently works on wmf.18. The issue is not present there - the SE module is clickable.

I think the issue is an early regression catch in beta due to T264460: Enable users to open the first suggested article directly from the mobile task preview which has not yet been deployed.

@RHo should we show the "Show all suggestions" blue button at the footer when the user has filters that result in no tasks being available? Or should we restore the previous behavior where tapping anywhere on the card takes you to suggested edits?

Hiya, per T264460 I think it should be the latter, where tapping anywhere on the card goes to suggested edits

Thanks for clarifying, there's a fix for review already.

Change 755939 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Suggested edits: allow to navigate to module full screen when zero tasks are available in filters

https://gerrit.wikimedia.org/r/755939

Checked on testwiki wmf.19 - works as expected.