Page MenuHomePhabricator

Backslashes in some ISA messages
Closed, ResolvedPublicBUG REPORT

Event Timeline

This appears to happen when a message end in a space. Both source and translated messages look fine (no backslashes). Is this an issue with Translatewiki?

Translatewiki.net does not support trailing whitespace in messages. The backslashes are a workaround to preserve them, but preferably all the surrounding whitespace is not in the messages but in the code.

Happy birthday, @Nikerabbit's last comment :)

Can this be fixed in the code, please? I saw that there's an upcoming event where some people will translate ISA, so it would be nice to make it as comfortable as possible for the volunteers. It should be a trivial thing to fix.

Thanks! <3

... An addition: if a message needs space in the beginning or in the end for a technical, the message itself should probably be changed. I suspect that this is the case with "Campaign - ". If the current code concatenates a campaign name or ID to the end of this message, it should be changed from concatenation to putting the campaign into the message as a parameter.

Change 990674 had a related patch set uploaded (by Eugene233; author: Eugene233):

[labs/tools/Isa@m2c] Backslashes in some ISA messages

https://gerrit.wikimedia.org/r/990674

Change 1002422 had a related patch set uploaded (by Eugene233; author: Eugene233):

[labs/tools/Isa@main] Backslashes in some ISA messages

https://gerrit.wikimedia.org/r/1002422

Change 990674 abandoned by Eugene233:

[labs/tools/Isa@m2c] Backslashes in some ISA messages

Reason:

In favor of https://gerrit.wikimedia.org/r/1002422

https://gerrit.wikimedia.org/r/990674

Change 1002422 merged by jenkins-bot:

[labs/tools/Isa@main] Backslashes in some ISA messages

https://gerrit.wikimedia.org/r/1002422

Change 1003518 had a related patch set uploaded (by Amire80; author: Amire80):

[labs/tools/Isa@main] Remove unnecessary space from the end of a message

https://gerrit.wikimedia.org/r/1003518

Change 1003518 merged by jenkins-bot:

[labs/tools/Isa@main] Remove unnecessary space from the end of a message

https://gerrit.wikimedia.org/r/1003518

Amire80 updated the task description. (Show Details)