Page MenuHomePhabricator
Create Task
Maniphest T300070

[Regression] User common.js/css is being loaded twice
Closed, ResolvedPublicBUG REPORT
Actions

Description

When viewing a page in the new Vector skin the modules skins.vector.user and user are loaded at the same time. This is resulting in common.js being loaded twice.

QA

Login as admin

Add to User:Admin/common.js

console.log('admin.common.js');

View http://localhost:8888/w/index.php?title=User:Admin/common.js&mobileaction=toggle_view_desktop&useskin=vector-2022

Expected: I see the log once.
Actual: I see it twice

Visiting https://eu.wikipedia.org/w/load.php?lang=en&modules=skins.vector.user|user&skin=vector-2022&user=Jdlrobson&version=1uo6p&debug=true&only=scripts I should see Lankide:Jdlrobson/common.js only once

Actual: Seen twice

Details

SubjectRepoBranchLines +/-
Do not load common.js twicemediawiki/skins/Vectorwmf/1.38.0-wmf.18+0 -2
Do not load common.js twicemediawiki/skins/Vectorwmf/1.38.0-wmf.19+0 -2
Do not load common.js twicemediawiki/skins/Vectormaster+0 -2
Customize query in gerrit

Related Objects

Event Timeline

Jdlrobson created this task.Jan 25 2022, 7:59 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 25 2022, 7:59 PM
Jdlrobson renamed this task from Common.js is being loaded twice to User common.js is being loaded twice.Jan 25 2022, 7:59 PM
Jdlrobson claimed this task.
Jdlrobson triaged this task as High priority.
Jdlrobson renamed this task from User common.js is being loaded twice to User common.js/css is being loaded twice.Jan 25 2022, 8:02 PM
Jdlrobson updated the task description. (Show Details)
gerritbot added a comment.Jan 25 2022, 8:08 PM

Change 757081 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/Vector@master] Do not load common.js twice

https://gerrit.wikimedia.org/r/757081

gerritbot added a project: Patch-For-Review.Jan 25 2022, 8:08 PM
Jdlrobson renamed this task from User common.js/css is being loaded twice to [Regression] User common.js/css is being loaded twice.Jan 25 2022, 8:09 PM
Jdlrobson added a project: Regression.
gerritbot added a comment.Jan 25 2022, 8:10 PM

Change 756997 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/Vector@wmf/1.38.0-wmf.18] Do not load common.js twice

https://gerrit.wikimedia.org/r/756997

gerritbot added a comment.Jan 25 2022, 8:11 PM

Change 756998 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/Vector@wmf/1.38.0-wmf.19] Do not load common.js twice

https://gerrit.wikimedia.org/r/756998

gerritbot added a comment.Jan 25 2022, 8:27 PM

Change 757081 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Do not load common.js twice

https://gerrit.wikimedia.org/r/757081

Jdlrobson moved this task from Needs Analysis to Ready for Signoff on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.Jan 25 2022, 8:28 PM
ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.20; 2022-01-31).Jan 25 2022, 9:00 PM
Jdlrobson mentioned this in T300052: Vector-2022-view-history message changed.Jan 25 2022, 9:51 PM
gerritbot added a comment.Jan 26 2022, 12:33 AM

Change 756997 merged by Catrope:

[mediawiki/skins/Vector@wmf/1.38.0-wmf.18] Do not load common.js twice

https://gerrit.wikimedia.org/r/756997

gerritbot added a comment.Jan 26 2022, 12:39 AM

Change 756998 merged by jenkins-bot:

[mediawiki/skins/Vector@wmf/1.38.0-wmf.19] Do not load common.js twice

https://gerrit.wikimedia.org/r/756998

Stashbot added a comment.Jan 26 2022, 12:56 AM

Mentioned in SAL (#wikimedia-operations) [2022-01-26T00:56:21Z] <catrope@deploy1002> Synchronized php-1.38.0-wmf.19/skins/Vector/: Backport: [[gerrit:756998|Do not load common.js twice (T300070)]] (duration: 02m 43s)

ReleaseTaggerBot edited projects, added MW-1.38-notes (1.38.0-wmf.18; 2022-01-17); removed MW-1.38-notes (1.38.0-wmf.20; 2022-01-31).Jan 26 2022, 1:00 AM
Stashbot mentioned this in T299971: [subtask] Problem in Legacy Vector calculation ([{reqId}] {exception_url} PHP Notice: Undefined index: data-user-page ).Jan 26 2022, 1:00 AM

Mentioned in SAL (#wikimedia-operations) [2022-01-26T01:00:56Z] <catrope@deploy1002> Synchronized php-1.38.0-wmf.18/skins/Vector/: Backport: [[gerrit:756997|Do not load common.js twice (T300070)]] and [[gerrit:756696|Fix bug in SkinVersionLookup (T299971)]] (duration: 00m 51s)

Maintenance_bot removed a project: Patch-For-Review.Jan 26 2022, 1:10 AM
Jdlrobson closed this task as Resolved.Jan 26 2022, 1:40 AM

Now fixed. Confirmed in production.

Krinkle mentioned this in T305594: Vector 2022 skin should not load user's vector.js before site's MediaWiki:Common.js.Jul 2 2022, 3:21 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits