Page MenuHomePhabricator
Create Task
Maniphest T299971

[subtask] Problem in Legacy Vector calculation ([{reqId}] {exception_url} PHP Notice: Undefined index: data-user-page )
Closed, ResolvedPublicBUG REPORT
Actions

Description

Add the following config

$wgVectorDefaultSkinVersion = '1';
$wgVectorSkinMigrationMode = false;

Incognito visit http://localhost:8888/w/index.php/Selenium_category_test?useskin=vector-2022

See: notice, incorrectly styled search and uncollapsed user dropdown.

Developer notes

This happens because Hooks::isSkinVersionLegacy() returns true in this situation.

SkinVersionLookup::getVersion returns 1

This also causes a production error https://logstash.wikimedia.org/goto/d7565ceb716e44e47aab1a7b7df6febb

Details

SubjectRepoBranchLines +/-
Pass skin name to Hooks::isSkinLegacymediawiki/skins/Vectorwmf/1.38.0-wmf.20+21 -10
Pass skin name to Hooks::isSkinLegacymediawiki/skins/Vectorwmf/1.38.0-wmf.19+21 -10
Pass skin name to Hooks::isSkinLegacymediawiki/skins/Vectormaster+21 -10
Fix bug in SkinVersionLookupmediawiki/skins/Vectorwmf/1.38.0-wmf.18+35 -11
Fix bug in SkinVersionLookupmediawiki/skins/Vectormaster+35 -11
Customize query in gerrit

Related Objects
Search...

Event Timeline

Jdlrobson created this task.Jan 24 2022, 8:10 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 24 2022, 8:10 PM
gerritbot added a comment.Jan 24 2022, 8:12 PM

Change 756672 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/Vector@master] Fix bug in SkinVersionLookup

https://gerrit.wikimedia.org/r/756672

gerritbot added a project: Patch-For-Review.Jan 24 2022, 8:12 PM
Jdlrobson renamed this task from Problem in Legacy Vector calculation ([{reqId}] {exception_url} PHP Notice: Undefined index: data-user-page ) to [subtask] Problem in Legacy Vector calculation ([{reqId}] {exception_url} PHP Notice: Undefined index: data-user-page ).Jan 24 2022, 9:35 PM
Jdlrobson triaged this task as High priority.
Jdlrobson moved this task from Needs Analysis to Code Review on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.
Jdlrobson added a parent task: T299171: Can't view old Vector on beta cluster via query string.
gerritbot added a comment.Jan 25 2022, 12:30 AM

Change 756672 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Fix bug in SkinVersionLookup

https://gerrit.wikimedia.org/r/756672

gerritbot added a comment.Jan 25 2022, 12:35 AM

Change 756696 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/Vector@wmf/1.38.0-wmf.18] Fix bug in SkinVersionLookup

https://gerrit.wikimedia.org/r/756696

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.19; 2022-01-24).Jan 25 2022, 1:00 AM
Jdlrobson claimed this task.Jan 25 2022, 6:05 PM
Jdlrobson moved this task from Code Review to Needs More Work on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.
Jdlrobson moved this task from Needs More Work to Ready for Signoff on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.
gerritbot added a comment.Jan 26 2022, 12:39 AM

Change 756696 merged by jenkins-bot:

[mediawiki/skins/Vector@wmf/1.38.0-wmf.18] Fix bug in SkinVersionLookup

https://gerrit.wikimedia.org/r/756696

ReleaseTaggerBot edited projects, added MW-1.38-notes (1.38.0-wmf.18; 2022-01-17); removed MW-1.38-notes (1.38.0-wmf.19; 2022-01-24).Jan 26 2022, 1:00 AM
Stashbot added a comment.Jan 26 2022, 1:00 AM

Mentioned in SAL (#wikimedia-operations) [2022-01-26T01:00:56Z] <catrope@deploy1002> Synchronized php-1.38.0-wmf.18/skins/Vector/: Backport: [[gerrit:756997|Do not load common.js twice (T300070)]] and [[gerrit:756696|Fix bug in SkinVersionLookup (T299971)]] (duration: 00m 51s)

Stashbot mentioned this in T300070: [Regression] User common.js/css is being loaded twice.Jan 26 2022, 1:00 AM
Maintenance_bot removed a project: Patch-For-Review.Jan 26 2022, 1:10 AM
Jdlrobson closed this task as Resolved.Jan 26 2022, 1:41 AM

No longer seeing an exception on https://en.wikipedia.org?useskin=vector-2022 in incognito window.

Jdlrobson reopened this task as Open.Feb 2 2022, 4:30 PM

Apparently this is not fixed in wmf19 .

Jdlrobson merged a task: T300746: PHP Notice: Undefined index: data-user-page.Feb 2 2022, 4:30 PM
Jdlrobson added subscribers: dancy, Zabe.
Jdlrobson moved this task from Ready for Signoff to Needs More Work on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.Feb 2 2022, 4:34 PM

Weird. The patch is in the wmf19 branch so the fix may not have worked.

Jdlrobson added a comment.Feb 2 2022, 8:10 PM

The issue appears limited to desktop improvements wiki. I think it must relate to T300757 somehow.

This only seems to be possible if:

  • VectorSkin::isLegacy() is returning false.
  • Hooks::isSkinVersionLegacy() is returning true

I'm trying to work out under what scenario this would happen.

brennen added a project: User-brennen.Feb 2 2022, 8:12 PM
brennen moved this task from Backlog to Logs/Train on the User-brennen board.
Jdlrobson moved this task from Needs More Work to Doing on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.Feb 2 2022, 8:50 PM
gerritbot added a comment.Feb 2 2022, 9:55 PM

Change 759343 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/Vector@master] Pass skin name to Hooks::isSkinLegacy

https://gerrit.wikimedia.org/r/759343

gerritbot added a project: Patch-For-Review.Feb 2 2022, 9:55 PM
gerritbot added a comment.Feb 2 2022, 10:52 PM

Change 759343 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Pass skin name to Hooks::isSkinLegacy

https://gerrit.wikimedia.org/r/759343

ReleaseTaggerBot edited projects, added MW-1.38-notes (1.38.0-wmf.21; 2022-02-07); removed MW-1.38-notes (1.38.0-wmf.18; 2022-01-17).Feb 2 2022, 11:00 PM
Maintenance_bot removed a project: Patch-For-Review.Feb 2 2022, 11:10 PM
Jdlrobson removed Jdlrobson as the assignee of this task.Feb 2 2022, 11:41 PM
Jdlrobson moved this task from Doing to Code Review on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.
gerritbot added a comment.Feb 3 2022, 12:20 AM

Change 759309 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/Vector@wmf/1.38.0-wmf.19] Pass skin name to Hooks::isSkinLegacy

https://gerrit.wikimedia.org/r/759309

gerritbot added a project: Patch-For-Review.Feb 3 2022, 12:20 AM
gerritbot added a comment.Feb 3 2022, 12:37 AM

Change 759309 merged by jenkins-bot:

[mediawiki/skins/Vector@wmf/1.38.0-wmf.19] Pass skin name to Hooks::isSkinLegacy

https://gerrit.wikimedia.org/r/759309

Stashbot mentioned this in T299927: Deploy new Vector skin to all projects.Feb 3 2022, 12:44 AM

Mentioned in SAL (#wikimedia-operations) [2022-02-03T00:44:46Z] <brennen@deploy1002> Started scap: Backports: [[gerrit:759308|Changes the labels of the Vector skins (T299927)]] and [[gerrit:759309|Pass skin name to Hooks::isSkinLegacy (T299971)]]

ReleaseTaggerBot edited projects, added MW-1.38-notes (1.38.0-wmf.19; 2022-01-24); removed MW-1.38-notes (1.38.0-wmf.21; 2022-02-07).Feb 3 2022, 1:00 AM
gerritbot added a comment.Feb 3 2022, 1:09 AM

Change 759310 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/Vector@wmf/1.38.0-wmf.20] Pass skin name to Hooks::isSkinLegacy

https://gerrit.wikimedia.org/r/759310

Stashbot added a comment.Feb 3 2022, 1:09 AM

Mentioned in SAL (#wikimedia-operations) [2022-02-03T01:09:35Z] <brennen@deploy1002> Finished scap: Backports: [[gerrit:759308|Changes the labels of the Vector skins (T299927)]] and [[gerrit:759309|Pass skin name to Hooks::isSkinLegacy (T299971)]] (duration: 24m 48s)

Jdlrobson lowered the priority of this task from High to Medium.Feb 3 2022, 1:10 AM
Jdlrobson moved this task from Code Review to Doing on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.

I believe the impact on users is that they are not seeing icons on modern Vector:

image.png (1×2 px, 572 KB)

While I couldn't replicate, it looks like this was possible if $wgFullyInitialised = false at the time the hook is run, but is true, at the time the skin generates.

We backported https://gerrit.wikimedia.org/r/759309 to wmf19 and the errors seem to have disappeared.

We can backport that to wmf20 tomorrow if the errors resurface.

Jdlrobson moved this task from Doing to Code Review on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.Feb 3 2022, 1:23 AM

The issue is still on wmf20 so I'll look to fix that tomorrow.

gerritbot added a comment.Feb 3 2022, 7:25 PM

Change 759310 merged by jenkins-bot:

[mediawiki/skins/Vector@wmf/1.38.0-wmf.20] Pass skin name to Hooks::isSkinLegacy

https://gerrit.wikimedia.org/r/759310

Stashbot added a comment.Feb 3 2022, 7:34 PM

Mentioned in SAL (#wikimedia-operations) [2022-02-03T19:34:23Z] <taavi@deploy1002> Synchronized php-1.38.0-wmf.20/skins/Vector/includes/Hooks.php: Backport: [[gerrit:759310|Pass skin name to Hooks::isSkinLegacy (T299971)]] (duration: 00m 49s)

Jdlrobson claimed this task.Feb 3 2022, 7:44 PM
Jdlrobson moved this task from Code Review to Ready for Signoff on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.

Errors look like they've completely disappeared from wmf20. I'll close later today, after the roll out of the train provided they don't come back.

ReleaseTaggerBot edited projects, added MW-1.38-notes (1.38.0-wmf.20; 2022-01-31); removed MW-1.38-notes (1.38.0-wmf.19; 2022-01-24).Feb 3 2022, 8:00 PM
Maintenance_bot removed a project: Patch-For-Review.Feb 3 2022, 8:10 PM
Krinkle moved this task from Untriaged to Jan 2022 on the Wikimedia-production-error board.Feb 4 2022, 12:43 AM
Jdlrobson closed this task as Resolved.Feb 4 2022, 10:56 PM

Error has disappeared as expected

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL