Sticky header, footer and user menu should not show in @print mode
Closed, ResolvedPublic2 Estimated Story PointsBUG REPORT
Actions

Assigned To

Authored By

	Jdlrobson
	Jan 26 2022, 6:12 PM

Description

Expected: Sticky header should not show in @print mode

Actual: It's showing

QA steps 1

Visit any article
Scroll down so sticky header displays
Press CTRL+P

QA steps 2

(From T300253)
In Firefox 96, while logged in trying to print a page https://www.mediawiki.org/wiki/Accessibility on mediawiki.org while using Vector 2022.

Expected: search, footer AND personal menus should NOT be seen at the bottom:

Old Vector, for comparison:

QA Results - Beta

AC	Status	Details
1	✅	T300178#7747547
2	✅	T300178#7747547

QA Results - Prod

AC	Status	Details
1	✅	T300178#7845689
2	✅	T300178#7845689

Details

	Subject	Repo	Branch	Lines +/-
	Do not show footer menu in print mode	mediawiki/skins/Vector	master	+4 -5
	Hide sticky header and ULS button in print mode	mediawiki/skins/Vector	master	+8 -0

Customize query in gerrit

Related Objects

Mentioned Here: T300253: Navigation elements should not get printed

Event Timeline

Jdlrobson created this task.Jan 26 2022, 6:12 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 26 2022, 6:12 PM

Jdlrobson moved this task from Incoming to Sticky header on the Desktop Improvements (Vector 2022) board.Jan 26 2022, 10:35 PM

Jdlrobson moved this task from Incoming to Not ready to estimate on the Web-Team-Backlog board.Jan 26 2022, 10:54 PM

ovasileva triaged this task as Medium priority.Feb 8 2022, 3:21 PM

ovasileva edited projects, added Web-Team-Backlog (Kanbanana-FY-2021-22); removed Web-Team-Backlog.

Merged tasks as these can be fixed together.

Jdlrobson renamed this task from Sticky header and other navigation elements should not show in @print mode to Sticky header, footer and user menu should not show in @print mode.Feb 8 2022, 5:30 PM

Jdlrobson updated the task description. (Show Details)

LGoto moved this task from Upcoming to Ready for Development on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.Feb 15 2022, 6:24 PM

LGoto set the point value for this task to 2.

bwang moved this task from Ready for Development to Code Review on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.Feb 25 2022, 5:31 PM

Change 766173 had a related patch set uploaded (by Bernard Wang; author: Bernard Wang):

[mediawiki/skins/Vector@master] Hide sticky header and ULS button in print mode

https://gerrit.wikimedia.org/r/766173

gerritbot added a project: Patch-For-Review.Feb 25 2022, 5:32 PM

LGoto assigned this task to cjming.Feb 28 2022, 6:24 PM

cjming reassigned this task from cjming to Edtadros.Feb 28 2022, 10:45 PM

cjming moved this task from Code Review to QA on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.

cjming subscribed.

Change 766173 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Hide sticky header and ULS button in print mode

https://gerrit.wikimedia.org/r/766173

Maintenance_bot removed a project: Patch-For-Review.Feb 28 2022, 11:10 PM

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.24; 2022-02-28).Mar 1 2022, 12:00 AM

Test Result - Beta

Status: ✅ PASS
Environment: beta
OS: macOS Monterey
Browser: Chrome
Device: MBP
Emulated Device:NA

Test Artifact(s):

QA Steps

✅ AC1:
Visit any article
Scroll down so sticky header displays
Press CTRL+P
Sticky header should not show in @print mode

Screen Shot 2022-03-01 at 9.55.17 AM.png (906×1 px, 384 KB)

✅ AC1:
(From T300253)
In Firefox 96, while logged in trying to print a page while using Vector 2022, search, footer AND personal menus should not be seen at the bottom

Screen Shot 2022-03-01 at 9.56.28 AM.png (909×1 px, 377 KB)

Edtadros updated the task description. (Show Details)Mar 2 2022, 2:22 PM

Test Result - Prod

Status: ✅ PASS
Environment: enwiki
OS: macOS Monterey
Browser: Chrome
Device: MBP
Emulated Device:NA

Test Artifact(s):

QA Steps

✅ AC1:
Visit any article
Scroll down so sticky header displays
Press CTRL+P
Sticky header should not show in @print mode

Screen Shot 2022-03-07 at 9.30.01 AM.png (1×1 px, 467 KB)

✅ AC1:
(From T300253)
In Firefox 96, while logged in trying to print a page while using Vector 2022, search, footer AND personal menus should not be seen at the bottom

Screen Shot 2022-03-07 at 9.33.32 AM.png (1×1 px, 556 KB)

Looks good!

This is not fixed; the footer can still be seen on the last PDF page.

Aklapper merged a task: T304908: footer-places appears in Printable version.Mar 29 2022, 8:08 AM

Aklapper added a subscriber: Stang.

Jdlrobson moved this task from Ready for Signoff to Needs More Work on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.Mar 29 2022, 5:12 PM

LGoto reassigned this task from ovasileva to cjming.Mar 29 2022, 5:13 PM

LGoto added a subscriber: ovasileva.

cjming moved this task from Needs More Work to Doing on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.Mar 29 2022, 5:13 PM

Jdlrobson updated the task description. (Show Details)Mar 29 2022, 5:13 PM

Change 774984 had a related patch set uploaded (by Clare Ming; author: Clare Ming):

[mediawiki/skins/Vector@master] Do not show footer menu in print mode

https://gerrit.wikimedia.org/r/774984

gerritbot added a project: Patch-For-Review.Mar 29 2022, 11:26 PM

cjming removed cjming as the assignee of this task.Mar 29 2022, 11:27 PM

cjming moved this task from Doing to Code Review on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.

cjming assigned this task to Edtadros.Mar 30 2022, 12:04 AM

cjming moved this task from Code Review to QA on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.

Change 774984 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Do not show footer menu in print mode

https://gerrit.wikimedia.org/r/774984

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.6; 2022-04-04).Mar 30 2022, 1:00 AM

Maintenance_bot removed a project: Patch-For-Review.Mar 30 2022, 1:10 AM

Test Result - Beta

Status: ✅ PASS
Environment: beta
OS: macOS Monterey
Browser: Chrome
Device: MBP
Emulated Device:NA

Test Artifact(s):

QA Steps

✅ AC1:
Visit any article
Scroll down so sticky header displays
Press CTRL+P
Sticky header should not show in @print mode

✅ AC1:
(From T300253)
In Firefox 96, while logged in trying to print a page while using Vector 2022, search, footer AND personal menus should not be seen at the bottom

Screen Recording 2022-04-06 at 6.56.00 PM.mov.gif (850×1 px, 1 MB)

Test Result - Prod

Status: ✅ PASS
Environment: enwiki
OS: macOS Monterey
Browser: Chrome, Firefox 96
Device: MBP
Emulated Device:NA

Test Artifact(s):

QA Steps

✅ AC1:
Visit any article
Scroll down so sticky header displays
Press CTRL+P
Sticky header should not show in @print mode

Screen Recording 2022-04-11 at 9.41.08 AM.mov.gif (704×618 px, 1 MB)

✅ AC1:
(From T300253)
In Firefox 96, while logged in trying to print a page while using Vector 2022, search, footer AND personal menus should not be seen at the bottom

Screen Recording 2022-04-11 at 9.43.26 AM.mov.gif (736×622 px, 1 MB)

Edtadros updated the task description. (Show Details)Apr 11 2022, 4:46 PM

ovasileva closed this task as Resolved.Apr 12 2022, 9:42 AM

Stang unsubscribed.Apr 12 2022, 11:20 AM

	F35047044: Screen Recording 2022-04-11 at 9.41.08 AM.mov.gif
	Apr 11 2022, 4:45 PM

	F35047046: Screen Recording 2022-04-11 at 9.43.26 AM.mov.gif
	Apr 11 2022, 4:45 PM

	F35041806: Screen Recording 2022-04-06 at 6.56.00 PM.mov.gif
	Apr 7 2022, 1:57 AM

	F34982596: Screen Shot 2022-03-07 at 9.33.32 AM.png
	Mar 7 2022, 5:34 PM

	F34982590: Screen Shot 2022-03-07 at 9.30.01 AM.png
	Mar 7 2022, 5:34 PM

	F34971433: Screen Shot 2022-03-01 at 9.56.28 AM.png
	Mar 2 2022, 2:21 PM

	F34971431: Screen Shot 2022-03-01 at 9.55.17 AM.png
	Mar 2 2022, 2:21 PM

	F34932762: ajb50-00.png
	Feb 8 2022, 5:29 PM

Sticky header, footer and user menu should not show in @print modeClosed, ResolvedPublic2 Estimated Story PointsBUG REPORTActions

Description

QA steps 1

QA steps 2

QA Results - Beta

QA Results - Prod

Details

Related Objects

Event Timeline

Test Result - Beta

QA Steps

Test Result - Prod

QA Steps

Test Result - Beta

QA Steps

Test Result - Prod

QA Steps

Sticky header, footer and user menu should not show in @print mode
Closed, ResolvedPublic2 Estimated Story PointsBUG REPORT
Actions