Page MenuHomePhabricator
Create Task
Maniphest T300620

[Toggler] Certain links within the same article in WP don't open parent section
Closed, ResolvedPublicBUG REPORT
Actions

Description

List of steps to reproduce (step by step, including full links if applicable):

What happens?: Nothing, does not go to link in the "Wild Card Playoffs" section. Will work if the "Wild Card Playoffs" section is expanded. On reloading the page, it will work or not work depending on if the if the "Wild Card Playoffs" section is expanded or not just prior to reload. Same results in Chrome and Firefox browsers.

What should have happened instead?: Should have gone to the correct place (https://en.m.wikipedia.org/wiki/2021%E2%80%9322_NFL_playoffs#AFC:_Cincinnati_Bengals_26,_Las_Vegas_Raiders_19)

Software version (if not a Wikimedia wiki), browser information, screenshots, other information, etc.:

Details

SubjectRepoBranchLines +/-
Toggler: Fix revealing sections with special characters like `"` `,` `(`mediawiki/extensions/MobileFrontendmaster+9 -28
Customize query in gerrit

Related Objects
Search...

Event Timeline

Facts707 created this task.Feb 1 2022, 11:27 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 1 2022, 11:27 AM
Facts707 renamed this task from Links within the same article don't work in mobile unless that section is open to Links within the same article in WP don't work in mobile unless that section is open.Feb 1 2022, 11:28 AM
Facts707 renamed this task from Links within the same article in WP don't work in mobile unless that section is open to Links within the same article in WP don't work in mobile unless linked section is expanded.
Facts707 updated the task description. (Show Details)Feb 1 2022, 11:30 AM
Aklapper added a project: MobileFrontend.Feb 1 2022, 11:52 AM
cjming added a project: Web-Team-Backlog.Feb 2 2022, 5:17 PM
Jdlrobson renamed this task from Links within the same article in WP don't work in mobile unless linked section is expanded to Certain links within the same article in WP don't work in mobile unless linked section is expanded.Feb 4 2022, 10:51 PM
Jdlrobson renamed this task from Certain links within the same article in WP don't work in mobile unless linked section is expanded to [Toggler] Certain links within the same article in WP don't open parent section.
Jdlrobson added a parent task: T269623: [EPIC] Hash fragment/scroll handling is broken in mobile.Feb 4 2022, 10:53 PM
Jdlrobson added subscribers: ovasileva, Jdlrobson.

There are a growing number of problems with the mobile hash fragment code @ovasileva I've associated the relevant epic.

Jdlrobson moved this task from Incoming to Not ready to estimate on the Web-Team-Backlog board.Feb 4 2022, 10:54 PM
ovasileva triaged this task as Medium priority.Feb 7 2022, 9:50 AM
ovasileva edited projects, added Web-Team-Backlog (Needs Prioritization (Tech)); removed Web-Team-Backlog.

@Jdlrobson - would it make sense for this to be our next technical epic?

Jdlrobson added a comment.Feb 7 2022, 4:51 PM

Not our next one, as strategically this is not helpful at the current time, so if you want it fixed sooner rather than later, I'd recommend prioritizing it as a product goal. If we ever work on section collapsing in Vector then it would make sense to prioritize this as a technical goal.

Jdlrobson moved this task from Backlog to Future Unplanned on the Web-Team-Backlog (Needs Prioritization (Tech)) board.Feb 8 2022, 5:17 PM
Jdlrobson moved this task from Future Unplanned to Remove mobile diff and history page on the Web-Team-Backlog (Needs Prioritization (Tech)) board.Apr 5 2022, 3:32 PM
matmarex mentioned this in T301932: Topic subscription notifications do not take you to precise location where activity exists when sections are collapsed.May 12 2022, 10:45 PM
gerritbot added a comment.May 12 2022, 10:53 PM

Change 791464 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/MobileFrontend@master] Toggler: Fix revealing sections with special characters like `"` `,` `(`

https://gerrit.wikimedia.org/r/791464

gerritbot added a project: Patch-For-Review.May 12 2022, 10:53 PM
matmarex claimed this task.May 12 2022, 10:57 PM
matmarex subscribed.

We ran into the same issue with links to comments used by DiscussionTools (T301932).

gerritbot added a comment.May 13 2022, 4:54 PM

Change 791464 merged by jenkins-bot:

[mediawiki/extensions/MobileFrontend@master] Toggler: Fix revealing sections with special characters like `"` `,` `(`

https://gerrit.wikimedia.org/r/791464

Maintenance_bot removed a project: Patch-For-Review.May 13 2022, 5:30 PM
matmarex added a project: Editing-team (Kanban Board).May 13 2022, 10:27 PM
matmarex moved this task from Incoming to QA on the Editing-team (Kanban Board) board.
matmarex added a project: Editing QA.
ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.12; 2022-05-16).May 14 2022, 4:00 AM
matmarex moved this task from Inbox to Low Priority on the Editing QA board.May 23 2022, 5:34 PM
EAkinloose edited projects, added Verified; removed Editing QA.Jun 2 2022, 4:18 PM
EAkinloose moved this task from QA to Ready for Sign Off on the Editing-team (Kanban Board) board.
ppelberg closed this task as Resolved.Jun 3 2022, 11:12 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits