| Func | |
| Feb 21 2022, 11:45 AM |
| F34960520: T302214-0.PNG | |
| Feb 21 2022, 12:06 PM |
| F34960522: T302214-2.PNG | |
| Feb 21 2022, 12:06 PM |
| F34960521: T302214.PNG | |
| Feb 21 2022, 12:06 PM |
For entries of movements on the page history, we only have 'Undo' links which are completely useless and may confuse new users.
When users try to 'undo' a page move:
With this patch:
| Page history | Click on 'revert' |
 |  |
I uploaded a patch months ago, I think Desktop Improvements (Vector 2022) may interested in it, so I create this task hope to promote it.
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| pagers: Provide 'Revert' links for movements instead of 'Undo' links | mediawiki/core | master | +60 -4 |
Change 699023 had a related patch set uploaded (by Func; author: Func):
[mediawiki/core@master] HistoryPager: Provide 'Revert' links for movements instead of 'Undo' links
We're not planning to make any changes to history page as part of this project. Perhaps the Growth or moderator tools team would be interested?
@Func, thank you for this task and patch!
Per our maintenance responsibilities this isn't something that fits exactly in our currently scheduled work.
That said, @KStoller-WMF @Trizek-WMF may be interested to comment from a product / UX perspective, and we could try to find some time to help with code review. Perhaps there are volunteer contributors who would be interested to review this?
@Func, I miss some context here. Are you changing the word, or what is visible for a given user?
For common actions, "Undo" actions are accessible to all users. And moving a page can be done by autoconfirmed users (I.e. 4 days after registration). Is you patch displaying the link only to users who can make the action?
"Revert" is the common term in history pages (or RC, watchlist, logs) for rollback actions. This link is only available to Rollbackers. Displaying a "revert" link to users who don't have the right to use it would confuse users too, which is what you try to avoid. :)
@Trizek-WMF Thank you for your quick response. You can try it on the patch demo I created, and compare with any production or test environments.
FYI, I implemented a proper way to "undo" (or "revert", per revertmove message) a page move from links on the history page.
The "revertmove" message is used in move logs, I suppose it should be fine to be used here. Please feel free to suggest better words or we can keep using "undo".
If you have tried it or looked through the patch, you would find it does have permission checks.
The "revert" link for a page move is just a link for moving backwards and pre-filled "revert" as the reason.
This is the exactly same behaviour as clicking on "revert" links from move logs.