Page MenuHomePhabricator
Create Task
Maniphest T303135

Replace 2021 board election hack with proper fix
Closed, ResolvedPublic
Actions

Description

In https://gerrit.wikimedia.org/r/c/mediawiki/extensions/SecurePoll/+/709247 I added the following dirty hack, which hard-coded the wikis without securepoll to the codebase.

// TODO: Implement this properly and get rid of this hack
// SecurePoll is not installed on these
if ( $dbname == 'labtestwiki' || $dbname == 'labswiki' || $dbname == 'loginwiki' ) {
	continue;
}

It was added ~36 hours before the scheduled start of the election (it was later delayed) in order to fix T287780#7250890.

A proper fix should be implemented.

Details

SubjectRepoBranchLines +/-
Add $wgSecurePollExcludedWikis to exclude wikis from $wgConf->getLocalDatabases()mediawiki/extensions/SecurePollmaster+6 -3
Add $wgSecurePollExcludedWikis to exclude wikis from $wgConf->getLocalDatabases()mediawiki/extensions/SecurePollREL1_41+6 -3
Add $wgSecurePollExcludedWikis to exclude wikis from $wgConf->getLocalDatabases()mediawiki/extensions/SecurePollREL1_39+6 -3
Add $wgSecurePollExcludedWikis to exclude wikis from $wgConf->getLocalDatabases()mediawiki/extensions/SecurePollREL1_40+6 -3
CommonSettings: Add $wgSecurePollExcludedWikisoperations/mediawiki-configmaster+2 -0
Customize query in gerrit

Related Objects

Event Timeline

Zabe created this task.Mar 6 2022, 6:11 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 6 2022, 6:11 PM
Zabe updated the task description. (Show Details)Mar 6 2022, 6:11 PM
Reedy updated the task description. (Show Details)Mar 6 2022, 11:27 PM
jrbs moved this task from Backlog to Future WMF Election Requests on the MediaWiki-extensions-SecurePoll board.May 27 2022, 8:53 PM
jrbs subscribed.Jul 30 2022, 12:44 AM

Would this need to be implemented again for 2022?

Zabe added a comment.Jul 30 2022, 8:53 AM

This has never been removed from the codebase, see https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/extensions/SecurePoll/+/refs/heads/master/includes/Store/FormStore.php#343.

Otherwise it would have already fataled when you try to create a election.

jrbs triaged this task as High priority.Sep 23 2022, 10:15 PM
jrbs moved this task from Future WMF Election Requests to Needs evaluation on the MediaWiki-extensions-SecurePoll board.Sep 23 2022, 10:18 PM
jrbs moved this task from Needs evaluation to On deck on the MediaWiki-extensions-SecurePoll board.Sep 29 2022, 6:17 PM
gerritbot added a comment.Nov 8 2022, 2:41 PM

Change 854528 had a related patch set uploaded (by Pavlo Yashchenko; author: Pavlo Yashchenko):

[mediawiki/extensions/SecurePoll@master] Add wikis without SecurePoll to global config

https://gerrit.wikimedia.org/r/854528

gerritbot added a project: Patch-For-Review.Nov 8 2022, 2:41 PM
jrbs moved this task from On deck to Actively working on the MediaWiki-extensions-SecurePoll board.Nov 10 2022, 4:04 PM
jrbs added a comment.EditedJan 10 2023, 2:58 PM

Evaluation:

Simple change, low risk. few days

STran claimed this task.May 8 2023, 11:55 AM
STran added a project: Anti-Harassment (AHaT Sprint 29: The Ikseongwan).May 8 2023, 9:20 PM
STran moved this task from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to Code Review 🔍 on the Anti-Harassment (AHaT Sprint 29: The Ikseongwan) board.
Tchanders moved this task from AHaT Sprint 29: The Ikseongwan to AHaT Sprint 31 - The Fez on the Anti-Harassment board.May 9 2023, 5:26 PM
Tchanders edited projects, added Anti-Harassment (AHaT Sprint 31 - The Fez); removed Anti-Harassment (AHaT Sprint 29: The Ikseongwan).
Tchanders moved this task from AHaT Sprint 31 - The Fez to AHaT Sprint 32 - Baseball Cap on the Anti-Harassment board.Jun 6 2023, 2:14 PM
Tchanders edited projects, added Anti-Harassment (AHaT Sprint 32 - Baseball Cap); removed Anti-Harassment (AHaT Sprint 31 - The Fez).
Niharika removed a project: Anti-Harassment (AHaT Sprint 32 - Baseball Cap).Jun 20 2023, 5:52 PM
gerritbot added a comment.Mar 6 2024, 1:57 PM

Change 1008997 had a related patch set uploaded (by Reedy; author: Reedy):

[operations/mediawiki-config@master] CommonSettings: Add $wgSecurePollExcludedWikis

https://gerrit.wikimedia.org/r/1008997

gerritbot added a comment.Mar 14 2024, 6:58 PM

Change 1008997 merged by jenkins-bot:

[operations/mediawiki-config@master] CommonSettings: Add $wgSecurePollExcludedWikis

https://gerrit.wikimedia.org/r/1008997

Stashbot added a comment.Mar 14 2024, 7:14 PM

Mentioned in SAL (#wikimedia-operations) [2024-03-14T19:14:10Z] <reedy@deploy2002> Synchronized wmf-config/CommonSettings.php: T303135 (duration: 12m 24s)

gerritbot added a comment.Mar 14 2024, 7:15 PM

Change 854528 merged by jenkins-bot:

[mediawiki/extensions/SecurePoll@master] Add $wgSecurePollExcludedWikis to exclude wikis from $wgConf->getLocalDatabases()

https://gerrit.wikimedia.org/r/854528

gerritbot added a comment.Mar 14 2024, 7:16 PM

Change 1010935 had a related patch set uploaded (by Reedy; author: Pavlo Yashchenko):

[mediawiki/extensions/SecurePoll@REL1_41] Add $wgSecurePollExcludedWikis to exclude wikis from $wgConf->getLocalDatabases()

https://gerrit.wikimedia.org/r/1010935

gerritbot added a comment.Mar 14 2024, 7:17 PM

Change 1010936 had a related patch set uploaded (by Reedy; author: Pavlo Yashchenko):

[mediawiki/extensions/SecurePoll@REL1_40] Add $wgSecurePollExcludedWikis to exclude wikis from $wgConf->getLocalDatabases()

https://gerrit.wikimedia.org/r/1010936

gerritbot added a comment.Mar 14 2024, 7:17 PM

Change 1010937 had a related patch set uploaded (by Reedy; author: Pavlo Yashchenko):

[mediawiki/extensions/SecurePoll@REL1_39] Add $wgSecurePollExcludedWikis to exclude wikis from $wgConf->getLocalDatabases()

https://gerrit.wikimedia.org/r/1010937

Reedy closed this task as Resolved.Mar 14 2024, 7:18 PM
Reedy reassigned this task from STran to pyashchenko.
Reedy added a subscriber: STran.
gerritbot added a comment.Mar 14 2024, 7:20 PM

Change 1010936 merged by jenkins-bot:

[mediawiki/extensions/SecurePoll@REL1_40] Add $wgSecurePollExcludedWikis to exclude wikis from $wgConf->getLocalDatabases()

https://gerrit.wikimedia.org/r/1010936

gerritbot added a comment.Mar 14 2024, 7:20 PM

Change 1010935 merged by jenkins-bot:

[mediawiki/extensions/SecurePoll@REL1_41] Add $wgSecurePollExcludedWikis to exclude wikis from $wgConf->getLocalDatabases()

https://gerrit.wikimedia.org/r/1010935

gerritbot added a comment.Mar 14 2024, 7:20 PM

Change 1010937 merged by jenkins-bot:

[mediawiki/extensions/SecurePoll@REL1_39] Add $wgSecurePollExcludedWikis to exclude wikis from $wgConf->getLocalDatabases()

https://gerrit.wikimedia.org/r/1010937

Maintenance_bot removed a project: Patch-For-Review.Mar 14 2024, 7:30 PM
ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.23; 2024-03-19).Mar 14 2024, 8:00 PM
Tgr mentioned this in T373737: Disable irrelevant extensions on SUL3 login domain.Sun, Oct 27, 2:07 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits