⚓ T303227 Make a new release of the Services library

Subject	Repo	Branch	Lines +/-
Upgrade wikimedia/scoped-callback and wikimedia/services	mediawiki/core	master	+4 -2
Upgrade wikimedia/scoped-callback and wikimedia/services	mediawiki/vendor	master	+188 -167
bump wikimedia/services	mediawiki/core	master	+1 -1
build: Bring library up to current standards; install phan	mediawiki/libs/Services	master	+33 -26

		Status	Subtype	Assigned	Task
		Open	Release	None	T287972 Make new releases of all Wikimedia-authored PHP libraries, and bump their usages (mid-2021)
		Resolved		Reedy	T303227 Make a new release of the Services library

Jdforrester-WMF created this task.Mar 7 2022, 9:33 PM

Jdforrester-WMF mentioned this in T287972: Make new releases of all Wikimedia-authored PHP libraries, and bump their usages (mid-2021).

Change 768813 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/libs/Services@master] build: Bring library up to current standards; install phan

https://gerrit.wikimedia.org/r/768813

gerritbot added a project: Patch-For-Review.Mar 7 2022, 9:35 PM

Jdforrester-WMF mentioned this in T300840: Fatal error: Declaration of Wikimedia\Services\ServiceContainer::has($name) must be compatible with Psr\Container\ContainerInterface::has(string $id): bool.Mar 7 2022, 9:35 PM

In T300840#7758582, @Lucas_Werkmeister_WMDE wrote:

Does it have to be a 3.0.0? If I remember correctly, the new version is still supposed to be compatible with psr/container 1.1, so it shouldn’t be a breaking change.

We're going from ^1.0.0 to ^1.1 || ^2.0, which is a breaking change. (Your change c9102eb0 made that breakage.)

Fair enough. The actual breaking change was rMLSE51e070da97f0: Add strict type hints, but allow services to be "mixed" (has( string $name ) is only possible since 1.1), and I had it in my head that this had been included in a previous release already, but that doesn’t seem to be the case.

In T303227#7758619, @Lucas_Werkmeister_WMDE wrote:

Fair enough. The actual breaking change was rMLSE51e070da97f0: Add strict type hints, but allow services to be "mixed" (has( string $name ) is only possible since 1.1), and I had it in my head that this had been included in a previous release already, but that doesn’t seem to be the case.

Sadly not. :-( I don't think it's possible to make it mixed in practice and so backwards- and forwards-compatible. Oh well.

Change 768813 merged by jenkins-bot:

[mediawiki/libs/Services@master] build: Bring library up to current standards; install phan

https://gerrit.wikimedia.org/r/768813

Maintenance_bot removed a project: Patch-For-Review.Mar 9 2022, 6:10 PM

Jdforrester-WMF updated the task description. (Show Details)Mar 9 2022, 6:17 PM

https://github.com/wikimedia/mediawiki-libs-Services/compare/2.0.1...master

So the next release is version 3?

For some reason, T300840: Fatal error: Declaration of Wikimedia\Services\ServiceContainer::has($name) must be compatible with Psr\Container\ContainerInterface::has(string $id): bool bit me today. Using dev-master of this library worked.

Is there any opposition to tagging HEAD with 3.0.0 so composer can find it?

Reedy updated the task description. (Show Details)Jul 24 2022, 4:18 PM

Change 816314 had a related patch set uploaded (by Reedy; author: Reedy):