Page MenuHomePhabricator

self unblock with username does not work under 1.17
Closed, ResolvedPublic


User having user right unblockself cannot unblock himself on wmf wikis.

It works when specify the id of the block, but it does not work, when trying with the username.

The problem is in r68999:

$ip is the wrong var, you have to use $this->ip, because that reflect wpUnblockAddress, the form field with the username

Index: includes/specials/SpecialIpblocklist.php
@@ -77,7 +77,7 @@
-$user = User::newFromName( $ip );
+$user = User::newFromName( $this->ip );


Version: 1.17.x
Severity: normal



Event Timeline

bzimport raised the priority of this task from to Unbreak Now!.Nov 21 2014, 11:27 PM
bzimport set Reference to bz28352.
bzimport added a subscriber: Unknown Object (MLST). wrote:

I expect this is fixed in trunk; can you verify?

(In reply to comment #1)

I expect this is fixed in trunk; can you verify?

Yes, it works in trunk. It is possible per Special:Block/Username, but I cannot access Special:Block directly to type in my username, but that is ok, I think.

Which revision has the fix so we can merge it? wrote:

You'll need most of the blocking frontend rewrite, that's r83786 and friends, r83825, r83855, r83909, and most of their follow-ups. You probably won't need the backend stuff I did afterwards. I have no idea which of these contains the fix, and it almost certainly won't work without the others anyway.

It's very probably easier to do a quick hackfix in the REL1_17 branch and worry about reviewing all this for 1.18.

Can you do the quick fix for 1.17? We're already looking at the code for 1.18, so we'll make sure the rewrite is included there. wrote:

Fixed in r86409.