Page MenuHomePhabricator
Create Task
Maniphest T303524

TemplateWizard: Template not found on Wikimedia Commons
Closed, ResolvedPublic2 Estimated Story PointsBUG REPORT
Actions

Assigned To
thiemowmde
Authored By
JStrodt_WMDE
Mar 10 2022, 2:59 PM
Tags
Referenced Files
F34997342: Peek 2022-03-10 17-05.gif
Mar 10 2022, 4:09 PM
F34997203: Peek 2022-03-10 16-12.gif
Mar 10 2022, 3:19 PM
F34997021: vorlage bild 1.png
Mar 10 2022, 2:59 PM
F34997031: vorlage bild 2.png
Mar 10 2022, 2:59 PM
Subscribers
Aklapper
awight
JStrodt_WMDE
Lena_WMDE
lilients_WMDE

Description

A user reported this behavior on Wikimedia Commons:

  • I am using the classic wikitext editor.
  • I open the TemplateWizard to insert a template.
  • I type "Kulturdenkmal". I get an exhaustive list of template names. This list doesn't include the template "Kulturdenkmal Sachsen".

vorlage bild 1.png (882×1 px, 140 KB)

  • I keep typing, "Kulturdenkmal S". Now the list is empty.
  • Expected behavior: The templates "Kulturdenkmal Sachsen" and "Kulturdenkmal Sachsen-Anhalt" should have been displayed.

vorlage bild 2.png (888×1 px, 75 KB)

  • Even if I insert the full template name, the template often doesn't appear in the list.
  • When I gradually delete characters from my search, the template appears.

Details

SubjectRepoBranchLines +/-
Update template search fallback to max out at 10mediawiki/extensions/VisualEditormaster+16 -18
Fix random template search result order in prefixsearch fallbackmediawiki/extensions/TemplateWizardmaster+13 -4
Drop assumption that all template search index start at 1mediawiki/extensions/VisualEditormaster+7 -17
Disable useless "showMissing" option in TemplateTitleInputWidgetmediawiki/extensions/VisualEditormaster+6 -1
Fill template search results with prefix matches when Cirrus failsmediawiki/extensions/VisualEditormaster+12 -9
Fill template search results with prefix matches when Cirrus failsmediawiki/extensions/TemplateWizardmaster+10 -9
Fix copy-paste mistake in template search widgetmediawiki/extensions/TemplateWizardwmf/1.38.0-wmf.25+1 -1
Fix copy-paste mistake in template search widgetmediawiki/extensions/TemplateWizardmaster+1 -1
Customize query in gerrit

Related Objects
Search...

Event Timeline

JStrodt_WMDE created this task.Mar 10 2022, 2:59 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 10 2022, 2:59 PM
lilients_WMDE subscribed.Mar 10 2022, 3:19 PM

I could reproduce it and made a screencast.

Peek 2022-03-10 16-12.gif (852×1 px, 516 KB)
I looks like there is a gap between "Kulturdenkmal_S" and "Kulturdenkmal_Sac".

lilients_WMDE added a project: WMDE-TechWish-Sprint-2022-03-02.Mar 10 2022, 3:50 PM
lilients_WMDE claimed this task.Mar 10 2022, 3:52 PM
lilients_WMDE moved this task from Sprint Backlog to Doing on the WMDE-TechWish-Sprint-2022-03-02 board.
lilients_WMDE added a comment.Mar 10 2022, 4:09 PM

We also have the issue in visual editor.

Peek 2022-03-10 17-05.gif (963×1 px, 329 KB)
In this example the result list is not empty but the result set is changing completly.

lilients_WMDE removed lilients_WMDE as the assignee of this task.Mar 10 2022, 4:42 PM
lilients_WMDE moved this task from Doing to Sprint Backlog on the WMDE-TechWish-Sprint-2022-03-02 board.
gerritbot added a comment.Mar 14 2022, 1:44 PM

Change 770503 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/TemplateWizard@master] Fix copy-paste mistake in template search widget

https://gerrit.wikimedia.org/r/770503

gerritbot added a project: Patch-For-Review.Mar 14 2022, 1:45 PM
gerritbot added a comment.Mar 14 2022, 5:19 PM

Change 770503 merged by jenkins-bot:

[mediawiki/extensions/TemplateWizard@master] Fix copy-paste mistake in template search widget

https://gerrit.wikimedia.org/r/770503

gerritbot added a comment.Mar 14 2022, 5:31 PM

Change 770057 had a related patch set uploaded (by WMDE-Fisch; author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/TemplateWizard@wmf/1.38.0-wmf.25] Fix copy-paste mistake in template search widget

https://gerrit.wikimedia.org/r/770057

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.26; 2022-03-14).Mar 14 2022, 6:00 PM
Lena_WMDE moved this task from Backlog to In sprint on the WMDE-Templates-FocusArea board.Mar 15 2022, 10:26 AM
gerritbot added a comment.Mar 15 2022, 1:04 PM

Change 770057 merged by jenkins-bot:

[mediawiki/extensions/TemplateWizard@wmf/1.38.0-wmf.25] Fix copy-paste mistake in template search widget

https://gerrit.wikimedia.org/r/770057

Maintenance_bot removed a project: Patch-For-Review.Mar 15 2022, 1:10 PM
Stashbot added a comment.Mar 15 2022, 1:15 PM

Mentioned in SAL (#wikimedia-operations) [2022-03-15T13:15:07Z] <awight@deploy1002> Synchronized php-1.38.0-wmf.25/extensions/TemplateWizard/resources/ext.TemplateWizard.SearchField.js: Backport: [[gerrit:770057|Fix copy-paste mistake in template search widget (T303524)]] (duration: 00m 49s)

ReleaseTaggerBot edited projects, added MW-1.38-notes (1.38.0-wmf.25; 2022-03-07); removed MW-1.38-notes (1.38.0-wmf.26; 2022-03-14).Mar 15 2022, 2:00 PM
lilients_WMDE moved this task from Sprint Backlog to Demo on the WMDE-TechWish-Sprint-2022-03-02 board.Mar 15 2022, 2:24 PM
WMDE-Fisch added a project: WMDE-TechWish-Sprint-2022-03-16.Mar 16 2022, 9:19 AM
Lena_WMDE moved this task from Sprint Backlog to Demo on the WMDE-TechWish-Sprint-2022-03-16 board.Mar 16 2022, 9:21 AM
JStrodt_WMDE added a comment.Mar 16 2022, 2:25 PM

The user checked if the issue still occurred after the deployment:

Translation:

the behavior has not changed. But there is this change: when I enter "Kulturdenkmal S", a template "Kulturdenkmal Sachsen/en" appears for selection - but only this English template documentation. only with further letters also the "main template" for "Kulturdenkmal Sachsen" appears as well as further language versions and also the template "Kulturdenkmal Sachsen-Anhalt" with the language versions.
the offered templates are "wildly mixed up" there is no logical sorting for me. the display of the offered templates is still almost the same as in the screenshots sent yesterday.

original comment: https://de.wikipedia.org/wiki/Wikipedia_Diskussion:Technische_W%C3%BCnsche/Topw%C3%BCnsche/Vorlagen_suchen_und_einf%C3%BCgen#Auf_Commons_geht_es_langsamer_bzw_nicht_sofort_alle_vorlagen

WMDE-Fisch mentioned this in T304069: Investigation: Test search cases when users look for two / three word templates.Mar 17 2022, 12:44 PM
WMDE-Fisch mentioned this in T304071: Investigation: Does the user lang influence search results?.Mar 17 2022, 12:48 PM
awight moved this task from Demo to Sprint Backlog on the WMDE-TechWish-Sprint-2022-03-16 board.Mar 18 2022, 1:27 PM
awight subscribed.

Verified not fixed, the desired page should have shown up after "Kulturdenkmal S". As I remember we were also trying to filter out subpages.

awight added a comment.Mar 18 2022, 3:28 PM

We discovered that the most annoying use case, where only one result is returned and it's not the right one, mainly happens when the search API returns no results. In this case, we show the first prefix search result and nothing else. Our provisional suggestion is that in this case we should show all of the prefix search results, basically falling back to the previous behavior before our changes.

lilients_WMDE added a comment.Mar 18 2022, 3:43 PM

It looks like this is an issue that is already known for a while: https://phabricator.wikimedia.org/T85770.

gerritbot added a comment.Mar 21 2022, 2:34 PM

Change 772405 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/TemplateWizard@master] Fill template search results with prefix matches when Cirrus fails

https://gerrit.wikimedia.org/r/772405

gerritbot added a project: Patch-For-Review.Mar 21 2022, 2:34 PM
lilients_WMDE moved this task from Sprint Backlog to Tech Review on the WMDE-TechWish-Sprint-2022-03-16 board.Mar 21 2022, 2:43 PM
gerritbot added a comment.Mar 21 2022, 2:47 PM

Change 772409 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/VisualEditor@master] Template dialog: Fall back to prefix search when Cirrus fails

https://gerrit.wikimedia.org/r/772409

thiemowmde claimed this task.Mar 21 2022, 2:48 PM
thiemowmde added a subtask: T304069: Investigation: Test search cases when users look for two / three word templates.Mar 29 2022, 10:20 AM
thiemowmde mentioned this in T304925: Properly fall back to prefixsearch when CirrusSearch returns nothing.Mar 29 2022, 10:30 AM
awight added a project: WMDE-TechWish-Sprint-2022-03-30.Mar 30 2022, 8:12 AM
thiemowmde moved this task from Sprint Backlog to Tech Review on the WMDE-TechWish-Sprint-2022-03-30 board.Mar 30 2022, 8:12 AM
thiemowmde moved this task from Tech Review to Doing on the WMDE-TechWish-Sprint-2022-03-30 board.Apr 4 2022, 8:55 AM
WMDE-Fisch closed subtask T304069: Investigation: Test search cases when users look for two / three word templates as Resolved.Apr 7 2022, 10:39 AM
awight moved this task from Doing to Demo on the WMDE-TechWish-Sprint-2022-03-30 board.Apr 8 2022, 11:42 AM
gerritbot added a comment.Apr 8 2022, 11:57 AM

Change 772409 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Fill template search results with prefix matches when Cirrus fails

https://gerrit.wikimedia.org/r/772409

gerritbot added a comment.Apr 8 2022, 11:57 AM

Change 772405 merged by jenkins-bot:

[mediawiki/extensions/TemplateWizard@master] Fill template search results with prefix matches when Cirrus fails

https://gerrit.wikimedia.org/r/772405

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.7; 2022-04-11).Apr 8 2022, 12:00 PM
Maintenance_bot removed a project: Patch-For-Review.Apr 8 2022, 12:30 PM
thiemowmde closed subtask T304925: Properly fall back to prefixsearch when CirrusSearch returns nothing as Resolved.Apr 12 2022, 8:53 AM
thiemowmde added a project: WMDE-TechWish-Sprint-2022-04-13.Apr 12 2022, 9:02 AM

Partly demoed today. Missing:

  • Fallback to 10 results is not yet visible on Wikimedia Commons. To be demoed later.
  • One of the 2 implementations is not 100% complete. A last patch is still missing.
    • The TemplateWizard was already changed from an adaptive approach to "always query 10 prefixsearch results".
    • The VisualEditor patch was not so easy to update. We merged the adaptive approach as an intermediate step. It's already better in all situations, just not "perfect".
thiemowmde moved this task from Sprint Backlog to Doing on the WMDE-TechWish-Sprint-2022-04-13 board.Apr 12 2022, 9:03 AM
thiemowmde set the point value for this task to 2.Apr 13 2022, 12:56 PM
thiemowmde mentioned this in T306428: Wildcard searches like "T*" sometimes refuse to find words that start with T.Apr 19 2022, 10:07 AM
gerritbot added a comment.Apr 19 2022, 12:34 PM

Change 784253 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/VisualEditor@master] Drop assumption that all template search index start at 1

https://gerrit.wikimedia.org/r/784253

gerritbot added a project: Patch-For-Review.Apr 19 2022, 12:34 PM
gerritbot added a comment.Apr 19 2022, 1:13 PM

Change 784260 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/VisualEditor@master] Update template search fallback to max out at 10

https://gerrit.wikimedia.org/r/784260

gerritbot added a comment.Apr 19 2022, 1:38 PM

Change 784261 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/VisualEditor@master] Disable useless "showMissing" option in TemplateTitleInputWidget

https://gerrit.wikimedia.org/r/784261

gerritbot added a comment.Apr 19 2022, 2:24 PM

Change 784268 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/TemplateWizard@master] Fix random template search result order in prefixsearch fallback

https://gerrit.wikimedia.org/r/784268

thiemowmde moved this task from Doing to Tech Review on the WMDE-TechWish-Sprint-2022-04-13 board.Apr 19 2022, 2:24 PM
gerritbot added a comment.Apr 20 2022, 3:05 PM

Change 784261 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Disable useless "showMissing" option in TemplateTitleInputWidget

https://gerrit.wikimedia.org/r/784261

ReleaseTaggerBot edited projects, added MW-1.39-notes (1.39.0-wmf.9; 2022-04-25); removed MW-1.39-notes (1.39.0-wmf.7; 2022-04-11).Apr 20 2022, 4:00 PM
gerritbot added a comment.Apr 21 2022, 10:13 AM

Change 784253 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Drop assumption that all template search index start at 1

https://gerrit.wikimedia.org/r/784253

gerritbot added a comment.Apr 21 2022, 11:59 AM

Change 784260 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Update template search fallback to max out at 10

https://gerrit.wikimedia.org/r/784260

gerritbot added a comment.Apr 22 2022, 12:18 PM

Change 784268 merged by jenkins-bot:

[mediawiki/extensions/TemplateWizard@master] Fix random template search result order in prefixsearch fallback

https://gerrit.wikimedia.org/r/784268

WMDE-Fisch moved this task from Tech Review to Demo on the WMDE-TechWish-Sprint-2022-04-13 board.Apr 22 2022, 1:32 PM
Lena_WMDE closed this task as Resolved.Apr 26 2022, 8:51 AM
Lena_WMDE moved this task from Demo to Done on the WMDE-TechWish-Sprint-2022-04-13 board.
Lena_WMDE subscribed.

@JStrodt_WMDE FYI this should be fixed and live on Commons

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits