RL targets for gadget definition pages
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	SD0001
	Mar 13 2022, 1:08 PM

Description

Currently, MediaWiki:Gadgets-definition allows setting targets= with default being just desktop.
But Gadget definition namespace pages don't allow setting targets. The default is desktop. There's no way to enable a gadget on mobile. This is a clear bug, and hence a blocker for gadget repo migration.

Possible solutions:

Add targets option in gadget definition namespace. (A patch by @Lens0021 exists - https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Gadgets/+/616197). Default remains just desktop.
Add targets option but make the default desktop+mobile.
In light of T127268, don't add a targets option and always use desktop+mobile. This means during the migration, all gadgets would start loading on mobile, likely causing increase in logged client-side errors (T262493)

Details

	Subject	Repo	Branch	Lines +/-
	Add missing targets option	mediawiki/extensions/Gadgets	master	+10 -0

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved	BUG REPORT	Jdlrobson	T328610 Default gadgets to run on mobile
		Resolved		Lens0021	T303681 RL targets for gadget definition pages

Event Timeline

SD0001 created this task.Mar 13 2022, 1:08 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 13 2022, 1:08 PM

Lens0021 awarded a token.Apr 22 2022, 3:15 PM

Lens0021 added a parent task: T328610: Default gadgets to run on mobile.Feb 6 2023, 1:36 PM

IMO gadgets need a target option, even if the target option for ResourceLoader modules in general goes away. The general recommendation is that the code adding/loading the module should check first if it's on mobile; there needs to be a way to do that in a gadget definition.

Tgr mentioned this in T328610: Default gadgets to run on mobile.Feb 6 2023, 6:29 PM

Yes.

Please see T204201.

Capabilities to tailor gadget activation on current page context shall be extended, not cut back by this suggestion.

Change 616197 had a related patch set uploaded (by Lens0021; author: Lens0021):

[mediawiki/extensions/Gadgets@master] Add missing targets option

https://gerrit.wikimedia.org/r/616197

gerritbot added a project: Patch-For-Review.Mar 5 2023, 5:37 AM

Tgr closed this task as Resolved.Mar 20 2023, 9:07 AM

Tgr assigned this task to Lens0021.

Change 616197 merged by jenkins-bot:

[mediawiki/extensions/Gadgets@master] Add missing targets option