Page MenuHomePhabricator
Create Task
Maniphest T304645

Update 'permission error' page when user tries to access event center & not logged in
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

Background: Right now, if someone tries to go directly to the event center and they are not logged in (for example, they try to access the url or go to it via list of special pages), they get a permission error page that is not user-friendly. This should be changed to a different page that lets them know how they can access the event center and that is more user-friendly.

How this will be done: redirect the user to the login page with redirect parameter so that after they sign up/log in, they will be brought back to the event centre.

Details

SubjectRepoBranchLines +/-
Check that the user is logged in when creating registrationsmediawiki/extensions/CampaignEventsmaster+118 -22
Customize query in gerrit

Related Objects

Event Timeline

ifried created this task.Mar 24 2022, 6:51 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 24 2022, 6:51 PM
ifried moved this task from Backlog to Jan-June 2023 on the Campaign-Registration board.Mar 24 2022, 6:51 PM
ifried added a subscriber: gonyeahialam.Mar 31 2022, 5:11 PM
• vyuen set the point value for this task to 1.Mar 31 2022, 5:18 PM
• vyuen subscribed.

Decision: redirect the user to the login page with redirect parameter so that after they sign up/log in, they will be brought back to the event centre. Will update the task description with this shortly.

Daimona claimed this task.Mar 31 2022, 6:22 PM
gerritbot added a comment.Mar 31 2022, 6:23 PM

Change 775917 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[mediawiki/extensions/CampaignEvents@master] Check that the user is logged in when creating registrations

https://gerrit.wikimedia.org/r/775917

gerritbot added a project: Patch-For-Review.Mar 31 2022, 6:23 PM
gerritbot added a comment.Apr 1 2022, 2:40 PM

Change 775917 merged by jenkins-bot:

[mediawiki/extensions/CampaignEvents@master] Check that the user is logged in when creating registrations

https://gerrit.wikimedia.org/r/775917

Daimona mentioned this in rUCAM7488e988a032: Check that the user is logged in when creating registrations.Apr 1 2022, 2:40 PM
Daimona edited projects, added Campaign-Tools (Campaign-Tools-Sprint-9); removed Campaign-Tools.Apr 1 2022, 2:46 PM
Daimona removed a project: Patch-For-Review.
Daimona moved this task from Ready 🎬 to Product sign-off 🤘 on the Campaign-Tools (Campaign-Tools-Sprint-9) board.
ifried updated the task description. (Show Details)Apr 1 2022, 4:20 PM
ifried updated the task description. (Show Details)Apr 1 2022, 4:22 PM

@Daimona do you think it makes sense to save this as a ticket that we QA, since we will have a QA person coming soon, or no?

Daimona added a comment.Apr 1 2022, 4:24 PM
In T304645#7824991, @ifried wrote:

@Daimona do you think it makes sense to save this as a ticket that we QA, since we will have a QA person coming soon, or no?

Certainly! Actually, I believe that every task in product sign-off with something user-facing would have to be tested.

ifried added a comment.Apr 1 2022, 4:26 PM

Yup, exactly. So I will move this ticket to QA and to sprint 10, so it can be a task awaiting our new QA person :)

ifried moved this task from Product sign-off 🤘 to QA 🐛 on the Campaign-Tools (Campaign-Tools-Sprint-9) board.Apr 1 2022, 4:26 PM
ldelench_wmf edited projects, added Campaign-Tools (Campaign-Tools-Sprint-10); removed Campaign-Tools (Campaign-Tools-Sprint-9).Apr 3 2022, 12:05 PM
ldelench_wmf moved this task from Ready 🎬 to QA 🐛 on the Campaign-Tools (Campaign-Tools-Sprint-10) board.Apr 3 2022, 12:07 PM
• vyuen mentioned this in T305708: Pre-QTE tasks roll up.Apr 8 2022, 3:23 PM
• vyuen moved this task from QA 🐛 to Product sign-off 🤘 on the Campaign-Tools (Campaign-Tools-Sprint-10) board.Apr 14 2022, 5:24 PM
ldelench_wmf edited projects, added Campaign-Tools (Campaign-Tools-Sprint-11); removed Campaign-Tools (Campaign-Tools-Sprint-10).Apr 19 2022, 9:22 PM
ldelench_wmf moved this task from Ready 🎬 to Product sign-off 🤘 on the Campaign-Tools (Campaign-Tools-Sprint-11) board.Apr 19 2022, 9:59 PM
ifried added a comment.EditedApr 29 2022, 9:35 PM

This may also be good for QTE. Do you agree, @Daimona & @vyuen?

Nothing for me to test (from my understanding) at this point, so I'll mark this as Done.

ifried closed this task as Resolved.Apr 29 2022, 9:48 PM
ifried moved this task from Product sign-off 🤘 to Done 🏁 on the Campaign-Tools (Campaign-Tools-Sprint-11) board.
Daimona added a comment.Apr 30 2022, 8:23 AM
In T304645#7892777, @ifried wrote:

This may also be good for QTE. Do you agree, @Daimona & @vyuen?

Yup

ifried added a comment.May 2 2022, 5:12 PM

Added to T305708

• vyuen moved this task from Jan-June 2023 to V0 on the Campaign-Registration board.Sep 5 2022, 4:09 PM
sbassett mentioned this in T290248: Security Readiness Review For Campaigns Registration System.Sep 30 2022, 7:58 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits