Page MenuHomePhabricator
Create Task
Maniphest T304705

videojs TypeError: Cannot read property 'then' of undefined
Closed, ResolvedPublicBUG REPORT
Actions

Description

at MediaElement.playInlineOrOpenDialog <anonymous>:310:298
at MediaElement.clickHandler <anonymous>:309:828
at HTMLAnchorElement.jQuery.event.dispatch https://www.mediawiki.org/w/load.php?lang=en&modules=jquery%7Cmediawiki.action.view.metadata&skin=vector-2022&version=1ig8m:70:260
at HTMLAnchorElement.elemData.handle https://www.mediawiki.org/w/load.php?lang=en&modules=jquery%7Cmediawiki.action.view.metadata&skin=vector-2022&version=1ig8m:66:877

This happened on an original file which was not supported on the platform (macOS), that did not have transcode derivatives

Details

SubjectRepoBranchLines +/-
Older browser do not return a promise from .play()mediawiki/extensions/TimedMediaHandlerwmf/1.39.0-wmf.6+21 -12
Older browser do not return a promise from .play()mediawiki/extensions/TimedMediaHandlermaster+21 -12
Customize query in gerrit

Related Objects

Event Timeline

TheDJ created this task.Mar 25 2022, 3:08 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 25 2022, 3:08 PM
TheDJ changed the subtype of this task from "Task" to "Bug Report".Mar 25 2022, 3:09 PM
Jdlrobson triaged this task as High priority.Apr 7 2022, 2:53 PM
Jdlrobson subscribed.

37 errors a day. For French this is a top ten JS error so I'd suggest fixing it before rolling out further.

• brooke subscribed.Apr 7 2022, 5:16 PM

Looks like we should escalate this. Let's assign it at our meeting today.

TheDJ added a comment.Apr 7 2022, 5:41 PM

I'm wondering if this is older browsers not having play return a promise.... will check in logstash what i can find.

Jdlrobson added a comment.Apr 7 2022, 5:53 PM

Bug is limited to Edge, Chrome > 50 < 60
https://logstash.wikimedia.org/goto/adee4920edff09e5b577341e1935b1a9

Jdforrester-WMF subscribed.Apr 7 2022, 5:53 PM

This might be an Edge-only issue?

Ladsgroup subscribed.Apr 7 2022, 6:02 PM
TheDJ moved this task from Backlog to Active on the VideoJS player board.Apr 7 2022, 7:20 PM
TheDJ added a comment.EditedApr 7 2022, 7:46 PM

It's not limited to Edge. There clearly are also lots of errors from older devices.
https://logstash.wikimedia.org/goto/8b476bbff31cce75a4032be21afc8bf7

The strange thing... is that its supposed to return a promise starting chrome 50... And the edge problems are indeed chrome 50 to chrome 60 versions... Kinda strange, but maybe they had to implement it at a browser specific layer... Seems Edge 17+ is the cutoff

gerritbot added a comment.Apr 7 2022, 7:50 PM

Change 778347 had a related patch set uploaded (by TheDJ; author: TheDJ):

[mediawiki/extensions/TimedMediaHandler@master] Older browser do not return a promise from .play()

https://gerrit.wikimedia.org/r/778347

gerritbot added a project: Patch-For-Review.Apr 7 2022, 7:50 PM
gerritbot added a comment.Apr 7 2022, 9:12 PM

Change 778347 merged by jenkins-bot:

[mediawiki/extensions/TimedMediaHandler@master] Older browser do not return a promise from .play()

https://gerrit.wikimedia.org/r/778347

Maintenance_bot removed a project: Patch-For-Review.Apr 7 2022, 9:31 PM
ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.7; 2022-04-11).Apr 7 2022, 10:00 PM
TheDJ added a comment.Apr 7 2022, 10:31 PM

Wanna keep this ticket open till the next deploys, so we can verify the errors have actually disappeared.

gerritbot added a comment.Apr 8 2022, 8:18 AM

Change 778238 had a related patch set uploaded (by TheDJ; author: TheDJ):

[mediawiki/extensions/TimedMediaHandler@wmf/1.39.0-wmf.6] Older browser do not return a promise from .play()

https://gerrit.wikimedia.org/r/778238

gerritbot added a project: Patch-For-Review.Apr 8 2022, 8:18 AM
TheDJ added a comment.Apr 8 2022, 8:21 AM

@Ladsgroup we are at 240 errors a day now, so I made a cherry pick, just in case

Ladsgroup added a comment.Apr 8 2022, 8:25 AM

Thanks. Friday is a no-deploy day but I will deploy it first thing on Monday.

TheDJ mentioned this in T305778: TypeError: playPromise is undefined.Apr 11 2022, 7:10 AM
TheDJ merged a task: T305778: TypeError: playPromise is undefined.
TheDJ added a subscriber: Krinkle.
gerritbot added a comment.Apr 11 2022, 9:57 AM

Change 778238 merged by jenkins-bot:

[mediawiki/extensions/TimedMediaHandler@wmf/1.39.0-wmf.6] Older browser do not return a promise from .play()

https://gerrit.wikimedia.org/r/778238

Stashbot added a comment.Apr 11 2022, 9:59 AM

Mentioned in SAL (#wikimedia-operations) [2022-04-11T09:58:59Z] <ladsgroup@deploy1002> Synchronized php-1.39.0-wmf.6/extensions/TimedMediaHandler/resources/ext.tmh.player.element.js: Backport: [[gerrit:778238|Older browser do not return a promise from .play() (T304705)]] (duration: 00m 52s)

ReleaseTaggerBot edited projects, added MW-1.39-notes (1.39.0-wmf.6; 2022-04-04); removed MW-1.39-notes (1.39.0-wmf.7; 2022-04-11).Apr 11 2022, 10:00 AM
Maintenance_bot removed a project: Patch-For-Review.Apr 11 2022, 10:30 AM
Ladsgroup closed this task as Resolved.Apr 11 2022, 10:56 AM
Ladsgroup assigned this task to TheDJ.
Jdlrobson mentioned this in T248418: Roll out videojs as the only video/audio player on all Wikimedia wikis.May 2 2022, 3:59 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits