Adding the following rule seems to fix it:

.action-history .mw-pager-body .mw-history-compareselectedversions {
  z-index: 0;
}

Seems like an issue in the skin's core CSS instead of IPInfo. (file is skinStyles/mediawiki.action.history.styles.less).

Change #1082206 had a related patch set uploaded (by Matr1x; author: Matr1x):

[mediawiki/skins/MinervaNeue@master] Allow IP information popup to overlay on top of "compare selected versions" box

https://gerrit.wikimedia.org/r/1082206

I can't replicate the steps here. I assume I need certain user permissions - what are they? I'm also confused as the "compare selected revisions" button does not appear as blue to me.

Is the IP masking popup using @z-index-overlay ?
https://doc.wikimedia.org/codex/latest/design-tokens/z-index.html

Go to https://test.wikipedia.org/wiki/Special:Preferences#mw-prefsection-betafeatures and enable IP information.
Then go to https://test.wikipedia.org/w/index.php?title=Dsa561dsa56&limit=500&action=history&useskin=minerva scroll to the bottom and click on the little information button. The issue described should appear.

I don't think the z-index for the IP masking popup matters anyway, the sticky position of the bottom set of "compare selected version" buttons seem to make it go on top no matter how high the z-index of the IP info popup is. I don't understand why their position is sticky anyway, we don't need two sets of buttons following the user. Therefore, I just set the bottom version of mw-history-compareselectedversions to have relative positioning, and set the z-index to @z-index-base.

scroll to the bottom and click on the little information button. The issue described should appear.

I don't see the little information button even with the beta feature enabled. I think I need some kind of user permission?
I'll try and set this up locally. I just need to be able to reproduce this to test your patch. I also want to make sure the IP masking popup is using the z–index as if it is not, there are likely bugs elsewhere.

we don't need two sets of buttons following the user.

I also see only one sticky positioned button.

To clarify we are talking about the same thing:

• only the first one has sticky behaviour
• The CSS rule is unintentionally applying to the other.

I agree we don't want to apply the rule to it.

You might need to go to https://test.wikipedia.org/wiki/Special:Contributions/177.193.205.164, click "IP Information" and agree to the guidelines first.

While you can only see one sticky positioned set of buttons, the rule is for some reason applying to both. I phrased it wrong. Your clarification is correct.

We should probably also set the z-index for the IPInfo. I checked modules/ext.ipInfo/popup/popup.less, and there is no z-index set, while the position is absolute.

Change #1082206 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@master] Allow IP information popup to overlay on top of "compare selected versions" box

https://gerrit.wikimedia.org/r/1082206

Change #1082724 had a related patch set uploaded (by Matr1x; author: Matr1x):

[mediawiki/extensions/IPInfo@master] Add z-index to IPInfo overlay

https://gerrit.wikimedia.org/r/1082724

Change #1082724 merged by jenkins-bot:

[mediawiki/extensions/IPInfo@master] Add z-index to IPInfo overlay

https://gerrit.wikimedia.org/r/1082724

The IPInfo popup now appears above the "Compare selected revisions" button.

Test environment: local docker IP Info 0.0.0 (e417a77) 07:18, 12 November 2024.