I think ogvjs has become ES6 recently, but it isn't marked as es6 code ?
This causes errors on IE11
This likely happens for both the old and the new player, but as we have no client logging for IE11 it was hidden that this was throwing errors on IE11.
SCRIPT1002: Syntax error
ogv-support.js (1,4)
https://commons.wikimedia.org/w/extensions/TimedMediaHandler/resources/mwembed/lib/binPlayers/ogv.js/ogv-support.js?e4734
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Mark TMH modules as requiring ES6 | mediawiki/extensions/TimedMediaHandler | master | +14 -2 |
This particular file has contained ES6 arrow syntax since d05543b61253fe358e243f75d488d91c95113e06 (September 2021), so either it’s been broken for months without anyone noticing, or something else broke it.
Change 798995 had a related patch set uploaded (by TheDJ; author: TheDJ):
[mediawiki/extensions/TimedMediaHandler@master] Mark TMH modules as requiring ES6
Change 798995 merged by jenkins-bot:
[mediawiki/extensions/TimedMediaHandler@master] Mark TMH modules as requiring ES6
This was crashing all JS on pages that were loading this, so VE wouldn't load on any content page with media. Advanced search on Special:Search was also broken.