Page MenuHomePhabricator
Create Task
Maniphest T306925

Deprecations: QuickTemplate::(get/html/text/haveData) with parameters bottomscripts and headelement
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

Two errors here:

Error
normalized_message
[{reqId}] {exception_url}   PHP Deprecated: Use of QuickTemplate::(get/html/text/haveData) with parameter `bottomscripts` was deprecated in MediaWiki 1.39. [Called from QuickTemplate::get]
exception.trace
from /srv/mediawiki/php-1.39.0-wmf.9/includes/skins/QuickTemplate.php(144)
#0 [internal function]: MWExceptionHandler::handleError(integer, string, string, string, array)
#1 /srv/mediawiki/php-1.39.0-wmf.9/includes/debug/MWDebug.php(380): trigger_error(string, integer)
#2 /srv/mediawiki/php-1.39.0-wmf.9/includes/debug/MWDebug.php(353): MWDebug::sendRawDeprecated(string, boolean, string)
#3 /srv/mediawiki/php-1.39.0-wmf.9/includes/debug/MWDebug.php(232): MWDebug::deprecatedMsg(string, string, string, integer)
#4 /srv/mediawiki/php-1.39.0-wmf.9/includes/GlobalFunctions.php(769): MWDebug::deprecated(string, string, string, integer)
#5 /srv/mediawiki/php-1.39.0-wmf.9/includes/skins/QuickTemplate.php(130): wfDeprecated(string, string)
#6 /srv/mediawiki/php-1.39.0-wmf.9/includes/skins/QuickTemplate.php(144): QuickTemplate->checkDeprecationStatus(string)
#7 /srv/mediawiki/php-1.39.0-wmf.9/includes/skins/BaseTemplate.php(488): QuickTemplate->get(string)
#8 /srv/mediawiki/php-1.39.0-wmf.9/skins/WikimediaApiPortal/src/ComponentFactory.php(114): BaseTemplate->getTrail()
#9 /srv/mediawiki/php-1.39.0-wmf.9/skins/WikimediaApiPortal/src/WikimediaApiPortalTemplate.php(42): MediaWiki\Skin\WikimediaApiPortal\ComponentFactory->createMainComponent(MediaWiki\Skin\WikimediaApiPortal\WikimediaApiPortalTemplate)
#10 /srv/mediawiki/php-1.39.0-wmf.9/includes/skins/SkinTemplate.php(141): MediaWiki\Skin\WikimediaApiPortal\WikimediaApiPortalTemplate->execute()
#11 /srv/mediawiki/php-1.39.0-wmf.9/includes/skins/SkinTemplate.php(167): SkinTemplate->generateHTML()
#12 /srv/mediawiki/php-1.39.0-wmf.9/includes/OutputPage.php(2809): SkinTemplate->outputPage()
#13 /srv/mediawiki/php-1.39.0-wmf.9/includes/MediaWiki.php(926): OutputPage->output(boolean)
#14 /srv/mediawiki/php-1.39.0-wmf.9/includes/MediaWiki.php(939): MediaWiki::{closure}()
#15 /srv/mediawiki/php-1.39.0-wmf.9/includes/MediaWiki.php(566): MediaWiki->main()
#16 /srv/mediawiki/php-1.39.0-wmf.9/index.php(50): MediaWiki->run()
#17 /srv/mediawiki/php-1.39.0-wmf.9/index.php(46): wfIndexMain()
#18 /srv/mediawiki/w/index.php(3): require(string)
#19 {main}
Error
normalized_message
[{reqId}] {exception_url}   PHP Deprecated: Use of QuickTemplate::(get/html/text/haveData) with parameter `headelement` was deprecated in MediaWiki 1.39. [Called from QuickTemplate::get]
exception.trace
from /srv/mediawiki/php-1.39.0-wmf.9/includes/skins/QuickTemplate.php(144)
#0 [internal function]: MWExceptionHandler::handleError(integer, string, string, string, array)
#1 /srv/mediawiki/php-1.39.0-wmf.9/includes/debug/MWDebug.php(380): trigger_error(string, integer)
#2 /srv/mediawiki/php-1.39.0-wmf.9/includes/debug/MWDebug.php(353): MWDebug::sendRawDeprecated(string, boolean, string)
#3 /srv/mediawiki/php-1.39.0-wmf.9/includes/debug/MWDebug.php(232): MWDebug::deprecatedMsg(string, string, string, integer)
#4 /srv/mediawiki/php-1.39.0-wmf.9/includes/GlobalFunctions.php(769): MWDebug::deprecated(string, string, string, integer)
#5 /srv/mediawiki/php-1.39.0-wmf.9/includes/skins/QuickTemplate.php(130): wfDeprecated(string, string)
#6 /srv/mediawiki/php-1.39.0-wmf.9/includes/skins/QuickTemplate.php(144): QuickTemplate->checkDeprecationStatus(string)
#7 /srv/mediawiki/php-1.39.0-wmf.9/skins/WikimediaApiPortal/src/ComponentFactory.php(111): QuickTemplate->get(string)
#8 /srv/mediawiki/php-1.39.0-wmf.9/skins/WikimediaApiPortal/src/WikimediaApiPortalTemplate.php(42): MediaWiki\Skin\WikimediaApiPortal\ComponentFactory->createMainComponent(MediaWiki\Skin\WikimediaApiPortal\WikimediaApiPortalTemplate)
#9 /srv/mediawiki/php-1.39.0-wmf.9/includes/skins/SkinTemplate.php(141): MediaWiki\Skin\WikimediaApiPortal\WikimediaApiPortalTemplate->execute()
#10 /srv/mediawiki/php-1.39.0-wmf.9/includes/skins/SkinTemplate.php(167): SkinTemplate->generateHTML()
#11 /srv/mediawiki/php-1.39.0-wmf.9/includes/OutputPage.php(2809): SkinTemplate->outputPage()
#12 /srv/mediawiki/php-1.39.0-wmf.9/includes/MediaWiki.php(926): OutputPage->output(boolean)
#13 /srv/mediawiki/php-1.39.0-wmf.9/includes/MediaWiki.php(939): MediaWiki::{closure}()
#14 /srv/mediawiki/php-1.39.0-wmf.9/includes/MediaWiki.php(566): MediaWiki->main()
#15 /srv/mediawiki/php-1.39.0-wmf.9/index.php(50): MediaWiki->run()
#16 /srv/mediawiki/php-1.39.0-wmf.9/index.php(46): wfIndexMain()
#17 /srv/mediawiki/w/index.php(3): require(string)
#18 {main}
Impact

Mostly logspam, I expect.

Notes

These showed up immediately in 1.39.0-wmf.9 (T305215) after deployment to group0. Marking as blocker for next train, per policy.

Details

Request URL
https://api.wikimedia.org/w/index.php?title=*&returnto=*
Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
Fix warnings relating to QuickTemplateBrennen Bearnesmediawiki/skins/WikimediaApiPortalwmf/1.39.0-wmf.9+12 -24
Fix warnings relating to QuickTemplateJdlrobsonmediawiki/skins/WikimediaApiPortalmaster+12 -24
Customize query in gerrit

Related Objects

Event Timeline

brennen created this task.Apr 26 2022, 6:18 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 26 2022, 6:18 PM
brennen triaged this task as Unbreak Now! priority.Apr 26 2022, 6:20 PM
brennen mentioned this in T306926: PHP Deprecated: Use of BaseTemplate::getTrail was deprecated in MediaWiki 1.39. [Called from MediaWiki\Skin\WikimediaApiPortal\ComponentFactory::createMainComponent].
brennen added a parent task: T305216: 1.39.0-wmf.10 deployment blockers.
Mainframe98 added a project: WikimediaApiPortal.Apr 26 2022, 6:46 PM
Jdlrobson subscribed.Apr 26 2022, 9:43 PM

I hadn't realized this was still in production somewhere (the mediawiki.org page points to Github repo which threw me). I'll post a fix.

gerritbot added a comment.Apr 26 2022, 9:50 PM

Change 786397 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/WikimediaApiPortal@master] Fix warnings relating to QuickTemplate

https://gerrit.wikimedia.org/r/786397

gerritbot added a project: Patch-For-Review.Apr 26 2022, 9:50 PM
Jdlrobson added a comment.Apr 26 2022, 10:27 PM

Patch ready for review, but I will need a reviewer as I'm not 100% familiar with this codebase.

gerritbot added a comment.Apr 27 2022, 5:20 AM

Change 786397 merged by jenkins-bot:

[mediawiki/skins/WikimediaApiPortal@master] Fix warnings relating to QuickTemplate

https://gerrit.wikimedia.org/r/786397

Jdlrobson mentioned this in rMSWA5586ca74f7f6: Fix warnings relating to QuickTemplate.Apr 27 2022, 5:21 AM
Maintenance_bot removed a project: Patch-For-Review.Apr 27 2022, 5:30 AM
ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.10; 2022-05-02).Apr 27 2022, 6:01 AM
brennen added a comment.Apr 27 2022, 4:47 PM

@Jdlrobson thanks! Do you happen to also know about T306926: PHP Deprecated: Use of BaseTemplate::getTrail was deprecated in MediaWiki 1.39. [Called from MediaWiki\Skin\WikimediaApiPortal\ComponentFactory::createMainComponent]?

brennen added a comment.Apr 27 2022, 4:48 PM

(Maybe same fix catches that?)

Jdlrobson merged a task: T306926: PHP Deprecated: Use of BaseTemplate::getTrail was deprecated in MediaWiki 1.39. [Called from MediaWiki\Skin\WikimediaApiPortal\ComponentFactory::createMainComponent].Apr 27 2022, 4:52 PM

Yeh the fix should also handle that issue.

gerritbot added a comment.Apr 27 2022, 4:52 PM

Change 786420 had a related patch set uploaded (by Brennen Bearnes; author: Jdlrobson):

[mediawiki/skins/WikimediaApiPortal@wmf/1.39.0-wmf.9] Fix warnings relating to QuickTemplate

https://gerrit.wikimedia.org/r/786420

gerritbot added a project: Patch-For-Review.Apr 27 2022, 4:52 PM
gerritbot added a comment.Apr 27 2022, 6:05 PM

Change 786420 merged by jenkins-bot:

[mediawiki/skins/WikimediaApiPortal@wmf/1.39.0-wmf.9] Fix warnings relating to QuickTemplate

https://gerrit.wikimedia.org/r/786420

brennen mentioned this in rMSWA20c30881af52: Fix warnings relating to QuickTemplate.Apr 27 2022, 6:06 PM
Stashbot added a comment.Apr 27 2022, 6:11 PM

Mentioned in SAL (#wikimedia-operations) [2022-04-27T18:11:42Z] <brennen@deploy1002> Synchronized php-1.39.0-wmf.9/skins/WikimediaApiPortal: Backport: [[gerrit:786420|Fix warnings relating to QuickTemplate (T306925)]] (duration: 02m 26s)

Maintenance_bot removed a project: Patch-For-Review.Apr 27 2022, 6:30 PM
ReleaseTaggerBot edited projects, added: MW-1.39-notes (1.39.0-wmf.9; 2022-04-25); removed: MW-1.39-notes (1.39.0-wmf.10; 2022-05-02).Apr 27 2022, 7:00 PM
Ammarpad closed this task as Resolved.Apr 27 2022, 10:37 PM
Ammarpad claimed this task.
Ammarpad removed a parent task: T305216: 1.39.0-wmf.10 deployment blockers.
Krinkle moved this task from Untriaged to Apr 2022 on the Wikimedia-production-error board.May 9 2022, 5:53 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits