Commits like https://gerrit.wikimedia.org/r/c/operations/mediawiki-config/+/789613 shouldn't be so manual, and should get auto-crushed so that the SVGs aren't bloated. Can we extend logos/manage.py to handle these?
Description
Description
Details
Details
Customize query in gerrit
Related Objects
Related Objects
- Mentioned In
- T341412: CI on mediawiki-config should assert that the logos.php is generated by logos/manage.py
T320944: Taglline of German Wikipedia on vector-2022 broken
T320840: Vector 2022: Wrong tagline for other site displayed under logo
T320447: Run svgo for all SVG resources in operations/mediawiki-config
T317004: Missing logo for mniwiktionary and frwikiquote - Mentioned Here
- rOMWC7ce1a4818b4d: zhwiki: Update zh-hans version tagline and wordmark files
Event Timeline
Comment Actions
Good idea. So ideally wordmarks and taglines should be firstly uploaded to commons, then defined in some yaml file like logos/config.yaml. Patch uploader should run some script - possibly logos/manage.py to download them, adjust to proper size (tagline should have a height smaller than 50px, and the height of wordmark should smaller than 30px).
Comment Actions
Change 829298 had a related patch set uploaded (by Stang; author: Stang):
[operations/mediawiki-config@master] logos: Cover wordmark/tagline in manage.py
Comment Actions
Change 829561 had a related patch set uploaded (by Stang; author: Stang):
[operations/mediawiki-config@master] Replace wordmark/tagline with correct naming style
Comment Actions
Change 829563 had a related patch set uploaded (by Stang; author: Stang):
[operations/mediawiki-config@master] Move wmgSiteLogoWordmark and wmgSiteLogoTagline to logos.php
Comment Actions
Change 829760 had a related patch set uploaded (by Stang; author: Stang):
[operations/mediawiki-config@master] Re-download and optimize wordmark/tagline svg file
Comment Actions
Change 829764 had a related patch set uploaded (by Stang; author: Stang):
[operations/mediawiki-config@master] Drop unused wordmark/tagline
Comment Actions
Change 829298 merged by jenkins-bot:
[operations/mediawiki-config@master] logos: Cover wordmark/tagline in manage.py
Comment Actions
Change 829561 merged by jenkins-bot:
[operations/mediawiki-config@master] Replace wordmark/tagline with correct naming style
Comment Actions
Mentioned in SAL (#wikimedia-operations) [2022-10-12T09:21:21Z] <urbanecm@deploy1002> Started scap: Backport for [[gerrit:829561|Replace wordmark/tagline with correct naming style (T307705)]]
Comment Actions
Mentioned in SAL (#wikimedia-operations) [2022-10-12T09:21:44Z] <urbanecm@deploy1002> urbanecm and stang: Backport for [[gerrit:829561|Replace wordmark/tagline with correct naming style (T307705)]] synced to the testservers: mwdebug2002.codfw.wmnet, mwdebug1002.eqiad.wmnet, mwdebug2001.codfw.wmnet, mwdebug1001.eqiad.wmnet
Comment Actions
Mentioned in SAL (#wikimedia-operations) [2022-10-12T09:25:41Z] <urbanecm@deploy1002> Finished scap: Backport for [[gerrit:829561|Replace wordmark/tagline with correct naming style (T307705)]] (duration: 04m 20s)
Comment Actions
Thanks for your work on this @Stang. I merged the manage.py change (and the add-only patch of the SVG files). Can you please schedule the remaining patches for a B&C window? I can deploy them all by myself, but I'd appreciate help with checking the icons don't break.
Comment Actions
Also, I didn't want to block CR on this, but I think the logos/README.md should be updated more to reflect the newly-added feature. It should at least mention the newly-existing fields in config.yaml, and perhaps mention that running tox -e logos -- update xxwiki will take care of both logos. Can you have a look at this please @Stang?
Comment Actions
Change 829760 abandoned by Stang:
[operations/mediawiki-config@master] Re-download and optimize wordmark/tagline svg file
Reason:
already resolved
Comment Actions
Change 829563 merged by jenkins-bot:
[operations/mediawiki-config@master] Move wmgSiteLogoWordmark and wmgSiteLogoTagline to logos.php
Comment Actions
Mentioned in SAL (#wikimedia-operations) [2022-10-12T13:14:00Z] <urbanecm@deploy1002> Started scap: Backport for [[gerrit:829563|Move wmgSiteLogoWordmark and wmgSiteLogoTagline to logos.php (T307705)]]
Comment Actions
Mentioned in SAL (#wikimedia-operations) [2022-10-12T13:14:23Z] <urbanecm@deploy1002> urbanecm and stang: Backport for [[gerrit:829563|Move wmgSiteLogoWordmark and wmgSiteLogoTagline to logos.php (T307705)]] synced to the testservers: mwdebug1002.eqiad.wmnet, mwdebug2002.codfw.wmnet, mwdebug2001.codfw.wmnet, mwdebug1001.eqiad.wmnet
Comment Actions
Mentioned in SAL (#wikimedia-operations) [2022-10-12T13:21:07Z] <urbanecm@deploy1002> Finished scap: Backport for [[gerrit:829563|Move wmgSiteLogoWordmark and wmgSiteLogoTagline to logos.php (T307705)]] (duration: 07m 06s)
Comment Actions
Change 841942 had a related patch set uploaded (by Stang; author: Stang):
[operations/mediawiki-config@master] Re-download and optimize wordmark/tagline svg file
Comment Actions
Change 829764 merged by jenkins-bot:
[operations/mediawiki-config@master] Drop unused wordmark/tagline
Comment Actions
Change 841942 merged by jenkins-bot:
[operations/mediawiki-config@master] Re-download and optimize wordmark/tagline svg file
Comment Actions
Mentioned in SAL (#wikimedia-operations) [2022-10-12T20:16:34Z] <samtar@deploy1002> Started scap: Backport for [[gerrit:829764|Drop unused wordmark/tagline (T307705)]], [[gerrit:841942|Re-download and optimize wordmark/tagline svg file (T307705)]]
Comment Actions
Mentioned in SAL (#wikimedia-operations) [2022-10-12T20:16:57Z] <samtar@deploy1002> samtar and stang: Backport for [[gerrit:829764|Drop unused wordmark/tagline (T307705)]], [[gerrit:841942|Re-download and optimize wordmark/tagline svg file (T307705)]] synced to the testservers: mwdebug1001.eqiad.wmnet, mwdebug2001.codfw.wmnet, mwdebug2002.codfw.wmnet, mwdebug1002.eqiad.wmnet
Comment Actions
Mentioned in SAL (#wikimedia-operations) [2022-10-12T20:21:27Z] <samtar@deploy1002> Finished scap: Backport for [[gerrit:829764|Drop unused wordmark/tagline (T307705)]], [[gerrit:841942|Re-download and optimize wordmark/tagline svg file (T307705)]] (duration: 04m 53s)
Comment Actions
Change 842010 had a related patch set uploaded (by Stang; author: Stang):
[operations/mediawiki-config@master] logos: Document how to update wordmark/tagline via manage.py
Comment Actions
Change 842010 merged by jenkins-bot:
[operations/mediawiki-config@master] logos: Document how to update wordmark/tagline via manage.py
Comment Actions
Change 842923 had a related patch set uploaded (by Stang; author: Stang):
[operations/mediawiki-config@master] logos: Fix bugs when a variant param is specific
Comment Actions
Change 842923 merged by jenkins-bot:
[operations/mediawiki-config@master] logos: Fix bug when a variant param is specific
Comment Actions
Change 843484 had a related patch set uploaded (by Stang; author: Stang):
[operations/mediawiki-config@master] logos: Set a higher precision for scour
Comment Actions
Change 843484 merged by jenkins-bot:
[operations/mediawiki-config@master] logos: Set a higher precision for scour
Comment Actions
Change 857030 had a related patch set uploaded (by Stang; author: Stang):
[operations/mediawiki-config@master] logos: Remove duplicated code
Comment Actions
Change 857030 merged by jenkins-bot:
[operations/mediawiki-config@master] logos: Remove duplicated code
Comment Actions
Mentioned in SAL (#wikimedia-operations) [2022-11-15T21:14:40Z] <cjming@deploy1002> Started scap: Backport for [[gerrit:857030|logos: Remove duplicated code (T307705)]]
Comment Actions
Mentioned in SAL (#wikimedia-operations) [2022-11-15T21:15:04Z] <cjming@deploy1002> cjming and stang: Backport for [[gerrit:857030|logos: Remove duplicated code (T307705)]] synced to the testservers: mwdebug1001.eqiad.wmnet, mwdebug1002.eqiad.wmnet, mwdebug2001.codfw.wmnet, mwdebug2002.codfw.wmnet
Comment Actions
Mentioned in SAL (#wikimedia-operations) [2022-11-15T21:19:11Z] <cjming@deploy1002> Finished scap: Backport for [[gerrit:857030|logos: Remove duplicated code (T307705)]] (duration: 04m 31s)