Page MenuHomePhabricator
Create Task
Maniphest T307780

History state manipulation is triggering erros in the frontend
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

There are a few different, but correlated, errors in logstash that highlight an issue with History state manipulation in VUejs.

The errors triggered are:

  • Failed to execute 'replaceState' on 'History': [object Array] could not be cloned.
at S.replaceQueryToHistoryState  https://commons.m.wikimedia.org/w/load.php?lang=en&modules=jquery%2Cmediasearch%2Cvue&skin=minerva&version=1waqn:241:604
at Array.<anonymous>  <anonymous>:197:706
at S.dispatch  <anonymous>:205:498
at S.dispatch  <anonymous>:204:470
at Proxy.T.forEach.n.<computed>  <anonymous>:208:115
at Proxy.mounted  https://commons.m.wikimedia.org/w/load.php?lang=en&modules=jquery%2Cmediasearch%2Cvue&skin=minerva&version=1waqn:247:347
at Ft  https://commons.m.wikimedia.org/w/load.php?lang=en&modules=jquery%2Cmediasearch%2Cvue&skin=minerva&version=1waqn:275:584
at Vt  https://commons.m.wikimedia.org/w/load.php?lang=en&modules=jquery%2Cmediasearch%2Cvue&skin=minerva&version=1waqn:275:662
at Array.Eo.t.__weh.t.__weh  https://commons.m.wikimedia.org/w/load.php?lang=en&modules=jquery%2Cmediasearch%2Cvue&skin=minerva&version=1waqn:294:77
at sn  https://commons.m.wikimedia.org/w/load.php?lang=en&modules=jquery%2Cmediasearch%2Cvue&skin=minerva&version=1waqn:276:977
  • Failed to execute 'pushState' on 'History': [object Array] could not be cloned.
at S.pushQueryToHistoryState  https://commons.m.wikimedia.org/w/load.php?lang=en&modules=%40vue%2Fcomposition-api%2Cjquery%2Cmediasearch%2Cvue%2Cvuex&skin=minerva&version=1ejun:241:411
at Array.<anonymous>  https://commons.m.wikimedia.org/w/load.php?lang=en&modules=%40vue%2Fcomposition-api%2Cjquery%2Cmediasearch%2Cvue%2Cvuex&skin=minerva&version=1ejun:409:706
at S.dispatch  https://commons.m.wikimedia.org/w/load.php?lang=en&modules=%40vue%2Fcomposition-api%2Cjquery%2Cmediasearch%2Cvue%2Cvuex&skin=minerva&version=1ejun:417:498
at S.dispatch  https://commons.m.wikimedia.org/w/load.php?lang=en&modules=%40vue%2Fcomposition-api%2Cjquery%2Cmediasearch%2Cvue%2Cvuex&skin=minerva&version=1ejun:416:470
at Proxy.T.forEach.n.<computed>  https://commons.m.wikimedia.org/w/load.php?lang=en&modules=%40vue%2Fcomposition-api%2Cjquery%2Cmediasearch%2Cvue%2Cvuex&skin=minerva&version=1ejun:420:115
at Proxy.onUpdateTerm  https://commons.m.wikimedia.org/w/load.php?lang=en&modules=%40vue%2Fcomposition-api%2Cjquery%2Cmediasearch%2Cvue%2Cvuex&skin=minerva&version=1ejun:192:206
Impact
  • The user will not be able to "reload" history by going backward on his browser
Notes
  • This seems to be happening just on Iphones.
Error

Details

SubjectRepoBranchLines +/-
Fix - History state manipulation is triggering erros in the frontendmediawiki/extensions/MediaSearchmaster+6 -4
Customize query in gerrit

Related Objects
Search...

Event Timeline

SimoneThisDot created this task.May 6 2022, 12:35 PM
Restricted Application added subscribers: Masumrezarock100, Aklapper. · View Herald TranscriptMay 6 2022, 12:35 PM
CBogen edited projects, added Structured-Data-Backlog, SDAW-MediaSearch; removed Structured-Data-Backlog (Current Work).May 7 2022, 9:33 PM
CBogen edited projects, added Structured-Data-Backlog (Current Work); removed Structured-Data-Backlog.May 9 2022, 4:29 PM
CBogen moved this task from Incoming to Ready for Estimation on the Structured-Data-Backlog (Current Work) board.
MarkThisDot claimed this task.May 10 2022, 9:14 AM
Seddon moved this task from Ready for Estimation to Doing on the Structured-Data-Backlog (Current Work) board.May 10 2022, 9:22 AM
gerritbot added a comment.May 11 2022, 4:27 PM

Change 791054 had a related patch set uploaded (by MarkThisDot; author: MarkThisDot):

[mediawiki/extensions/MediaSearch@master] Fix - History state manipulation is triggering erros in the frontend

https://gerrit.wikimedia.org/r/791054

gerritbot added a project: Patch-For-Review.May 11 2022, 4:27 PM
MarkThisDot moved this task from Doing to Code Review on the Structured-Data-Backlog (Current Work) board.May 13 2022, 3:43 PM
gerritbot added a comment.May 23 2022, 12:16 PM

Change 791054 merged by jenkins-bot:

[mediawiki/extensions/MediaSearch@master] Fix - History state manipulation is triggering erros in the frontend

https://gerrit.wikimedia.org/r/791054

Maintenance_bot removed a project: Patch-For-Review.May 23 2022, 12:30 PM
ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.13; 2022-05-23).May 23 2022, 1:00 PM
Seddon moved this task from Code Review to Needs QA on the Structured-Data-Backlog (Current Work) board.May 23 2022, 1:11 PM
Seddon added a subtask: T308508: MediaSearch: Failed to execute 'replaceState' on 'History': [object Array] could not be cloned..May 24 2022, 3:28 PM
Seddon closed subtask T308508: MediaSearch: Failed to execute 'replaceState' on 'History': [object Array] could not be cloned. as Declined.
Seddon mentioned this in T308508: MediaSearch: Failed to execute 'replaceState' on 'History': [object Array] could not be cloned..
Aklapper merged a task: T308508: MediaSearch: Failed to execute 'replaceState' on 'History': [object Array] could not be cloned..May 24 2022, 3:48 PM
Aklapper added subscribers: Jdlrobson, Seddon, MarkThisDot.
Jdlrobson updated the task description. (Show Details)May 24 2022, 5:00 PM
Jdlrobson added a project: Wikimedia-production-error.May 24 2022, 5:54 PM
Etonkovidova moved this task from Needs QA to Verify on Production on the Structured-Data-Backlog (Current Work) board.May 24 2022, 6:51 PM
Etonkovidova subscribed.May 25 2022, 9:34 PM

Testing note - check this link: https://logstash.wikimedia.org/goto/c6797aa5c6f962e95ca5547a697f0c43

Krinkle moved this task from Untriaged to May 2022 on the Wikimedia-production-error board.May 30 2022, 8:41 PM
Etonkovidova closed this task as Resolved.May 31 2022, 3:47 PM
In T307780#7958428, @Etonkovidova wrote:

Testing note - check this link: https://logstash.wikimedia.org/goto/c6797aa5c6f962e95ca5547a697f0c43

The last timestamp for the error - May 25, 2022 @ 17:56:02.339.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL