Suggested edits: followup changes to refactor
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	• mewoph
	May 9 2022, 8:12 PM

Description

With T303985: Suggested edits: make task feed reusable, the non-UI logic for the task queue is abstracted into ext.growthExperiments.DataStore module in order to show the full task feed in the post-edit dialog. This task tracks related changes that are not necessarily required for the post-edit dialog changes.

Changes required

ext.growthExperiments.Homepage.mobile There are a few FIXMEs in this module to move suggested edits-related logic (to update the mobile summary view when the task feed changes in the overlay). With the refactor, this can be moved. ext.growthExperiments.Homepage.SuggestedEdits should no longer have to require ext.growthExperiments.Homepage.mobile in order to update the mobile summary view.

Instead of each of the following modules requiring a set of virtual files in order to use TaskTypesAbFilter, the module should instead include ext.growthExperiments.DataStore and get the task-related data from constants.
- ext.growthExperiments.HelpPanel
- ext.growthExperiments.Help
- ext.growthExperiments.StructuredTask.PreEdit

Acceptance criteria

No functional changes
No instrumentation changes

Details

Subject	Repo	Branch	Lines +/-
Include ext.growthExperiments.DataStore as a dependency of ext.growthExperiments.Help	mediawiki/extensions/GrowthExperiments	master	+2 -1
Change how suggested edits is set up in ext.growthExperiments.Homepage.mobile	mediawiki/extensions/GrowthExperiments	master	+565 -449
Use constants from ext.growthExperiments.DataStore instead of requiring virtual files directly	mediawiki/extensions/GrowthExperiments	master	+29 -72

Customize query in gerrit

Related Objects

Mentioned In: T316947: FlaggedRevisions incorrectly displays table of contents on Vector 2022 for flagged pages
Mentioned Here: T305543: Verify Growth editing workflows on mobile
T303985: Suggested edits: make task feed reusable

Event Timeline

• mewoph created this task.May 9 2022, 8:12 PM

Restricted Application added a project: Growth-Team. · View Herald TranscriptMay 9 2022, 8:12 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

• mewoph updated the task description. (Show Details)May 9 2022, 8:12 PM

• mewoph edited projects, added Growth-Team (Sprint 0 (Growth Team)); removed Growth-Team.

• mewoph moved this task from Incoming to In Progress on the Growth-Team (Sprint 0 (Growth Team)) board.

• mewoph updated the task description. (Show Details)

Change 790423 had a related patch set uploaded (by MewOphaswongse; author: MewOphaswongse):

[mediawiki/extensions/GrowthExperiments@master] Change how suggested edits is set up in ext.growthExperiments.Homepage.mobile

https://gerrit.wikimedia.org/r/790423

gerritbot added a project: Patch-For-Review.May 9 2022, 9:31 PM

@mewoph does this also relate to T305543: Verify Growth editing workflows on mobile?

Hi @kostajh, no this is the changes that were separated from the initial refactor since they are not directly required by the post-edit dialog changes. It mostly impacts pre-edit flows.

Change 791079 had a related patch set uploaded (by MewOphaswongse; author: MewOphaswongse):

[mediawiki/extensions/GrowthExperiments@master] Use constants from ext.growthExperiments.DataStore instead of requiring virtual files directly

https://gerrit.wikimedia.org/r/791079

• mewoph moved this task from In Progress to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.May 11 2022, 9:21 PM

kostajh triaged this task as Medium priority.May 12 2022, 8:57 AM

Change 791079 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Use constants from ext.growthExperiments.DataStore instead of requiring virtual files directly

https://gerrit.wikimedia.org/r/791079

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.12; 2022-05-16).May 12 2022, 7:01 PM

kostajh moved this task from Code Review to QA on the Growth-Team (Sprint 0 (Growth Team)) board.May 13 2022, 1:14 PM

Change 790423 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Change how suggested edits is set up in ext.growthExperiments.Homepage.mobile

https://gerrit.wikimedia.org/r/790423

Maintenance_bot removed a project: Patch-For-Review.May 13 2022, 2:30 PM

Change 791653 had a related patch set uploaded (by MewOphaswongse; author: MewOphaswongse):

[mediawiki/extensions/GrowthExperiments@master] Include ext.growthExperiments.DataStore as a depdency of ext.growthExperiments.Help

https://gerrit.wikimedia.org/r/791653

gerritbot added a project: Patch-For-Review.May 13 2022, 6:29 PM

Change 791653 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Include ext.growthExperiments.DataStore as a dependency of ext.growthExperiments.Help