Page MenuHomePhabricator

Admins & Reviewers can't review revision
Closed, ResolvedPublic2 Estimated Story PointsBUG REPORT

Description

Hello, I'm WillsonEP09 from idwiki.
Through this message I want to convey the problem that occurred. Admins & Reviewers can't review revision right now.

When you want to review the following message always appears.

Screenshot_2022-05-10-07-37-13-11_40deb401b9ffe8e1df2f1cc5ba480b12.jpg (2×1 px, 327 KB)

https://id.m.wikipedia.org/w/index.php?title=Istimewa:Tinjauan_revisi&action=submit

Event Timeline

Tacsipacsi triaged this task as Unbreak Now! priority.May 10 2022, 11:26 AM
Tacsipacsi added a subscriber: Tacsipacsi.

Was able to reproduce locally, with the following settings:

$wgFlaggedRevsProtection = true;
$wgFlaggedRevsTags = [
        'accuracy' => [ 'levels' => 2, 'quality' => 20, 'pristine' => 21 ],
];

If I change $wgFlaggedRevsTags['accuracy']['levels'] to 1, it works. It looks like protection mode with non-binary flagging isn’t supported.

The question to @WillsonEP09 is: do you need two levels (Terperiksa and Akurat)? If not, the second level (Akurat) can be simply disabled (as is the case in all other wikis with protection mode). This can be done within a couple of hours, at most a few days after you gained on-wiki consensus for disabling the second level (see Requesting wiki configuration changes). If it’s needed, the bug needs to be fixed, which can take anything from a few hours to weeks (or even more). My personal opinion is that multiple levels make little sense in protection mode, since the protection mode’s purpose is to hide changes to certain pages until they’re approved, and whether they’re visible is inherently a binary thing.


Since (as far as I understand) this bug makes it impossible to manually review pages on idwiki, I think this qualifies as UBN.

I haven't done much on FR recently but @awight and @thiemowmde did some work. Maybe they can double check if it's caused by them or not.

Change 790691 had a related patch set uploaded (by Awight; author: Awight):

[mediawiki/extensions/FlaggedRevs@master] Test more level names for getLevels

https://gerrit.wikimedia.org/r/790691

Change 790691 merged by jenkins-bot:

[mediawiki/extensions/FlaggedRevs@master] Test more level names for getLevels

https://gerrit.wikimedia.org/r/790691

Change 790702 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/FlaggedRevs@master] Fix incomplete FlaggedRevs::binaryFlagging() implementation

https://gerrit.wikimedia.org/r/790702

thiemowmde set the point value for this task to 2.

Change 790436 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/FlaggedRevs@wmf/1.39.0-wmf.10] Fix incomplete FlaggedRevs::binaryFlagging() implementation

https://gerrit.wikimedia.org/r/790436

Change 790437 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/FlaggedRevs@wmf/1.39.0-wmf.11] Fix incomplete FlaggedRevs::binaryFlagging() implementation

https://gerrit.wikimedia.org/r/790437

Change 790702 merged by jenkins-bot:

[mediawiki/extensions/FlaggedRevs@master] Fix incomplete FlaggedRevs::binaryFlagging() implementation

https://gerrit.wikimedia.org/r/790702

Fix scheduled for deployment in a few hours. Thank you for the bug report!

Change 790437 abandoned by Awight:

[mediawiki/extensions/FlaggedRevs@wmf/1.39.0-wmf.11] Fix incomplete FlaggedRevs::binaryFlagging() implementation

Reason:

Good suggestion! I was going to leave it here just in case something strange happens like wmf.11 is deployed next week, but I'm certain that won't happen, and the chance of forgetting is high.

https://gerrit.wikimedia.org/r/790437

Change 790436 merged by jenkins-bot:

[mediawiki/extensions/FlaggedRevs@wmf/1.39.0-wmf.10] Fix incomplete FlaggedRevs::binaryFlagging() implementation

https://gerrit.wikimedia.org/r/790436

Mentioned in SAL (#wikimedia-operations) [2022-05-11T13:11:28Z] <awight@deploy1002> Synchronized php-1.39.0-wmf.10/extensions/FlaggedRevs/backend/FlaggedRevs.php: Backport: [[gerrit:790436|Fix incomplete FlaggedRevs::binaryFlagging() implementation (T307972)]] (duration: 00m 51s)

The fix has been deployed, please let us know if there are still issues.

Thanks for help. Problem solved. 😊