Page MenuHomePhabricator

[S] Update order of message that show up when no results are found
Closed, ResolvedPublic

Description

This ticket is to adjust the styling of the message as shown in the image below. This message shows up when no search results are found. When the article does not exist but there are search results to show then a similar message appears on the side of the screen as shown in this ticket.

Current implementation

no results found.png (1×2 px, 168 KB)

Proposed adjustments
Desktop specs

Special_Search (2).png (800×1 px, 37 KB)

Mobile specs
Special_Search (3).png (800×360 px, 18 KB)

Acceptance Criteria

  • Spacing and padding update
  • Font size adjustments
  • Switch the position of the sentences i.e. the second sentence goes above the first. (Is that change in order possible or is it driven by community?)

Event Timeline

@Seddon Let me know if all these scenarios can be handled in one ticket or needs to be separated out.

Sneha renamed this task from Handling of various Special:Search Results Page Scenarios from a design point of view. to Update styling of message that show up when no results are found.May 27 2022, 9:07 PM
Sneha added a project: CSS.
Sneha updated the task description. (Show Details)

Noting that development can begin, but nothing should be merged until we've had the chance to get feedback from the communities (in progress).

CBogen renamed this task from Update styling of message that show up when no results are found to [S] Update styling of message that show up when no results are found.Jun 1 2022, 4:26 PM

Change 803968 had a related patch set uploaded (by MarkThisDot; author: MarkThisDot):

[mediawiki/core@master] Update styling of message that show up when no results are found

https://gerrit.wikimedia.org/r/803968

MarkThisDot subscribed.

Completed and handover to Simone

Seddon renamed this task from [S] Update styling of message that show up when no results are found to [S] Update order of message that show up when no results are found.Jul 22 2022, 12:26 PM

Test wiki on Patch demo by Seddon using patch(es) linked to this task was deleted:

https://patchdemo.wmflabs.org/wikis/ed8233826e/w/

Change 803968 merged by jenkins-bot:

[mediawiki/core@master] Update styling of message that show up when no results are found

https://gerrit.wikimedia.org/r/803968

Etonkovidova subscribed.

@Sneha - all looks according to the specs (https://gerrit.wikimedia.org/r/c/mediawiki/core/+/803968/7/resources/src/mediawiki.special.search.styles.less)

.mw-body .mw-search-nonefound {
	margin: 1.5em 0 0.5em 0;
	font-size: 1.2em;
}
betalabscurrent production wmf.23
Desktop:
Screen Shot 2022-08-11 at 3.43.37 PM.png (575×1 px, 96 KB)
Mobile:
IMG_1870.PNG (1×640 px, 97 KB)
Desktop:
Screen Shot 2022-08-11 at 3.43.16 PM.png (1×3 px, 267 KB)
Mobile:
IMG_1871.PNG (1×640 px, 110 KB)

QA Notes:

  • it seems that mobile does not display any additional messages (e.g. "The page [title] doesn't exist. You can ask for it to be created [...}") along with "There were no results matching the query."
  • since the message (and any additional messages) vary significantly from wiki to wiki, the order of messages should be checked in production.

@Etonkovidova This looks good to me. The additional message is not supposed to be on mobile so its all good. We can consider it done.

@Etonkovidova This looks good to me. The additional message is not supposed to be on mobile so its all good. We can consider it done.

Thanks, @Sneha! Checked on arwiki, enwiki, and ruwiki - all looks as expected.

@Etonkovidova Hey Elena looks like I got confused earlier when I said that the "The additional message is not supposed to be on mobile." It is not there on mobile when the results are found which is expected but this story is about when no results are found and hence that additional message should be there. Sorry for getting confused earlier. Since this story is now closed should I create a new one for this? @CBogen

However, adding that message is not directly helping our search goals right now in helping users find information. It was a nice to have in encouraging users to edit when nothing is found (which may eventually help users find the right info) . So I am okay if we did it in later milestones.

@Etonkovidova Hey Elena looks like I got confused earlier when I said that the "The additional message is not supposed to be on mobile." It is not there on mobile when the results are found which is expected but this story is about when no results are found and hence that additional message should be there. Sorry for getting confused earlier. Since this story is now closed should I create a new one for this? @CBogen

However, adding that message is not directly helping our search goals right now in helping users find information. It was a nice to have in encouraging users to edit when nothing is found (which may eventually help users find the right info) . So I am okay if we did it in later milestones.

@Sneha Given our timelines, it would be great if you could create a new story for it and then I'll put it right in the backlog instead of in Current Work to consider at a later time.

Test wiki on Patch demo by Seddon using patch(es) linked to this task was deleted:

https://patchdemo.wmflabs.org/wikis/f5ef4b32d2/w/