Page MenuHomePhabricator
Create Task
Maniphest T30905

User agent strings (for UIWebView and NSURLConnection requests) need to be updated
Closed, ResolvedPublic
Actions

Description

Author: benrimmington

Description:
The project contains four UIWebView requests with a custom HTTP header field.

... setValue:@"Wikipedia Mobile/2.0" forHTTPHeaderField:@"User_Agent"];

UIWebView's default "User-Agent" field should be enough (see Bug 28884). Otherwise, the "Wikipedia Mobile/2.0" value contains an invalid space character, and an out-of-date version number.

There's also an action=opensearch request (using NSURLConnection) without a custom "User-Agent" value. Is the default value suitable?

Should the code for creating requests be refactored into a category of NSMutableURLRequest?

Version: 1.0.0 (Android)
Severity: trivial
OS: other
Platform: Other

Details

Reference
bz28905

Related Objects
Search...

StatusSubtypeAssignedTask
 ResolvedNoneT30905 User agent strings (for UIWebView and NSURLConnection requests) need to be updated
 ResolvedNoneT35673 Wikipedia Android app (iOS) PhoneGap app 1.0 release (tracking)
 ResolvedNoneT33571 Link to external site opens in app
 ResolvedyuvipandaT35674 Remove 'urlcache' PhoneGap plugin from Android app, do caching ourselves
 Resolved• brionT35675 Use ShareKit to implement service sharing of links in iOS PhoneGap app
 ResolvedNoneT35778 PhoneGap-based iOS app menus don't disable when things are disabled
 ResolvedNoneT35776 PhoneGap-based iOS app is missing 'About'
 ResolvedNoneT35794 PhoneGap-based iOS app awkward scrolling in search results while keyboard is shown
 ResolvedNoneT35793 PhoneGap-based iOS app needs updated startup splash images
 ResolvedNoneT35799 PhoneGap-based iOS app scrolling/toolbars messed up on iOS 4.3
 ResolvedNoneT33969 Add 'mail this page' to sharing options on iPhone app
 ResolvedNoneT33570 iPhone app + button offers only bookmark, no copy link / open in browser options
 ResolvedNoneT33974 Rebuild iOS/iPhone app using the PhoneGap shared base
 ResolvedNoneT33973 Refactor Android PhoneGap app so most of the code is platform-independent
 ResolvedNoneT35797 PhoneGap-based iOS app selecting article in 'nearby' doesn't dismiss map view
 Resolved• TfincT35798 PhoneGap-based app 'read page in' doesn't hide article view on small screen (iOS, Android) - regression
 ResolvedNoneT35795 PhoneGap-based iOS app 'history' view header scrolls oddly on iPad
 Resolved• TfincT35800 PhoneGap-based apps 'about' page should include info on 3rd-party libraries
 ResolvedNoneT35803 PhoneGap-based iOS app HTML map is hardcoded to search english
 Resolved• brionT35852 iOS, Android 3/4 scrolling doesn't return article to top when navigating
 DeclinedNoneT35870 PhoneGap-based iOS app: intermittent article scrolling freezes
 ResolvedNoneT35869 PhoneGap-based iOS app map OSM/Leaflet label overlaps toolbar
 ResolvedNoneT34068 PhoneGap-based iOS app needs non-Android menu
 ResolvedNoneT35969 PhoneGap-based iOS app ShareKit "more" button shows empty list instead of all options
 ResolvedNoneT35968 PhoneGap-based iOS app needs API key for Facebook sharing?
 ResolvedNoneT34613 PhoneGap-based iOS app doesn't open external links
 ResolvedNoneT34614 PhoneGap-based iOS app bumps search toolbar to center of screen when keyboarding in if page is scrolled

Event Timeline

• bzimport raised the priority of this task from to Medium.Nov 21 2014, 11:26 PM
• bzimport added a project: Wikipedia-App-Generic.
• bzimport set Reference to bz28905.
• bzimport added a subscriber: Unknown Object (MLST).
• bzimport created this task.May 10 2011, 1:27 AM
• bzimport added a comment.May 10 2011, 1:53 AM

benrimmington wrote:

+[NSMutableURLRequest(Wikipedia) wikipedia_requestWithURL:] method.

Attached:

NSMutableURLRequest_Wikipedia.txt553 BDownload

Bawolff added a comment.May 31 2011, 3:19 AM

This ain't an in browser XHR request, bug 28884 doesn't apply here - the app should have its own user-agent. It should not use the underlying library's User-Agent.

Putting a User_agent header isn't illegal (Well i guess if you get technical non-standardized headers should start with x-) its just rather pointless.

• bzimport added a comment.May 31 2011, 10:30 AM

benrimmington wrote:

(In reply to comment #2)

This ain't an in browser XHR request, bug 28884 doesn't apply here - the app
should have its own user-agent. It should not use the underlying library's
User-Agent.

RootViewController and WikiViewController are using UIWebView to load requests, so the policy for browser-based applications should apply.

RootViewController is also using NSURLConnection to request action=opensearch results, but the default User-Agent might be sufficient:

http://stackoverflow.com/questions/1532206/changing-the-useragent-of-nsurlconnection

(I'm not sure how to verify that the app name and version are included by default).

Putting a User_agent header isn't illegal (Well i guess if you get technical
non-standardized headers should start with x-) its just rather pointless.

The main issue with the User_Agent strings is the hard-coded version number (it's using "Wikipedia Mobile/2.0", but the current CFBundleVersion is 2.1).

• Tfinc added a comment.Feb 27 2012, 11:50 PM

This has now been fixed with the new PhoneGap build.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL