Page MenuHomePhabricator
Create Task
Maniphest T33973

Refactor Android PhoneGap app so most of the code is platform-independent
Closed, ResolvedPublic
Actions

Description

Current code mixes generic HTML / PhoneGap stuff with Android-specific things (use of android-specific plugins like the menus and sharing, etc).

Should refactor it out so we can import the common code into the Android project and also into the iPhone project without having to manually synchronize multiple code trees as much.

Version: 1.0.0 (Android)
Severity: normal

Details

Reference
bz31973

Related Objects
Search...

StatusSubtypeAssignedTask
 ResolvedNoneT33575 iPhone app history dates obscured by titles
 InvalidNoneT33508 Wikipedia App crashes when expanding multiple sections on iOS 4.2.1
 ResolvedNoneT33573 iPhone app allows dupe bookmarks
 ResolvedNoneT33572 iPhone app view through location leaves you in weird ui state
 InvalidNoneT33574 iPhone app bookmarks not searchable or sortable
 ResolvedNoneT30905 User agent strings (for UIWebView and NSURLConnection requests) need to be updated
 InvalidNoneT35490 App hangs on incoming text messages during page load
 ResolvedNoneT35709 History list, when cleared, re-appears when app is re-opened
 ResolvedNoneT34778 Iphone app should clear input text when user starts typing
 InvalidNoneT36364 Application crashing on launch
 ResolvedNoneT35667 iPhone app: Search results flash quickly, then disappear on each keypress if no network
 DeclinedNoneT35796 PhoneGap-based iOS app 'history' view doesn't update when navigating while it's open
 ResolvedNoneT35673 Wikipedia Android app (iOS) PhoneGap app 1.0 release (tracking)
 ResolvedNoneT33969 Add 'mail this page' to sharing options on iPhone app
 DeclinedNoneT33968 Support external screen in iPhone/iPad app
 DeclinedNoneT33967 Support printing on iOS 4.2 and above (AirPrint - iPad, iPhone)
 ResolvedNoneT33970 Support native 'Tweet' sharing in iOS 5, non-native on older?
 ResolvedNoneT33974 Rebuild iOS/iPhone app using the PhoneGap shared base
 Declined• TfincT33981 Chrome Web App with offline support
 Resolved• TfincT33980 Refactor PhoneGap app so it can be run in browser and ported to other HTML/JS app stacks
 DeclinedNoneT33976 Blackberry port of PhoneGap app
 Declined• brionT33975 Windows Phone 7 port of PhoneGap app
 DeclinedNoneT33977 WebOS port of PhoneGap app
 ResolvedNoneT33973 Refactor Android PhoneGap app so most of the code is platform-independent

Event Timeline

• bzimport raised the priority of this task from to High.Nov 21 2014, 11:56 PM
• bzimport added a project: Wikipedia-App-Generic.
• bzimport set Reference to bz31973.
• bzimport added a subscriber: Unknown Object (MLST).
• brion created this task.Oct 27 2011, 1:04 AM
• brion added a comment.Oct 30 2011, 11:03 PM

Pull request with work in progress:

https://github.com/nitobi/Wikipedia/pull/48

This checks whether we're running on Android or iOS and loads up the appropriate phonegap-1.1.0.js and any needed plugin interface stubs. Some of the files under js/ are split into eg js/android/ and js/ios/.

Initial iOS build stuff also included (for bug 31974) though it's not quite working right.

• brion added a comment.Oct 30 2011, 11:20 PM

Has been merged as of 05e8d9d57598f4ddfd180f8d9740fe3b7f9e9d88

Still need to break out some Android-specific assumptions and code into platform-specific modules.

• brion added a comment.Oct 31 2011, 2:00 AM

Done a bit further as of:

https://github.com/nitobi/Wikipedia/commit/8c9753968321723e9074cbfbc2d99115c6016d18

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL