In a code review comment on https://gerrit.wikimedia.org/r/c/design/codex/+/793586 , @Sarai-WMDE wrote:
We've been discussing component architecture internally, and so far it would appear that IconOnly could be a variant of the button component (due to the need for it to include specific accessibility attributes), therefore my suggestion. I agree it's a good idea to wait, since now I understand that the proposal wouldn't reflect reality (yet?).
If we want to move ahead with displaying a selection of demos, may I suggest the following instead?
- Default normal
- Progressive primary
- Destructive quiet
- Default normal, disabled
- Quiet, disabled
- Default normal, with icon
- Default quiet, with icon
- Default normal, icon only
- Default quiet, icon only
So we 1.display all types and actions at the beginning, 2.feature how the appearance of disabled quiet buttons is different from that of the other types, 3. then (no changes here) display the with icon and icon only versions. Hope this sounds good!
We should figure out which demos we want to show on the Button demo page, then implement that decision.
Currently, with https://gerrit.wikimedia.org/r/c/design/codex/+/793586 having been merged, we show the following demos:
- Default
- Progressive
- Destructive, primary
- Destructive, primary, disabled
- Quiet
- Default, with icon
- Default, quiet, with icon
- Default, icon only
- Quiet, icon only
As @DannyS712 pointed out in that same Gerrit discussion, you can already make all possible buttons using the configurable demo, but 1) that's not super obvious (especially for the ones with icons), and 2) on other component demo pages, we generally show a variety of examples even if you could theoretically get them by entering the right settings into the configurable demo.