Page MenuHomePhabricator

Auto-expand behavior is causing input text to shift
Closed, ResolvedPublicBUG REPORT

Description

List of steps to reproduce (step by step, including full links if applicable):

What happens?:
The placeholder text will shift to the right when you're focused on the input, then back to the left when the input loses focus

What should have happened instead?:
The input text should always be in the same place. Only the padding-left and margin-left of the input, plus the placement of the start icon, should shift.

Software version (if not a Wikimedia wiki), browser information, screenshots, other information, etc.: Main branch of Codex. This was introduced when some changes were made to input icon spacing recently.

Event Timeline

Change 802196 had a related patch set uploaded (by Anne Tomasevich; author: Anne Tomasevich):

[design/codex@main] TypeaheadSearch, styles: Fix auto-expand distance

https://gerrit.wikimedia.org/r/802196

Change 802196 merged by jenkins-bot:

[design/codex@main] TypeaheadSearch, styles: Fix auto-expand distance

https://gerrit.wikimedia.org/r/802196

Testing:

Hi @AnneT
This works on Chrome and Firefox but the text displacement still happens on Safari.

Thanks for reviewing this, @EUdoh-WMF!

Which version of Safari are you using? I'm not seeing the text displacement anymore in 15.4

Hi @AnneT , sincere apologies. That was a horrible bug report! I am using Safari 15.1.

AnneT added a subscriber: SimoneThisDot.

Assigning this to @SimoneThisDot since he has Browserstack access!

Hi guys, Unfortunately, Browserstack does not allow a "Minor version" of safari and I could just test in 15.3 and 14.1 and both work as expected :(

@EUdoh-WMF, do you want to do a pair programming session for me to debug the issue on your machine?

AnneT changed the task status from Open to In Progress.Jun 7 2022, 5:06 PM

@SimoneThisDot and I checked this again and it is not happening anymore! Will close this now.