| Case | Label | Mock |
|---|---|---|
| If the data is not available in Maximind | Not available |  |
| If the user doesn't have access to the data because of rights | No access |  |
Description
Description
Details
Details
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Show different labels when access is restricted to MaxMind data | mediawiki/extensions/IPInfo | master | +124 -81 |
Related Objects
Related Objects
Event Timeline
Comment Actions
Change 806898 had a related patch set uploaded (by Tchanders; author: Tchanders):
[mediawiki/extensions/IPInfo@master] Show different labels when access is restricted to MaxMind data
Comment Actions
@Prtksxna 'Connection type' is currently not displayed if it is the same as 'Connection owner', and instead is shown as 'Not available'. Since this now means the data is missing, I've changed this in the patch I've uploaded, so that it now displays even if it's the same. Is this ok? If not, what should we do?
Comment Actions
Yep that makes sense! Showing the data twice is better than confusion around what data is available (I feel this way especially after reading the feedback).
Comment Actions
Change 806898 merged by jenkins-bot:
[mediawiki/extensions/IPInfo@master] Show different labels when access is restricted to MaxMind data
Comment Actions
User with full viewing rights but no data:
User with basic viewing rights for the same IP:
Test environment: local docker IP Info 0.0.0 (a84b4cc) 06:18, 27 June 2022.