Migrate WikiEditor EditAttemptStep instrument to Metrics Platform
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	phuedx
	Jun 6 2022, 2:35 PM

Description

This task covers migrating the EditAttemptStep instrument in WikiEditor to the Metrics Platform.

Details

	Subject	Repo	Branch	Lines +/-
	Hooks: Also log EditAttemptStep events via Metrics Platform	mediawiki/extensions/WikiEditor	master	+57 -12
	mediawiki.edit_attempt: Ignore events from PHP MPC	operations/mediawiki-config	master	+12 -0

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Invalid	None	T309013 EditAttemptStep Migration to (monoschema) MP
Resolved	phuedx	T309985 Migrate WikiEditor EditAttemptStep instrument to Metrics Platform
Resolved	phuedx	T281762 Incorporate librarized Metrics Platform PHP client into EventLogging
Resolved	phuedx	T281765 Publish librarized Metrics Platform PHP client to Packagist
Resolved	• Mholloway	T281752 Conslidate Metrics Platform PHP client into mediawiki/libs/metrics-platform
Resolved	Krinkle	T309656 Performance review for new Metrics Plaform JS library
Resolved	Krinkle	T311120 Performance review for new Metrics Platform PHP library
Resolved	cjming	T330460 Fix context values in Java client to pass EventLogging validation

Event Timeline

phuedx created this task.Jun 6 2022, 2:35 PM

phuedx added a subtask: T281762: Incorporate librarized Metrics Platform PHP client into EventLogging.

• EChetty moved this task from Backlog to To be discussed on the Metrics Platform Backlog board.Oct 5 2022, 11:49 AM

phuedx mentioned this in T312016: Increase EditAttemptStep sampling rate(s) to 100%.Nov 17 2022, 8:29 AM

phuedx moved this task from To be discussed to Discussed on the Metrics Platform Backlog board.Mar 16 2023, 1:33 PM

phuedx claimed this task.Mar 23 2023, 2:59 PM

phuedx edited projects, added Metrics Platform Backlog (Metrics Platform Kanban); removed Metrics Platform Backlog.

phuedx moved this task from Ready to In Progress on the Metrics Platform Backlog (Metrics Platform Kanban) board.

phuedx removed a subscriber: • EChetty.

phuedx updated the task description. (Show Details)Mar 23 2023, 3:13 PM

Change 902441 had a related patch set uploaded (by Phuedx; author: Phuedx):

[mediawiki/extensions/WikiEditor@master] WIP: Hooks: Also log EditAttemptStep events via Metrics Platform

https://gerrit.wikimedia.org/r/902441

gerritbot added a project: Patch-For-Review.Mar 23 2023, 5:19 PM

I tested the above patch in my local development environment by creating a new mediawiki.edit_attempt stream that is only interested in events submitted by the PHP MPC, i.e.

LocalSettings.php

$wgEventStreams = [
	'mediawiki.edit_attempt' => [
		'schema_title' => 'analytics/mediawiki/client/metrics_event',
		'producers' => [
			'metrics_platform_client' => [
				'events' => [ 'eas.' ],
				'provide_values' => [
					'agent_client_platform',
					'agent_client_platform_family',
					'page_id',
					'page_title',
					'page_namespace',
					'page_revision_id',
					'mediawiki_version',
					'mediawiki_is_debug_mode',
					'mediawiki_database',
					'performer_is_logged_in',
					'performer_id',
					'performer_session_id',
					'performer_pageview_id',
					'performer_edit_count',
				],

				// Ignore events submitted by the PHP MPC on the production stream.
				'curation' => [
					'agent_client_platform' => [
						'not_equals' => 'mediawiki_php',
					]
				],
			],
		],
	],
	'test.mediawiki.edit_attempt' => [
		'schema_title' => 'analytics/mediawiki/client/metrics_event',
		'producers' => [
			'metrics_platform_client' => [
				'events' => [ 'eas.' ],
				'provide_values' => [
					'agent_client_platform',
					'agent_client_platform_family',
					'page_id',
					'page_title',
					'page_namespace',
					'page_revision_id',
					'mediawiki_version',
					'mediawiki_is_debug_mode',
					'mediawiki_database',
					'performer_is_logged_in',
					'performer_id',
					'performer_session_id',
					'performer_pageview_id',
					'performer_edit_count',
				],

				// Only allow events from the PHP MPC on this stream.
				'curation' => [
					'agent_client_platform' => [
						'equals' => 'mediawiki_php',
					],
				],
			],
		],
	],
];
$wgEventLoggingStreamNames = array_keys( $wgEventStreams );

This way, we can define the test.mediawiki.edit_attempt stream on as many or as few wikis as we like – starting with the Beta Cluster, then the test wikis, then… – without impacting the already-in-production mediawiki.edit_attempt stream.

phuedx moved this task from In Progress to Blocked/Paused on the Metrics Platform Backlog (Metrics Platform Kanban) board.Mar 27 2023, 6:41 PM

phuedx moved this task from Blocked/Paused to In Review on the Metrics Platform Backlog (Metrics Platform Kanban) board.Apr 3 2023, 11:36 AM

Change 905261 had a related patch set uploaded (by Phuedx; author: Phuedx):

[operations/mediawiki-config@master] mediawiki.edit_attempt: Ignore events from PHP MPC

https://gerrit.wikimedia.org/r/905261

cjming moved this task from In Review to Ready to Deploy on the Metrics Platform Backlog (Metrics Platform Kanban) board.Apr 5 2023, 12:17 AM

Change 905261 merged by jenkins-bot:

[operations/mediawiki-config@master] mediawiki.edit_attempt: Ignore events from PHP MPC

https://gerrit.wikimedia.org/r/905261

Mentioned in SAL (#wikimedia-operations) [2023-04-05T13:18:33Z] <lucaswerkmeister-wmde@deploy2002> Started scap: Backport for [[gerrit:905261|mediawiki.edit_attempt: Ignore events from PHP MPC (T309985)]]

Mentioned in SAL (#wikimedia-operations) [2023-04-05T13:19:56Z] <lucaswerkmeister-wmde@deploy2002> lucaswerkmeister-wmde and phuedx: Backport for [[gerrit:905261|mediawiki.edit_attempt: Ignore events from PHP MPC (T309985)]] synced to the testservers: mwdebug2002.codfw.wmnet, mwdebug1001.eqiad.wmnet, mwdebug2001.codfw.wmnet, mwdebug1002.eqiad.wmnet

Mentioned in SAL (#wikimedia-operations) [2023-04-05T13:29:25Z] <lucaswerkmeister-wmde@deploy2002> Finished scap: Backport for [[gerrit:905261|mediawiki.edit_attempt: Ignore events from PHP MPC (T309985)]] (duration: 10m 52s)