Page MenuHomePhabricator

Remove storybook from Minerva
Closed, ResolvedPublic


The Minerva storybook only has 2 stories which look broken. Given we never actively began using it, it was suggested we remove it from the repo.
On Thursday March 30th, with some changes relating to Codex the storybook broke further, this time blocking merges on a variety of patches including T327506.

Event Timeline

Change 797597 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/MinervaNeue@master] Remove storybook

Change 797597 abandoned by Jdlrobson:

[mediawiki/skins/MinervaNeue@master] Remove storybook


Jdlrobson triaged this task as Medium priority.Mar 15 2023, 10:36 PM

Change 797597 restored by Jdlrobson:

[mediawiki/skins/MinervaNeue@master] Remove storybook

With the latest Codex, our storybook is now causing CI issues that is blocking the content moderator tool team as well as other Gerrit patches from being merged.

It seems like a lot of work to fix it, for little value, so I think it makes sense to now remove

Jdlrobson renamed this task from Should we remove storybook from Minerva? to Remove storybook from Minerva.Mar 30 2023, 9:08 PM
Jdlrobson raised the priority of this task from Medium to High.
Jdlrobson updated the task description. (Show Details)

Change 797597 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@master] Remove storybook and update nvm version

Jan: Could you please sign this off? In particular, checking we didn't miss anything.

I looked through the repo and found no traces of Storybook left.

Change 949575 had a related patch set uploaded (by Paladox; author: Jdlrobson):

[mediawiki/skins/MinervaNeue@REL1_40] Remove storybook and update nvm version

Change 949575 merged by Krinkle:

[mediawiki/skins/MinervaNeue@REL1_40] Remove storybook and update nvm version