Page MenuHomePhabricator
Create Task
Maniphest T310004

Remove storybook from Minerva
Closed, ResolvedPublic
Actions

Description

The Minerva storybook only has 2 stories which look broken. Given we never actively began using it, it was suggested we remove it from the repo.
On Thursday March 30th, with some changes relating to Codex the storybook broke further, this time blocking merges on a variety of patches including T327506.

Details

SubjectRepoBranchLines +/-
Remove storybook and update nvm versionmediawiki/skins/MinervaNeueREL1_40+28 -23 K
Remove storybook and update nvm versionmediawiki/skins/MinervaNeuemaster+28 -23 K
Customize query in gerrit

Related Objects

Event Timeline

Jdlrobson created this task.Jun 6 2022, 4:54 PM
Restricted Application added subscribers: Masumrezarock100, Aklapper. · View Herald TranscriptJun 6 2022, 4:54 PM
gerritbot added a comment.Jun 6 2022, 4:54 PM

Change 797597 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/MinervaNeue@master] Remove storybook

https://gerrit.wikimedia.org/r/797597

gerritbot added a project: Patch-For-Review.Jun 6 2022, 4:54 PM
gerritbot added a comment.Jun 21 2022, 8:44 PM

Change 797597 abandoned by Jdlrobson:

[mediawiki/skins/MinervaNeue@master] Remove storybook

Reason:

https://gerrit.wikimedia.org/r/797597

Maintenance_bot removed a project: Patch-For-Review.Jun 21 2022, 9:30 PM
Jdlrobson mentioned this in T321102: [Dev cleanup] Remove broken storybook and jsdoc from Vector.Oct 18 2022, 5:48 PM
Jdlrobson triaged this task as Medium priority.Mar 15 2023, 10:36 PM
gerritbot added a comment.Mar 30 2023, 9:06 PM

Change 797597 restored by Jdlrobson:

[mediawiki/skins/MinervaNeue@master] Remove storybook

https://gerrit.wikimedia.org/r/797597

gerritbot added a project: Patch-For-Review.Mar 30 2023, 9:06 PM
Jdlrobson edited projects, added Web-Team-Backlog (Web Team FY2022-23 Q3 Sprint 6), Unplanned-Sprint-Work; removed Web-Team-Backlog (Needs Prioritization (Tech)).Mar 30 2023, 9:08 PM

With the latest Codex, our storybook is now causing CI issues that is blocking the content moderator tool team as well as other Gerrit patches from being merged.

It seems like a lot of work to fix it, for little value, so I think it makes sense to now remove

Jdlrobson renamed this task from Should we remove storybook from Minerva? to Remove storybook from Minerva.Mar 30 2023, 9:08 PM
Jdlrobson raised the priority of this task from Medium to High.
Jdlrobson updated the task description. (Show Details)
gerritbot added a comment.Mar 31 2023, 5:16 PM

Change 797597 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@master] Remove storybook and update nvm version

https://gerrit.wikimedia.org/r/797597

Jdlrobson assigned this task to Jdrewniak.Mar 31 2023, 5:29 PM
Jdlrobson moved this task from Incoming to Ready for Signoff on the Web-Team-Backlog (Web Team FY2022-23 Q3 Sprint 6) board.

Jan: Could you please sign this off? In particular, checking we didn't miss anything.

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.3; 2023-04-03).Mar 31 2023, 6:00 PM
Jdrewniak closed this task as Resolved.Apr 11 2023, 9:22 PM

I looked through the repo and found no traces of Storybook left.

Jdlrobson mentioned this in T334613: [Follow up] Discuss and document in our dev notes why storybook didn't work out for Vector and Minerva.Apr 12 2023, 5:13 PM
gerritbot added a comment.Aug 17 2023, 7:28 AM

Change 949575 had a related patch set uploaded (by Paladox; author: Jdlrobson):

[mediawiki/skins/MinervaNeue@REL1_40] Remove storybook and update nvm version

https://gerrit.wikimedia.org/r/949575

gerritbot added a comment.Aug 24 2023, 4:20 AM

Change 949575 merged by Krinkle:

[mediawiki/skins/MinervaNeue@REL1_40] Remove storybook and update nvm version

https://gerrit.wikimedia.org/r/949575

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits