Page MenuHomePhabricator
Create Task
Maniphest T327506

Remove AMC restriction from preferences section of Special:MobileOptions
Closed, ResolvedPublic3 Estimated Story Points
Actions

Description

While the new design for mobile Special:Preferences is available to all mobile users, there is no link in the UI to get there except for AMC users. This link was added in T311720.

To finish up our work on this page we need to remove the AMC limiter we implemented for the preferences link in Special:MobileOptions.

User story
As a Wikipedia editor, I want to access my user preferences from the mobile web sidebar via the Settings menu, so that I can customise my experience.

Technical information

TBD

Testing and QA steps

  • Log in to an account
  • Browse the mobile web and/or MinervaNeue version of the site
  • Open the sidebar and select Settings
  • The preferences section, with a link to Special:Preferences, should be visible in the list

Acceptance criteria

  • All logged in editors should see a link to Special:Preferences in Special:MobileOptions

Details

SubjectRepoBranchLines +/-
Make Special:Preferences option available in Special:MobileOptionsmediawiki/extensions/MobileFrontendmaster+3 -6
Customize query in gerrit

Related Objects
Search...

Event Timeline

Samwalton9-WMF created this task.Jan 20 2023, 2:33 PM
Samwalton9-WMF moved this task from Inbox to To be estimated on the Moderator-Tools-Team board.Jan 25 2023, 12:27 PM
jsn.sherman set the point value for this task to 3.Feb 1 2023, 2:12 PM
Samwalton9-WMF edited projects, added Moderator-Tools-Team (Kanban); removed Moderator-Tools-Team.Feb 1 2023, 2:14 PM
JohanahoJ subscribed.Feb 15 2023, 9:04 AM
JohanahoJ mentioned this in T65532: Gadget preferences should hide or discourage entries that can't be enabled in the current skin (e.g. vector-only).Feb 15 2023, 9:49 AM
Krinkle awarded a token.Feb 15 2023, 3:45 PM
Scardenasmolinar claimed this task.Feb 16 2023, 3:36 PM
Scardenasmolinar moved this task from Ready to In Progress on the Moderator-Tools-Team (Kanban) board.
Scardenasmolinar changed the task status from Open to In Progress.Feb 16 2023, 6:41 PM
gerritbot added a comment.Feb 21 2023, 7:21 PM

Change 890898 had a related patch set uploaded (by Scardenasmolinar; author: Scardenasmolinar):

[mediawiki/extensions/MobileFrontend@master] Make Special:Preferences option available in Special:MobileOptions

https://gerrit.wikimedia.org/r/890898

gerritbot added a project: Patch-For-Review.Feb 21 2023, 7:21 PM
Scardenasmolinar moved this task from In Progress to Code review on the Moderator-Tools-Team (Kanban) board.Feb 21 2023, 7:43 PM
Samwalton9-WMF changed the task status from In Progress to Stalled.Feb 23 2023, 3:43 PM
Samwalton9-WMF moved this task from Code review to In Progress on the Moderator-Tools-Team (Kanban) board.

Marked as stalled as we're going to wait on T325574 to be deployed and tested first.

Scardenasmolinar changed the task status from Stalled to In Progress.Mar 29 2023, 11:28 PM

This is no longer stalled :)

Scardenasmolinar moved this task from In Progress to Code review on the Moderator-Tools-Team (Kanban) board.Mar 29 2023, 11:28 PM
Scardenasmolinar moved this task from Code review to Done on the Moderator-Tools-Team (Kanban) board.Mar 30 2023, 12:06 AM

This has been merged!

Jdlrobson mentioned this in T310004: Remove storybook from Minerva.Mar 30 2023, 9:09 PM
gerritbot added a comment.Mar 31 2023, 5:17 PM

Change 890898 merged by jenkins-bot:

[mediawiki/extensions/MobileFrontend@master] Make Special:Preferences option available in Special:MobileOptions

https://gerrit.wikimedia.org/r/890898

Maintenance_bot removed a project: Patch-For-Review.Mar 31 2023, 5:30 PM
ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.3; 2023-04-03).Mar 31 2023, 6:00 PM
Samwalton9-WMF closed this task as Resolved.Apr 11 2023, 4:32 PM

This is now live!

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL