Page MenuHomePhabricator

Mark freshly undeleted articles as unreviewed automatically
Closed, ResolvedPublicFeature

Description

Feature summary
Requesting that a hook be added to undelete, so that when an article is undeleted, it is marked as unpatrolled. This should probably be regardless of previous patrol status, and regardless of autopatrol of the admin.

Use case(s)

Benefits
To close a loophole involving AFDing an article, marking it as patrolled, it getting deleted, then it getting [[WP:REFUND]]ed by an admin. This loophole allows an article to be marked as reviewed that shouldn't be.

Consensus at https://en.wikipedia.org/wiki/Wikipedia_talk:New_pages_patrol/Reviewers#Article_patrol_status_after_refund/undelete

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Novem_Linguae renamed this task from Add hook to undelete to unpatrol articles to Mark freshly undeleted articles as unreviewed automatically.Jun 25 2022, 6:16 PM

I'm surprised this wasn't already standard. I kind of took it for granted that it was. Needs to be done quickly.

kostajh subscribed.

Thanks for filing this. It's not something that the Growth team can work on any time soon (see here for our maintenance support). Patches welcome.

The Growth Team formed in July 2018 to support the Wikimedia Foundation's long-term goal of "Knowledge Equity" through the Audiences department's "New Content" program. The "Knowledge Equity" goal and the "New Content" program are about building strong communities that make diverse knowledge available to people all over the world. One critical pathway toward those goals is through engaging new contributors in Wikimedia projects. But because of the cultural and technical skills needed to productively contribute to the projects, very few people who begin to contribute continue to do so in the days and weeks after their initial involvement. The Growth Team's objective is to address this problem through software changes that help retain new contributors in mid-size Wikimedia projects, starting with Wikipedias.

The needs of the New Page Patrol process falls squarely in this description.

Change 809102 had a related patch set uploaded (by Majavah; author: Majavah):

[mediawiki/extensions/PageTriage@master] Mark undeleted pages as unpatrolled

https://gerrit.wikimedia.org/r/809102

Change 809102 merged by jenkins-bot:

[mediawiki/extensions/PageTriage@master] Mark undeleted pages as unpatrolled

https://gerrit.wikimedia.org/r/809102

Hi @Kudpung -- thanks for following up on this. A volunteer wrote a patch to make this fix, and an engineer from the Growth team reviewed and merged it, so I believe this should be fixed on the wiki by Friday of next week! Please let us know if you see differently. Although the Growth team isn't always able to fit in work on PageTriage, we definitely try, and especially try to prioritize reviewing volunteer patches. Happily, that's what happened here.

I'd also like to take the opportunity to introduce you to @KStoller-WMF, who is the new product manager of the Growth team. She has lots of good experience with community-driven websites and I think she is a great fit for the work of the team and the communities. I'm moving into more of a management role for multiple teams, and I'm working closely with @KStoller-WMF going forward -- but I just wanted to point out this change so that you can be in touch with either of us in the future.

Hi @MMiller_WMF , thank you so much for this good news. It comes as extremely welcome at a time when unscrupulous users are increasingly finding new loopholes to get their inadmissible and inappropriate new articles past our controls. Huge thanks also to @taavi for taking it on and getting it done in record time. FYI: @mb , @Novem_Linguae , and @Atsme.

This is great news, Kudz. I also thought it was automatic, so what do I need to do to help move this through for us?

Betty Wills
(Atsme on Wikipedia)

@Atsme: nothing. My post and adding you as a follower was FYI only. I'm very pleased it's being done.

Change 809998 had a related patch set uploaded (by Majavah; author: Majavah):

[mediawiki/extensions/PageTriage@master] UndeleteHookHandler: Add namespace filter

https://gerrit.wikimedia.org/r/809998

Change 809998 merged by jenkins-bot:

[mediawiki/extensions/PageTriage@master] UndeleteHookHandler: Add namespace filter

https://gerrit.wikimedia.org/r/809998

Change 812451 had a related patch set uploaded (by Majavah; author: Majavah):

[mediawiki/extensions/PageTriage@master] UndeleteHookHandler: fix namespace conditional

https://gerrit.wikimedia.org/r/812451

Change 812451 merged by jenkins-bot:

[mediawiki/extensions/PageTriage@master] UndeleteHookHandler: fix namespace conditional

https://gerrit.wikimedia.org/r/812451

Change 812532 had a related patch set uploaded (by Majavah; author: Majavah):

[mediawiki/extensions/PageTriage@wmf/1.39.0-wmf.19] UndeleteHookHandler: fix namespace conditional

https://gerrit.wikimedia.org/r/812532

Change 812532 merged by jenkins-bot:

[mediawiki/extensions/PageTriage@wmf/1.39.0-wmf.19] UndeleteHookHandler: fix namespace conditional

https://gerrit.wikimedia.org/r/812532

Mentioned in SAL (#wikimedia-operations) [2022-07-11T07:43:05Z] <taavi@deploy1002> Synchronized php-1.39.0-wmf.19/extensions/PageTriage/includes/HookHandlers/UndeleteHookHandler.php: Backport: [[gerrit:812532|UndeleteHookHandler: fix namespace conditional (T311347)]] (duration: 02m 54s)

Thanks for your work on this taavi. However I think it is failing the following test case.

  • visit https://test.wikipedia.org/
  • log into an admin account
  • create a random page
  • delete the page using More -> Delete
  • undelete the page using Special:Undelete
  • should not be marked as reviewed, but is currently marked as reviewed

Thanks for your work on this taavi. However I think it is failing the following test case.

Cannot reproduce:

  1. Created article "Test article 123".
  2. Deleted and undeleted it.
  3. Visited Special:NewPagesFeed. Article is listed as unreviewed:

image.png (385×1 px, 63 KB)

  1. Visited the article itself. Page curation toolbar shows the article as unreviewed.

image.png (403×573 px, 52 KB)

Ah, you're right. I got thrown off by not having a green check mark. Clicking the information button does confirm that it is unreviewed. Sorry for the confusion!