Page MenuHomePhabricator

Clicking New section and then legacy mode from diff view gives a confusing error message "Section editing not supported"
Closed, ResolvedPublic

Description

https://en.wikipedia.org/w/index.php?title=Wikipedia%3AVillage_pump_%28technical%29#Possible_bug_(clicking_New_section_and_then_legacy_mode_from_diff_view)

I was just looking at the latest diffs of this page via my watchlist, then clicked the "New section" link at top of the page, which brought up the new interface, then clicked "switch back to the legacy experience". That brought up the following:

Section editing not supported

Section editing is not supported in this page or is disabled for this view.

Return to Main Page.

I don't know what is supposed to happen, but I don't think that is it. "Return to Main Page"? Weird. – @Jonesey95

image.png (2×3 px, 205 KB)

Event Timeline

Change 809675 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/DiscussionTools@master] New topic hint: Avoid error about section editing when opened from diff

https://gerrit.wikimedia.org/r/809675

matmarex renamed this task from Clicking New section and then legacy mode from diff view gives a confusing error message to Clicking New section and then legacy mode from diff view gives a confusing error message "Section editing not supported".Jun 29 2022, 7:44 PM
matmarex updated the task description. (Show Details)
matmarex moved this task from Incoming to Code Review on the Editing-team (Kanban Board) board.
matmarex added a subscriber: Jonesey95.

Change 809675 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@master] New topic hint: Avoid error about section editing when opened from diff

https://gerrit.wikimedia.org/r/809675

Change 809688 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/DiscussionTools@wmf/1.39.0-wmf.17] New topic hint: Avoid error about section editing when opened from diff

https://gerrit.wikimedia.org/r/809688

Change 809689 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/DiscussionTools@wmf/1.39.0-wmf.18] New topic hint: Avoid error about section editing when opened from diff

https://gerrit.wikimedia.org/r/809689

We're just in time for the backport window, so I thought we might backport this, even though it's not the most severe of issues.

Change 809688 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@wmf/1.39.0-wmf.17] New topic hint: Avoid error about section editing when opened from diff

https://gerrit.wikimedia.org/r/809688

Change 809689 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@wmf/1.39.0-wmf.18] New topic hint: Avoid error about section editing when opened from diff

https://gerrit.wikimedia.org/r/809689

Mentioned in SAL (#wikimedia-operations) [2022-06-29T21:30:09Z] <cjming@deploy1002> Synchronized php-1.39.0-wmf.17/extensions/DiscussionTools/modules/NewTopicController.js: Backport: [[gerrit:809688|New topic hint: Avoid error about section editing when opened from diff (T311665)]] (duration: 03m 35s)

Mentioned in SAL (#wikimedia-operations) [2022-06-29T21:34:07Z] <cjming@deploy1002> Synchronized php-1.39.0-wmf.18/extensions/DiscussionTools/modules/NewTopicController.js: Backport: [[gerrit:809689|New topic hint: Avoid error about section editing when opened from diff (T311665)]] (duration: 03m 43s)

New Section -> Legacy mode from diff view doesn't give confusing error message. See https://photos.app.goo.gl/NQaeSP9CgQgSnFDt6

This is now FIXED for me in legacy Vector on en.WP (the original conditions in which the bug was observed). Thanks for the quick patch!