When structured mentor list is enabled, Special:QuitMentorship does not let mentors with no mentees to quit
Closed, ResolvedPublic
Actions

Description

The Growth-Team is working on a structured mentor list as part of T264343. One of this project's consequences is that non-admin mentors will not be able to edit the mentor list directly anymore, as it is stored in NS_MEDIAWIKI as MediaWiki:GrowthMentors.json. Instead, they use Growth team-prepared interfaces to change their mentorship aspects, such as introduction message, number of mentees they want to be assigned to or enrolling/quitting.

When structured mentor list is enabled (as of writing, only the case for beta enwiki, cf. T312102), Special:QuitMentorship does not let mentors with no mentees to quit (it says "You currently don't have any mentees."). Since mentors cannot take their name off the mentor list directly, Special:QuitMentorship should not take the number of mentees into effect.

Originally reported by @KStoller-WMF in T312102#8058414.

Acceptance criteria

When the structured mentor list is enabled, mentors with no mentees assigned are able to quit via Special:QuitMentorship

Details

	Subject	Repo	Branch	Lines +/-
	QuitMentorship: Do not check if a mentor has mentees with structured list	mediawiki/extensions/GrowthExperiments	master	+70 -58

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Resolved	Urbanecm_WMF	T272376 Make it possible for admin to remove a mentor when they quit/are blocked
Resolved	Urbanecm_WMF	T264343 Have a special page for mentors to sign up
Resolved	Urbanecm_WMF	T312577 When structured mentor list is enabled, Special:QuitMentorship does not let mentors with no mentees to quit

Event Timeline

Urbanecm_WMF created this task.Jul 7 2022, 5:09 PM

Restricted Application added a project: Growth-Team. · View Herald TranscriptJul 7 2022, 5:09 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Urbanecm_WMF mentioned this in T312102: Test the initial version of structured mentor list at beta English Wikipedia.Jul 7 2022, 5:10 PM

Urbanecm_WMF added a parent task: T264343: Have a special page for mentors to sign up.

Release blocker for T264343.

Urbanecm_WMF claimed this task.Jul 7 2022, 5:16 PM

Urbanecm_WMF edited projects, added Growth-Team (Sprint 0 (Growth Team)), User-Urbanecm_WMF (Engineering); removed Growth-Team.

Urbanecm_WMF moved this task from Incoming to Ready for Development on the Growth-Team (Sprint 0 (Growth Team)) board.

Urbanecm_WMF moved this task from Ready for Development to In Progress on the Growth-Team (Sprint 0 (Growth Team)) board.Jul 7 2022, 5:18 PM

Change 812040 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/GrowthExperiments@master] QuitMentorship: Do not check if a mentor has mentees with structured list

https://gerrit.wikimedia.org/r/812040

gerritbot added a project: Patch-For-Review.Jul 7 2022, 5:36 PM

Urbanecm_WMF moved this task from In Progress to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.Jul 7 2022, 5:37 PM

Urbanecm_WMF moved this task from Backlog to In review on the User-Urbanecm_WMF (Engineering) board.

kostajh moved this task from Code Review to QA on the Growth-Team (Sprint 0 (Growth Team)) board.Jul 20 2022, 12:26 PM

Change 812040 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] QuitMentorship: Do not check if a mentor has mentees with structured list

https://gerrit.wikimedia.org/r/812040

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.22; 2022-07-25).Jul 20 2022, 1:00 PM

Maintenance_bot removed a project: Patch-For-Review.Jul 20 2022, 1:30 PM

Checked in betalabs - works as expected. The production (checked on testwiki wmf.22) doesn't have the structured mentor list.

Etonkovidova moved this task from QA to Test in Production | Watching on the Growth-Team (Sprint 0 (Growth Team)) board.Jul 28 2022, 8:07 PM

In T312577#8113431, @Etonkovidova wrote:

Checked in betalabs - works as expected. The production (checked on testwiki wmf.22) doesn't have the structured mentor list.

Thanks. That's expected (for now), until the deployment (T310905) passes the testwiki step.

Checked in testwiki wmf.23 - works as expected.

When structured mentor list is enabled, Special:QuitMentorship does not let mentors with no mentees to quitClosed, ResolvedPublicActions