Page MenuHomePhabricator

Editing through section-edit button sometimes duplicates all other sections
Open, Needs TriagePublicBUG REPORT

Description

I can't replicate this myself, but there are a number of reports on Dutch Wikipedia that when using the visual editor through the section-edit button, paragraphs of text duplicate. This seems not to happen consistently, is not possible to be reproduced reliably and does not seem to happen when the 'edit' button at the top of the page or the 'edit source' buttons are used.

Discussions about this are here: discussion late June (Dutch), Discussion early July (Dutch) (permalink). Reports are both from Windows+Firefox and MaxOS+Safari.

Some examples:

Steps to replicate the issue (include links if applicable):

  • Click 'edit' (for visual editor) on a section of a longish article
  • edit window opens
  • some text is duplicated (unpredictably which)
  • Summary may refer to the wrong section

What happens?:
Some text from the article is duplicated when editing.

What should have happened instead?:
Text should not have been duplicated.

Other information (browser name/version, screenshots, etc.):

Event Timeline

Aklapper renamed this task from Reports of inconsistent behavior of visual editor to Editing through section-edit button sometimes duplicates text of paragraphs.Jul 11 2022, 6:13 AM
Aklapper added a project: VisualEditor.

Are any gadgets involved / Does that also happen with safemode? See https://www.mediawiki.org/wiki/Help:Locating_broken_scripts

Esanders subscribed.

Loading VE on desktop via the section edit button is no different than loading it via the regular edit button, we just scroll you to the section you clicked on, so that is unlikely to be the cause.

Could be a Parsoid bug too.

Hmm ... very strange ..., I tried to replicate a number of ways and I couldn't replicate it (whether with Edit button or Edit Section button). The discussions (read via Google Translate) also refer to summary referring to the wrong section which is also weird. That may be a useful clue to pursue. Wonder if this bug is specific to nlwiki or if it is impacting other wikis. And, looks like only a handful of users seem to be running into this (is it because they are the ones who use Edit Section links more than others OR if there is something about their editing environment that is triggering this bug).

For the record: I asked the users involved to try the suggestion by aklapper and report back.

@Whatamidoing-WMF (un)fortunately, I'm not one of the people affected by this bug. I'll ask though!

Thanks for asking. I see that Thieu isn't using the GoogleTrans gadget, so that's not the source of the problem.

ppelberg moved this task from Untriaged to This Fiscal Year on the Editing-team board.
ppelberg moved this task from To Triage to Triaged on the VisualEditor board.

The diffs look like the content of the whole page (including the user's edit to one section) was saved as the content of just that one section, instead of the whole page.

VisualEditor has two modes for section editing – one that edits the whole page and just scrolls to the section, and another that actually edits only one section. We use the first on desktop and the second on mobile. Possibly it can get confused about which mode it is in – maybe when restoring from autosave, or switching between the mobile and desktop site?

matmarex renamed this task from Editing through section-edit button sometimes duplicates text of paragraphs to Editing through section-edit button sometimes duplicates all other sections.Aug 25 2022, 4:10 PM

Hi,

At first, the issue seemed to happen completely random, but today I did a couple of tests and I was able to reproduce it twice:

REPRODUCTION WHILE LOGGED IN AS "Sietske"

  1. Access an article with multiple level 2 sections (==)
  2. Press on "bewerken" (edit) next to a level 2 section (==)

Expected result: I am able to edit the section (and only this section) in the visual editor mode
Actual result: I am able to edit the entire page ==> DON'T THINK THIS IS OK???

  1. Edit the level 2 section
  2. Save the page
  3. Check the page

Expected result: only the changes I made in step 3 are updated
Actual result: only the changes I made in step 3 are updated ==> OK

  1. Press on "bewerken" (edit) next to a level 2 section (==)
  2. Edit another level 2 section than the one you are supposed to edit
  3. Save the page
  4. Check the page

Expected result: only the changes I made in step 3 are updated
Actual result: the changes I made in step 3 are updated, and all other sections appear twice in the article ==> NOT OK

REPRODUCTION WHILE LOGGED IN WITH A NEWLY CREATED ACCOUNT
0) Create a new, clean account.

I've created a new account called "Sietske T312736"

  1. Access an article with multiple level 2 sections (==)
  2. Press on "bewerken" (edit) next to a level 2 section (==)

Expected result: I am able to edit the section (and only this section) in the visual editor mode
Actual result: I am able to edit the entire page ==> DON'T THINK THIS IS OK???

  1. Edit the level 2 section
  2. Save the page
  3. Check the page

Expected result: only the changes I made in step 3 are updated
Actual result: only the changes I made in step 3 are updated ==> OK

  1. Press on "bewerken" (edit) next to a level 2 section (==)
  2. Edit another level 2 section than the one you are supposed to edit
  3. Save the page
  4. Check the page

Expected result: only the changes I made in step 3 are updated
Actual result: only the changes I made in step 3 are updated ==> OK

RESULT
The issue occurs for user "Sietske", but it does not occur for user "Sietske T312736"

CONCLUSION
It seems that the issue is a result of "something" in my user profile that is different from a default user profile.

@Sietske Thanks a lot. I believe the ability to edit the entire page is by design (although it is a bit confusing, i agree). I was unable to reproduce it myself so far this way, but trying to turn on some features to see if I can find it too.

@ssastry @Whatamidoing-WMF we now have a volunteer who's able to reproduce the error. Please let them know any additional questions you may have to drill down to the cause :)