Page MenuHomePhabricator
Create Task
Maniphest T312853

Use the new language Item search profile in new-lexeme-special-page.git
Closed, ResolvedPublic5 Estimated Story Points
Actions

Description

As part of T307869 a new search profile for language Items was created and a new optional profile parameter was added to the wbsearchentities API endpoint.

For the users of Special:NewLexemeAlpha to actually benefit from these improved results, we need to make use of that new parameter in our API call.

Acceptance criteria

  • The search API call for Items in the LanguageInput uses the new profile=language parameter
  • The submodule-commit in WikibaseLexeme.git as bumped to include this functionality
  • This is available on beta Wikidata and does not cause errors there

Details

SubjectRepoBranchLines +/-
Bump SNL to make use of search profilesmediawiki/extensions/WikibaseLexememaster+5 -4
Make search profiles available to appmediawiki/extensions/WikibaseLexememaster+3 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

Michael created this task.Jul 12 2022, 12:52 PM
Lydia_Pintscher moved this task from Backlog to milestone 3 on the Special:NewLexeme revival board.Jul 15 2022, 10:46 AM
Lydia_Pintscher added a project: Wikidata Dev Team.Jul 26 2022, 8:50 AM
Lydia_Pintscher moved this task from Incoming to Product Backlog on the Wikidata Dev Team board.
Lydia_Pintscher updated the task description. (Show Details)Aug 3 2022, 8:44 AM
karapayneWMDE set the point value for this task to 5.Aug 9 2022, 9:30 AM
karapayneWMDE moved this task from Product Backlog to Unified DOT Backlog on the Wikidata Dev Team board.
Lydia_Pintscher added a parent task: T307866: Replace existing Special:NewLexeme page with the new one.Aug 12 2022, 3:21 PM
noarave added subscribers: Lucas_Werkmeister_WMDE, noarave.Sep 8 2022, 2:15 PM

Task Breakdown Notes:

  • The language search profile is not supported on the default Wikibase (only on Beta and Test), therefore difficult to test locally.
  • We should only add the profile=language API parameter if the wiki supports it.
  • The $wgWBRepoSettings['searchProfiles'] setting lists available profiles.
  • We should clean up the API so that the profile parameter itself is always available, even when only one profile is configured. Subtask to be created by @Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE added a comment.Sep 8 2022, 2:17 PM
In T312853#8221158, @noarave wrote:
  • We should clean up the API so that the profile parameter itself is always available, even when only one profile is configured. Subtask to be created by @Lucas_Werkmeister_WMDE

T317317: Always make wbsearchentities profile parameter available

Michael claimed this task.Sep 9 2022, 10:30 AM
Michael moved this task from Unified DOT Backlog to Sprint-∞ on the Wikidata Dev Team board.
Michael edited projects, added Wikidata Dev Team (Sprint-∞); removed Wikidata Dev Team.
Michael moved this task from Parents/Waiting to Doing on the Wikidata Dev Team (Sprint-∞) board.
Restricted Application added a project: User-Michael. · View Herald TranscriptSep 9 2022, 10:30 AM
gerritbot added a comment.Sep 9 2022, 10:49 AM

Change 831064 had a related patch set uploaded (by Michael Große; author: Michael Große):

[mediawiki/extensions/WikibaseLexeme@master] Make search profiles available to app

https://gerrit.wikimedia.org/r/831064

gerritbot added a project: Patch-For-Review.Sep 9 2022, 10:49 AM
Michael added a comment.Sep 9 2022, 12:50 PM

Ready for review: https://github.com/wmde/new-lexeme-special-page/pull/289

Michael moved this task from Doing to Peer Review on the Wikidata Dev Team (Sprint-∞) board.Sep 9 2022, 12:53 PM
gerritbot added a comment.Sep 9 2022, 2:31 PM

Change 831099 had a related patch set uploaded (by Michael Große; author: Michael Große):

[mediawiki/extensions/WikibaseLexeme@master] Bump SNL to make use of search profiles

https://gerrit.wikimedia.org/r/831099

gerritbot added a comment.Sep 12 2022, 9:12 AM

Change 831064 merged by jenkins-bot:

[mediawiki/extensions/WikibaseLexeme@master] Make search profiles available to app

https://gerrit.wikimedia.org/r/831064

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.1; 2022-09-12).Sep 12 2022, 10:00 AM
gerritbot added a comment.Sep 12 2022, 2:19 PM

Change 831099 merged by jenkins-bot:

[mediawiki/extensions/WikibaseLexeme@master] Bump SNL to make use of search profiles

https://gerrit.wikimedia.org/r/831099

Lucas_Werkmeister_WMDE moved this task from Peer Review to Product Verification on the Wikidata Dev Team (Sprint-∞) board.Sep 12 2022, 2:22 PM
Michael added a comment.Sep 15 2022, 9:19 AM

This can now be verified as working on https://www.wikidata.org/wiki/Special:NewLexemeAlpha

Lydia_Pintscher closed this task as Resolved.Sep 15 2022, 12:32 PM
Lydia_Pintscher moved this task from Product Verification to Our work done on the Wikidata Dev Team (Sprint-∞) board.
Lydia_Pintscher subscribed.

💃

karapayneWMDE moved this task from Our work done to 2022 Completed Tasks on the Wikidata Dev Team (Sprint-∞) board.Oct 4 2022, 9:14 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits