Page MenuHomePhabricator

mwgate-node14-docker failing on parsoid REL1_35
Closed, ResolvedPublic

Description

https://gerrit.wikimedia.org/r/c/mediawiki/services/parsoid/+/813862

https://integration.wikimedia.org/ci/job/mwgate-node14-docker/43021/console

16:43:03 + npm ci
16:43:12 npm WARN tarball tarball data for gc-stats@git+ssh://git@github.com/dainis/node-gcstats.git#5be60dfd24293d6cefbc8a459c1537611373fac5 (sha512-MJF9eEPbRJMOjK+jmDAe6QC+s1mZU9Xe6hAc2pe21LS8uFEKnoGiPf72OWpi2HSNvSalyw+tjH6Yr5JOb60FOQ==) seems to be corrupted. Trying again.
16:43:16 npm WARN tarball tarball data for gc-stats@git+ssh://git@github.com/dainis/node-gcstats.git#5be60dfd24293d6cefbc8a459c1537611373fac5 (sha512-MJF9eEPbRJMOjK+jmDAe6QC+s1mZU9Xe6hAc2pe21LS8uFEKnoGiPf72OWpi2HSNvSalyw+tjH6Yr5JOb60FOQ==) seems to be corrupted. Trying again.
16:43:21 npm WARN deprecated uuid@3.4.0: Please upgrade  to version 7 or higher.  Older versions may use Math.random() in certain circumstances, which is known to be problematic.  See https://v8.dev/blog/math-random for details.
16:43:21 npm WARN deprecated kad-fs@0.0.4: This package is no longer maintained.
16:43:21 npm WARN deprecated kad-memstore@0.0.1: This package is no longer maintained.
16:43:21 npm WARN deprecated har-validator@5.1.5: this library is no longer supported
16:43:22 npm WARN deprecated formidable@1.2.6: Please upgrade to latest, formidable@v2 or formidable@v3! Check these notes: https://bit.ly/2ZEqIau
16:43:23 npm WARN deprecated request@2.88.2: request has been deprecated, see https://github.com/request/request/issues/3142
16:43:23 npm WARN deprecated superagent@3.8.3: Please upgrade to v7.0.2+ of superagent.  We have fixed numerous issues with streams, form-data, attach(), filesystem errors not bubbling up (ENOENT on attach()), and all tests are now passing.  See the releases tab for more information at <https://github.com/visionmedia/superagent/releases>.
16:43:24 npm WARN deprecated superagent@6.1.0: Please upgrade to v7.0.2+ of superagent.  We have fixed numerous issues with streams, form-data, attach(), filesystem errors not bubbling up (ENOENT on attach()), and all tests are now passing.  See the releases tab for more information at <https://github.com/visionmedia/superagent/releases>.
16:43:25 npm WARN tarball tarball data for js2php@git+ssh://git@github.com/cscott/js2php.git#c4e4b1d30546e5346448a145cd7e0ff1145e0d4a (sha512-qQdphaodGn3tybfxthpYmHUdkHWZqIEcDjYL/J/WzDmcVgAiNBLXcHF5BWFoH4D546IPwZ0v+Tm5PC3sPRsv3Q==) seems to be corrupted. Trying again.
16:43:26 npm WARN tarball tarball data for js2php@git+ssh://git@github.com/cscott/js2php.git#c4e4b1d30546e5346448a145cd7e0ff1145e0d4a (sha512-qQdphaodGn3tybfxthpYmHUdkHWZqIEcDjYL/J/WzDmcVgAiNBLXcHF5BWFoH4D546IPwZ0v+Tm5PC3sPRsv3Q==) seems to be corrupted. Trying again.
16:43:27 npm WARN deprecated core-js@2.6.12: core-js@<3.4 is no longer maintained and not recommended for usage due to the number of issues. Because of the V8 engine whims, feature detection in old core-js versions could cause a slowdown up to 100x even if nothing is polyfilled. Please, upgrade your dependencies to the actual version of core-js.
16:43:29 npm ERR! code EINTEGRITY
16:43:29 npm ERR! sha512-qQdphaodGn3tybfxthpYmHUdkHWZqIEcDjYL/J/WzDmcVgAiNBLXcHF5BWFoH4D546IPwZ0v+Tm5PC3sPRsv3Q== integrity checksum failed when using sha512: wanted sha512-qQdphaodGn3tybfxthpYmHUdkHWZqIEcDjYL/J/WzDmcVgAiNBLXcHF5BWFoH4D546IPwZ0v+Tm5PC3sPRsv3Q== but got sha512-YQ2oo5ctdX25sZeVGqjGyP2jSw4A2sROx3zqKY1oo4qWnyv8pAJwQ5niz4pPDeFthqzGc0xZ+cSHbd9a1qab2A==. (28481 bytes)
16:43:29 
16:43:29 npm ERR! A complete log of this run can be found in:
16:43:29 npm ERR!     /cache/_logs/2022-07-14T15_43_29_356Z-debug.log
16:43:29 Build step 'Execute shell' marked build as failure

Event Timeline

This is a CI issue that would interfere with another point release on the REL1_35 branch, right? It seems we need to do our "standard" package.json bump to deal with the various npm issues. @Arlolra has been doing these in the past.

This is a CI issue that would interfere with another point release on the REL1_35 branch, right? It seems we need to do our "standard" package.json bump to deal with the various npm issues. @Arlolra has been doing these in the past.

Point release of the REL1_35 branch of Parsoid, yeah.

And it should just be the usual package.json updates as you say... Maybe we should try and get better at backporting them to supported release branches when we make them into master, then we hopefully don't get these stragglers at a later date.

This was fixed by removing those dependencies altogether,
https://github.com/wikimedia/parsoid/commit/b2410c2a443e541caad1f43c3e3d6f2e2f009ed3
https://github.com/wikimedia/parsoid/commit/d91e0462047cec8d94107e85bf78b3a54792b0a0

As of 1.35, we switched to only supporting Parsoid/PHP. So, I can backport them but it'll break the Parsoid/JS that's still in the tree there.

I agree with Arlo. Given that Parsoid/JS was EOLed in 1.31 and the JS code in the repo only existed to support development tools, it seems reasonable to break that JS code in that and not carry around the headache of dealing with security updates and vulnerabilities in that code.

Maybe we should try and get better at backporting them to supported release branches when we make them into master, then we hopefully don't get these stragglers at a later date.

Backports to 1.38 are in a chain of patches ending in,
https://gerrit.wikimedia.org/r/c/mediawiki/services/parsoid/+/820572

Change 823733 had a related patch set uploaded (by Arlolra; author: Arlolra):

[mediawiki/services/parsoid@REL1_35] Remove service-runner and a bunch of other dependencies

https://gerrit.wikimedia.org/r/823733

Change 823733 merged by jenkins-bot:

[mediawiki/services/parsoid@REL1_35] Remove service-runner and a bunch of other dependencies

https://gerrit.wikimedia.org/r/823733

Change 832358 had a related patch set uploaded (by Arlolra; author: Arlolra):

[mediawiki/core@REL1_35] Bump wikimedia/parsoid to v0.12.3

https://gerrit.wikimedia.org/r/832358

Change 832365 had a related patch set uploaded (by Arlolra; author: Arlolra):

[mediawiki/core@REL1_37] Bump wikimedia/parsoid to v0.14.2

https://gerrit.wikimedia.org/r/832365

Change 832367 had a related patch set uploaded (by Arlolra; author: Arlolra):

[mediawiki/core@REL1_38] Bump wikimedia/parsoid to v0.15.1

https://gerrit.wikimedia.org/r/832367

Change 832357 had a related patch set uploaded (by Arlolra; author: Arlolra):

[mediawiki/vendor@REL1_35] Bump wikimedia/parsoid to v0.12.3

https://gerrit.wikimedia.org/r/832357

Change 832364 had a related patch set uploaded (by Arlolra; author: Arlolra):

[mediawiki/vendor@REL1_37] Bump wikimedia/parsoid to v0.14.2

https://gerrit.wikimedia.org/r/832364

Change 832366 had a related patch set uploaded (by Arlolra; author: Arlolra):

[mediawiki/vendor@REL1_38] Bump wikimedia/parsoid to v0.15.1

https://gerrit.wikimedia.org/r/832366

Change 832366 merged by Zabe:

[mediawiki/vendor@REL1_38] Bump wikimedia/parsoid to v0.15.1

https://gerrit.wikimedia.org/r/832366

Change 832367 merged by Zabe:

[mediawiki/core@REL1_38] Bump wikimedia/parsoid to v0.15.1

https://gerrit.wikimedia.org/r/832367

Change 832357 merged by Jforrester:

[mediawiki/vendor@REL1_35] Bump wikimedia/parsoid to v0.12.3

https://gerrit.wikimedia.org/r/832357

Change 832364 merged by Zabe:

[mediawiki/vendor@REL1_37] Bump wikimedia/parsoid to v0.14.2

https://gerrit.wikimedia.org/r/832364

Change 832365 merged by jenkins-bot:

[mediawiki/core@REL1_37] Bump wikimedia/parsoid to v0.14.2

https://gerrit.wikimedia.org/r/832365

Change 832358 merged by jenkins-bot:

[mediawiki/core@REL1_35] Bump wikimedia/parsoid to v0.12.3

https://gerrit.wikimedia.org/r/832358