Page MenuHomePhabricator
Create Task
Maniphest T313172

Block images are left aligned in mobile VE
Closed, ResolvedPublic
Actions

Description

Oh mobile, block images are centred, but when editing they appear left aligned.

Details

SubjectRepoBranchLines +/-
Fix CSS selectors for Parsoid imagesmediawiki/skins/MinervaNeuemaster+23 -7
Add support for mw:Filemediawiki/extensions/ContentTranslationmaster+4 -0
Customize query in gerrit

Related Objects

Event Timeline

Esanders created this task.Jul 16 2022, 10:53 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 16 2022, 10:53 PM
Esanders added a project: Regression.Jul 17 2022, 8:33 AM
Esanders added a subscriber: Arlolra.Jul 18 2022, 1:29 PM

Caused by T273505.

CC @Arlolra there may be some other places that need fixing:

https://codesearch.wmcloud.org/search/?q=%5C%5B.%2Bmw%3AImage.%2B%5C%5D&i=nope&files=&excludeFiles=&repos=

gerritbot added a comment.Jul 18 2022, 1:32 PM

Change 814811 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/skins/MinervaNeue@master] Fix CSS selectors for Parsoid images

https://gerrit.wikimedia.org/r/814811

gerritbot added a project: Patch-For-Review.Jul 18 2022, 1:32 PM
Arlolra added a comment.Jul 18 2022, 4:33 PM

CC @Arlolra there may be some other places that need fixing:

Ugh, thanks, I will address them

• ppelberg moved this task from To Triage to Triaged on the VisualEditor board.Jul 18 2022, 4:56 PM
matmarex added a project: Editing-team (Kanban Board).Jul 18 2022, 5:03 PM
matmarex moved this task from Incoming to Code Review on the Editing-team (Kanban Board) board.
gerritbot added a comment.Jul 18 2022, 5:44 PM

Change 814864 had a related patch set uploaded (by Arlolra; author: Arlolra):

[mediawiki/extensions/ContentTranslation@master] Add support for mw:File

https://gerrit.wikimedia.org/r/814864

Arlolra added a comment.Jul 18 2022, 6:42 PM

https://github.com/femiwiki/FemiwikiSkin/pull/570

gerritbot added a comment.Jul 19 2022, 4:38 AM

Change 814864 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] Add support for mw:File

https://gerrit.wikimedia.org/r/814864

Esanders claimed this task.Jul 20 2022, 12:25 PM
Esanders moved this task from Code Review to QA on the Editing-team (Kanban Board) board.
gerritbot added a comment.Jul 26 2022, 2:07 AM

Change 814811 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@master] Fix CSS selectors for Parsoid images

https://gerrit.wikimedia.org/r/814811

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.23; 2022-08-01).Jul 26 2022, 3:00 AM
matmarex added a project: Editing QA.Aug 5 2022, 10:37 PM
EAkinloose edited projects, added Verified; removed Editing QA.Aug 9 2022, 2:02 PM
EAkinloose moved this task from QA to Ready for Sign Off on the Editing-team (Kanban Board) board.
• ppelberg closed this task as Resolved.Aug 13 2022, 12:04 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL