Page MenuHomePhabricator

Merge mw:Image|mw:Audio|mw:Video into a single mw:File
Closed, ResolvedPublic

Description

The distinction is already made by the nested <img|audio|video> tags, so there doesn't seem to be a loss of information

This should help simplify the css in content.media.less and probably be helpful for T270150

Note that there's already an mw:MediaLink type for linking to, instead of rendering, media (ex, [[Media:Foo.jpg]])

A migration plan for clients is needed ... similar to T266143

Details

ProjectBranchLines +/-Subject
mediawiki/vendormaster+851 -828
mediawiki/services/parsoidmaster+14 -14
mediawiki/services/parsoidmaster+679 -694
mediawiki/extensions/VisualEditormaster+79 -47
operations/deployment-chartsmaster+1 -1
operations/deployment-chartsmaster+29 -5
mediawiki/services/mobileappsmaster+294 -291
mediawiki/services/mobileappsmaster+36 -20
mediawiki/services/cxservermaster+15 -16
mediawiki/services/cxservermaster+17 -4
mediawiki/vendormaster+1 K -633
mediawiki/extensions/GrowthExperimentsmaster+3 -3
mediawiki/extensions/Flowmaster+16 -16
mediawiki/extensions/Flowmaster+29 -8
mediawiki/coremaster+276 -301
mediawiki/extensions/ImageMapmaster+10 -10
mediawiki/extensions/TimedMediaHandlermaster+8 -8
mediawiki/coremaster+27 -2
mediawiki/extensions/MultimediaViewermaster+16 -2
mediawiki/services/parsoidmaster+20 -4
mediawiki/extensions/TimedMediaHandlermaster+4 -4
mediawiki/extensions/ImageMapmaster+5 -5
mediawiki/services/parsoidmain+23 -30
Show related patches Customize query in gerrit

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
Arlolra triaged this task as Medium priority.Feb 1 2021, 5:34 PM
Arlolra moved this task from Needs Triage to Media Structure on the Parsoid board.
Arlolra updated the task description. (Show Details)

Change 683428 had a related patch set uploaded (by Arlolra; author: Arlolra):

[mediawiki/services/parsoid@main] [WIP] Consolidate media types to mw:Media

https://gerrit.wikimedia.org/r/683428

Change 683428 abandoned by Arlolra:

[mediawiki/services/parsoid@main] [WIP] Consolidate media types to mw:Media

Reason:

https://gerrit.wikimedia.org/r/683428

Change 683993 had a related patch set uploaded (by Arlolra; author: Arlolra):

[mediawiki/services/parsoid@master] [WIP] Consolidate media types to mw:Media

https://gerrit.wikimedia.org/r/683993

Arlolra renamed this task from Merge mw:Image|mw:Audio|mw:Video into a single mw:Media to Merge mw:Image|mw:Audio|mw:Video into a single mw:File.May 19 2022, 4:55 PM

Change 793535 had a related patch set uploaded (by Arlolra; author: Arlolra):

[mediawiki/services/parsoid@master] Add forward compatibility to serialize mw:File

https://gerrit.wikimedia.org/r/793535

Change 793536 had a related patch set uploaded (by Arlolra; author: Arlolra):

[mediawiki/core@master] Add mw:File to media styles

https://gerrit.wikimedia.org/r/793536

Change 793541 had a related patch set uploaded (by Arlolra; author: Arlolra):

[mediawiki/extensions/ImageMap@master] Disable tests to avoid circular dependency

https://gerrit.wikimedia.org/r/793541

Change 793543 had a related patch set uploaded (by Arlolra; author: Arlolra):

[mediawiki/extensions/TimedMediaHandler@master] Disable tests to avoid circular dependency

https://gerrit.wikimedia.org/r/793543

Change 793545 had a related patch set uploaded (by Arlolra; author: Arlolra):

[mediawiki/core@master] Emit mw:File typeof for media

https://gerrit.wikimedia.org/r/793545

Change 793546 had a related patch set uploaded (by Arlolra; author: Arlolra):

[mediawiki/extensions/ImageMap@master] Update typeofs to mw:File

https://gerrit.wikimedia.org/r/793546

Change 793552 had a related patch set uploaded (by Arlolra; author: Arlolra):

[mediawiki/extensions/MultimediaViewer@master] Support mw:File as well as mw:Image

https://gerrit.wikimedia.org/r/793552

I complained to Arlo about this a few weeks ago, +1 from me!

Change 793541 merged by jenkins-bot:

[mediawiki/extensions/ImageMap@master] Disable tests to avoid circular dependency

https://gerrit.wikimedia.org/r/793541

Change 793543 merged by jenkins-bot:

[mediawiki/extensions/TimedMediaHandler@master] Disable tests to avoid circular dependency

https://gerrit.wikimedia.org/r/793543

Arlolra updated the task description. (Show Details)

Change 793535 merged by jenkins-bot:

[mediawiki/services/parsoid@master] Add forward compatibility to serialize mw:File

https://gerrit.wikimedia.org/r/793535

Change 793560 had a related patch set uploaded (by Arlolra; author: Arlolra):

[mediawiki/services/mobileapps@master] [WIP] Add support for mw:File as well as mw:Image, et al.

https://gerrit.wikimedia.org/r/793560

Change 793854 had a related patch set uploaded (by Arlolra; author: Arlolra):

[mediawiki/extensions/Flow@master] [WIP] Add support for mw:File as well as mw:Image, et al.

https://gerrit.wikimedia.org/r/793854

Change 799426 had a related patch set uploaded (by Arlolra; author: Arlolra):

[mediawiki/services/mobileapps@master] Update tests with mw:File type

https://gerrit.wikimedia.org/r/799426

Change 800238 had a related patch set uploaded (by Arlolra; author: Arlolra):

[mediawiki/services/parsoid@master] Bump output content version to 2.5.0

https://gerrit.wikimedia.org/r/800238

Change 800243 had a related patch set uploaded (by Arlolra; author: Arlolra):

[mediawiki/extensions/Flow@master] Update tests with mw:File type

https://gerrit.wikimedia.org/r/800243

Change 793552 merged by jenkins-bot:

[mediawiki/extensions/MultimediaViewer@master] Support mw:File as well as mw:Image

https://gerrit.wikimedia.org/r/793552

Change 800269 had a related patch set uploaded (by Arlolra; author: Arlolra):

[mediawiki/services/cxserver@master] [WIP] Add support for mw:File as well as mw:Image, et al.

https://gerrit.wikimedia.org/r/800269

Change 800330 had a related patch set uploaded (by Gergő Tisza; author: Gergő Tisza):

[mediawiki/extensions/GrowthExperiments@master] Update comments for Parsoid type name change

https://gerrit.wikimedia.org/r/800330

Change 793536 merged by jenkins-bot:

[mediawiki/core@master] Add mw:File to media styles

https://gerrit.wikimedia.org/r/793536

Change 793547 had a related patch set uploaded (by Jforrester; author: Arlolra):

[mediawiki/extensions/TimedMediaHandler@master] Update typeofs to mw:File

https://gerrit.wikimedia.org/r/793547

Change 793545 merged by jenkins-bot:

[mediawiki/core@master] Emit mw:File typeof for media

https://gerrit.wikimedia.org/r/793545

Change 793546 merged by jenkins-bot:

[mediawiki/extensions/ImageMap@master] Update typeofs to mw:File

https://gerrit.wikimedia.org/r/793546

Change 793547 merged by jenkins-bot:

[mediawiki/extensions/TimedMediaHandler@master] Update typeofs to mw:File

https://gerrit.wikimedia.org/r/793547

Change 793854 merged by jenkins-bot:

[mediawiki/extensions/Flow@master] Add support for mw:File as well as mw:Image, et al.

https://gerrit.wikimedia.org/r/793854

Change 800243 merged by jenkins-bot:

[mediawiki/extensions/Flow@master] Update tests with mw:File type

https://gerrit.wikimedia.org/r/800243

Change 800808 had a related patch set uploaded (by Arlolra; author: Arlolra):

[mediawiki/services/cxserver@master] Update tests with mw:File type

https://gerrit.wikimedia.org/r/800808

Change 800330 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Update comments for Parsoid type name change

https://gerrit.wikimedia.org/r/800330

Change 801428 had a related patch set uploaded (by Arlolra; author: Arlolra):

[mediawiki/vendor@master] Bump parsoid to 0.16.0-a10

https://gerrit.wikimedia.org/r/801428

Change 801428 merged by jenkins-bot:

[mediawiki/vendor@master] Bump parsoid to 0.16.0-a10

https://gerrit.wikimedia.org/r/801428

Change 801441 had a related patch set uploaded (by Arlolra; author: Arlolra):

[mediawiki/extensions/VisualEditor@master] [WIP] Support mw:File typeof

https://gerrit.wikimedia.org/r/801441

Change 800269 merged by jenkins-bot:

[mediawiki/services/cxserver@master] Add support for mw:File as well as mw:Image, et al.

https://gerrit.wikimedia.org/r/800269

Change 800808 merged by jenkins-bot:

[mediawiki/services/cxserver@master] Update tests with mw:File type

https://gerrit.wikimedia.org/r/800808

Change 801663 had a related patch set uploaded (by KartikMistry; author: KartikMistry):

[operations/deployment-charts@master] Update cxserver to 2022-05-31-111430-production

https://gerrit.wikimedia.org/r/801663

Change 793560 merged by jenkins-bot:

[mediawiki/services/mobileapps@master] Add support for mw:File as well as mw:Image, et al.

https://gerrit.wikimedia.org/r/793560

Change 799426 merged by jenkins-bot:

[mediawiki/services/mobileapps@master] Update tests with mw:File type

https://gerrit.wikimedia.org/r/799426

Change 801663 merged by jenkins-bot:

[operations/deployment-charts@master] Update cxserver to 2022-05-31-123738-production

https://gerrit.wikimedia.org/r/801663

Change 803869 had a related patch set uploaded (by KartikMistry; author: KartikMistry):

[operations/deployment-charts@master] Update cxserver to 2022-05-31-045829-production

https://gerrit.wikimedia.org/r/803869

Change 803869 merged by jenkins-bot:

[operations/deployment-charts@master] Update cxserver to 2022-05-31-045829-production

https://gerrit.wikimedia.org/r/803869

Change 801441 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Support the upcoming mw:File typeof

https://gerrit.wikimedia.org/r/801441

Re: Tech News - What wording would you suggest as the content? (I can't quite understand the result of this task just from reading the Description, and whether there are any actions-required from Tech News readers).
And when should it be included? (next Monday's edition needs to be finalized within ~24 hours)
Thanks!

What wording would you suggest as the content?

Something like,

Clients making use of Parsoid's HTML output should be aware that in an upcoming version (2.5.0), media will no longer be annotate with a "typeof" that depends on the type being rendered ("mw:Image", "mw:Video", "mw:Audio"), but will instead all get a consistent "mw:File" for all types.  This matches the wikitext syntax for media, `[[File:Test.jpg]]`.  Link to the spec, https://www.mediawiki.org/wiki/Specs/HTML/2.5.0

And when should it be included?

This will hopefully get deployed in the next few weeks. So, an early a heads up as possible will be best.

IIUC, that means that normal editors don't need to worry about this, but it might (?) affect bot-operators, and/or tool authors, and/or API users. Those affected users will need to check that their code doesn't invoke these now-retired options.

Generally, we try to keep the Tech News entries fairly simple English, with links to suitable locations for in-depth details.
I would suggest something like this for a Tech News entry:

Parsoid's HTML output will soon stop annotating media file links with a custom typeof statement, and instead use mw:File for all types. Tool authors should remove any code that expects types for: mw:Image, mw:Audio, or mw:Video. [ 1 ]

and then you could place any more detailed notes/instructions above in this task's Description.
Does that seem reasonable, and is that draft accurate (or improvable!)?

How about,

Parsoid's HTML output will soon stop annotating file links with different typeof attribute values, and instead use mw:File for all types. Tool authors should adjust any code that expects: mw:Image, mw:Audio, or mw:Video. [ 1 ]

Change 683993 merged by jenkins-bot:

[mediawiki/services/parsoid@master] Consolidate media types to mw:File

https://gerrit.wikimedia.org/r/683993

Change 800238 merged by jenkins-bot:

[mediawiki/services/parsoid@master] Bump output content version to 2.5.0

https://gerrit.wikimedia.org/r/800238

Change 808051 had a related patch set uploaded (by Arlolra; author: Arlolra):

[mediawiki/vendor@master] Bump parsoid to 0.16.0-a14

https://gerrit.wikimedia.org/r/808051

Change 808051 merged by jenkins-bot:

[mediawiki/vendor@master] Bump parsoid to 0.16.0-a14

https://gerrit.wikimedia.org/r/808051