Maniphest T311916

"Add an image" structured edits add a blank line instead of an image
Closed, ResolvedPublic
Actions

Description

Hello,

it was reported by David V. at Czech Wikipedia that several edits tagged as "Add an image" edits actually do not add any image (instead, they only add a blank line).

This appears to affect all add an image edits made since 2022-06-23 (see RecentChanges). The bug appears to affect arwiki, bnwiki, cswiki and eswiki at least. I did not check any other Growth projects. Considering the number of affected users and projects, this is very likely a bug.

Examples (one per wiki, more can be found in the RecentChanges links above):

Filling directly in sprint, as this seems to be a high-priority issue.

Details

Subject	Repo	Branch	Lines +/-
AddImage: Throw an error if File reference isn't found in new wikitext	mediawiki/extensions/GrowthExperiments	master	+125 -20
AddImageArticleTarget: Update to new mediaClass/mediaTag format	mediawiki/extensions/GrowthExperiments	wmf/1.39.0-wmf.18	+2 -1
AddImageArticleTarget: Update to new mediaClass/mediaTag format	mediawiki/extensions/GrowthExperiments	master	+2 -1

Customize query in gerrit

Related Objects

Mentioned In: T311995: selenium: Add Link tests should verify that content is added to page
Mentioned Here: T311995: selenium: Add Link tests should verify that content is added to page
T273505: Merge mw:Image|mw:Audio|mw:Video into a single mw:File
rEVED0533f49fd574: Support the upcoming mw:File typeof

Event Timeline

Urbanecm_WMF created this task.Jul 2 2022, 2:10 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 2 2022, 2:10 PM

Urbanecm_WMF renamed this task from "Add an image" structured edits made by Czech Wikipedia users do not add any image to "Add an image" structured edits add a blank line instead of an image.Jul 2 2022, 2:11 PM

Urbanecm_WMF triaged this task as High priority.

MdsShakil subscribed.Jul 2 2022, 3:06 PM

It appears that rEVED0533f49fd574: Support the upcoming mw:File typeof for T273505: Merge mw:Image|mw:Audio|mw:Video into a single mw:File caused this breakage. (According to git bisect anyway.) We had previously merged a patch to update some code comments for our patch, but that was before 0533f49fd5741d145141d97f4dbf4979cd075287 was merged, so no one noticed the breakage until now.

In T311916#8046297, @kostajh wrote:

It appears that rEVED0533f49fd574: Support the upcoming mw:File typeof for T273505: Merge mw:Image|mw:Audio|mw:Video into a single mw:File caused this breakage. (According to git bisect anyway.) We had previously merged a patch to update some code comments for our patch, but that was before 0533f49fd5741d145141d97f4dbf4979cd075287 was merged, so no one noticed the breakage until now.

In the interim, I disabled the image-recommendation task type on all of our participating wikis, as the feature is completely broken and creates a maintenance burden and unpleasant experience for newcomers and experienced editors alike. For users in the image recommendation experiment, it means their task type filters are reset to an empty state. Assuming they interact with their filters, after we fix the bug and re-enable the task type, those users won't have image recommendation task type enabled any longer. cc @nettrom_WMF about the experiment implications of that (sorry!).

kostajh added a project: Regression.Jul 2 2022, 3:26 PM

Change 810467 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[mediawiki/extensions/GrowthExperiments@master] AddImageArticleTarget: Update to new mediaClass/mediaTag format

https://gerrit.wikimedia.org/r/810467

gerritbot added a project: Patch-For-Review.Jul 2 2022, 3:32 PM

Change 810467 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] AddImageArticleTarget: Update to new mediaClass/mediaTag format

https://gerrit.wikimedia.org/r/810467

Maintenance_bot removed a project: Patch-For-Review.Jul 2 2022, 6:30 PM

Change 810509 had a related patch set uploaded (by Urbanecm; author: Kosta Harlan):

[mediawiki/extensions/GrowthExperiments@wmf/1.39.0-wmf.18] AddImageArticleTarget: Update to new mediaClass/mediaTag format

https://gerrit.wikimedia.org/r/810509

gerritbot added a project: Patch-For-Review.Jul 2 2022, 6:33 PM

Change 810485 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[mediawiki/extensions/GrowthExperiments@master] [WIP] AddImage: Throw an error if mw:File isn't found in wikitext

https://gerrit.wikimedia.org/r/810485

KStoller-WMF assigned this task to kostajh.Jul 3 2022, 5:50 PM

KStoller-WMF subscribed.

kostajh mentioned this in T311995: selenium: Add Link tests should verify that content is added to page.Jul 4 2022, 10:16 AM

Change 810509 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@wmf/1.39.0-wmf.18] AddImageArticleTarget: Update to new mediaClass/mediaTag format

https://gerrit.wikimedia.org/r/810509

Mentioned in SAL (#wikimedia-operations) [2022-07-04T11:50:03Z] <ladsgroup@deploy1002> Synchronized php-1.39.0-wmf.18/extensions/GrowthExperiments/modules/ext.growthExperiments.StructuredTask/addimage/AddImageArticleTarget.js: Backport: [[gerrit:810509|AddImageArticleTarget: Update to new mediaClass/mediaTag format (T311916)]] (duration: 03m 33s)

CBogen moved this task from To Do to Growth: Add an Image on the Image-Suggestions board.Jul 7 2022, 6:36 PM

I think no more work is needed here (the WIP patch is covered by T311995). Please undo the move if I misunderstood.

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.21; 2022-07-18).Jul 12 2022, 12:02 AM

ReleaseTaggerBot edited projects, added MW-1.39-notes (1.39.0-wmf.18; 2022-06-27); removed MW-1.39-notes (1.39.0-wmf.21; 2022-07-18).Jul 12 2022, 1:01 AM

Etonkovidova closed this task as Resolved.Jul 19 2022, 12:47 AM

Change 810485 abandoned by Kosta Harlan:

[mediawiki/extensions/GrowthExperiments@master] AddImage: Throw an error if File reference isn't found in new wikitext

Reason: