Report says FlaggedRevs currently have whopping ~7000 drifts in 32 categories: https://drift-tracker.toolforge.org/report/flaggedrevs/ (Raw data: P31383)
Description
Status | Subtype | Assigned | Task | ||
---|---|---|---|---|---|
Open | None | T313251 Collect and fix schema drifts of wmf-deployed extension tables in production | |||
Resolved | Ladsgroup | T313253 Fix Flaggedrevs database schema drifts in production | |||
Resolved | Ladsgroup | T318950 Fix renamed indexes of flaggedrevs table in production | |||
Resolved | Ladsgroup | T318955 Drop fr_comment and fr_text from flaggedrevs table in production | |||
Resolved | Ladsgroup | T318959 Add fr_user index on flaggedrevs in production | |||
Resolved | Ladsgroup | T322618 Fix renamed indexes of flaggedrevs_tracking table in production | |||
Resolved | Ladsgroup | T323214 Fix unsigned drifts in flaggedrevs caused by 4c0b3c7b9b0 | |||
Resolved | Ladsgroup | T323827 Finish timestamp schema changes in flaggedrevs | |||
Resolved | Ladsgroup | T323907 Make fr_user unsigned | |||
Resolved | Ladsgroup | T333918 Switchover s2 master (db1162 -> db1122) | |||
Resolved | Ladsgroup | T251191 FlaggedRevs has lots of database drifts but only in s1 and s5 |
Event Timeline
- The index differences are renames, which seems not done in production - https://gerrit.wikimedia.org/r/c/mediawiki/extensions/FlaggedRevs/+/110451
- New index was added in - https://gerrit.wikimedia.org/r/c/mediawiki/extensions/FlaggedRevs/+/369460
- Unsigned patch set - https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/extensions/FlaggedRevs/+/4c0b3c7b9b09643d2e6abc154379acfd4c97be1a%5E%21/
- Unsigned patch set, the second - https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/extensions/FlaggedRevs/+/4b24bf8f19bc6a89a005021e0209f2f5df80d76f%5E%21/
- Nullability patch set - https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/extensions/FlaggedRevs/+/82bbd1d4c87a6911d38a20e13220de575a0bd9e9%5E%21/#F0
- Outstanding field type schema changes:
- The primary key mismatch needs to be done in codebase - T312267
- Extra fields were dropped in https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/extensions/FlaggedRevs/+/1bbd5fa1cd681ee0221e45945234476826f142ed%5E%21/#F4
Old extension, some schema drifts only on one of the first flagged wikis (like dewiki)
There could be some overlays with T251191: FlaggedRevs has lots of database drifts but only in s1 and s5
Should this task get Schema-change-in-production or better to create new sub tasks for better tracking? But I am not sure how small the tasks could be. One issue on a table in one task? All issues per table in one task?
I suggest creating subtickets and grouping them based on type. e.g. I saw a lot of rename index issues, we can probably just group them together. Basically one ticket per patch that caused it.
I still suggest waiting a bit before creating tickets though. Our backlog is quite full for this Q.
@Ladsgroup - In case it helps, we have finished all of the outstanding check-storage ticket in the clouddb servers. If you have scripts that couldn't complete on those servers, feel free to try again.
Only these two left:
{ "_metadata": { "time_end": 1680182552.852061, "time_start": 1680181902.3546872 }, "flaggedrevs fr_user field-unsigned-mismatch": { "s2": [ "db1162:eowiki", "db1162:plwiki" ] } }