Page MenuHomePhabricator

Do not pre-populate ping when replying to a comment from a user on their own talk page
Closed, ResolvedPublicFeature

Description

Feature summary (what you would like to be able to do and where):
As an Android app user commenting on someone's talk page, I do not want the ping should not pre-populate, so it doesn't create the redundancy of a notification that would already be sent since it is that users talk page

Use case(s) (list the steps that you performed to discover that problem, and describe the actual underlying problem which you want to solve. Do not describe only a solution):
When replying to someone on a talk page, you automatically ping them. I like this feature a lot but it's redudant when it pings someone on their own talk page.

Benefits (why should this be implemented?):
Limit redundancy

Event Timeline

This change broke being able to ping people that have a space.

See the production (2022-08-08) vs new Beta version (2022-08-29)

Screenshot_20220906-095316.png (2×1 px, 153 KB)

Screenshot_20220906-095438.png (2×1 px, 141 KB)

I tried to ping Dmitry's test account and the signature broke in Beta but it isn't doing it in production, which leads me to believe this change is what has caused it. This is problematic because Dmitry wouldn't get a notification and when I @ reply to someone the formatting is messed up.

This change broke being able to ping people that have a space.

Screenshot_20220906-095316.png (2×1 px, 153 KB)

I can't reproduce that, and can't imagine how this change would cause that to happen. Can you try one more time?

Actually I did it again in Beta and Production and you are right this isn't cause by this code change, I will file a new task for it. What causes it is if you hit enter after tagging someone.