Page MenuHomePhabricator
Create Task
Maniphest T315547

Add an auto-refresh mechanism to the nearby feature
Closed, ResolvedPublic
Actions

Description

For the MVP we'll add a simple auto-refresh that refreshes the relevant markers on move and zoom.

Possible optimizations:

  • Don't refresh when moving but always add new points ( until some limit ).
  • Don't refresh every zoom level, when the scale does not increase much ( e.g. in the very narrow zoom levels especially when zooming in ).

Details

SubjectRepoBranchLines +/-
Render markers from the article's GeoJSON always on topmediawiki/extensions/Kartographermaster+3 -1
Turn global state variable into a function argumentmediawiki/extensions/Kartographermaster+8 -9
Drop foreign nearby layers earliermediawiki/extensions/Kartographermaster+13 -4
Drop nearby data that's too far away from the current zoom levelmediawiki/extensions/Kartographermaster+38 -19
Fix nearby articles auto-refresh feature not being turned offmediawiki/extensions/Kartographermaster+4 -7
Filter nearby points to not hide user-provided pointsmediawiki/extensions/Kartographermaster+92 -66
Use more memory efficient hash functionmediawiki/extensions/Kartographermaster+10 -2
Don't add duplicate points to the nearby layermediawiki/extensions/Kartographermaster+29 -7
Merge all incoming nearby datamediawiki/extensions/Kartographermaster+7 -5
Customize query in gerrit

Related Objects
Search...

Event Timeline

WMDE-Fisch created this task.Aug 18 2022, 11:31 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 18 2022, 11:31 AM
WMDE-Fisch moved this task from Sprint Backlog to Doing on the WMDE-TechWish-Sprint-2022-08-17 board.Aug 18 2022, 11:32 AM
WMDE-Fisch moved this task from Doing to Sprint Backlog on the WMDE-TechWish-Sprint-2022-08-17 board.
gerritbot added a comment.Aug 19 2022, 6:53 AM

Change 823166 had a related patch set uploaded (by WMDE-Fisch; author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/Kartographer@master] Merge all incoming nearby data

https://gerrit.wikimedia.org/r/823166

gerritbot added a project: Patch-For-Review.Aug 19 2022, 6:53 AM

Change 823174 had a related patch set uploaded (by WMDE-Fisch; author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/Kartographer@master] Don't add duplicate points to the nearby layer

https://gerrit.wikimedia.org/r/823174

gerritbot added a comment.Aug 19 2022, 6:54 AM

Change 823179 had a related patch set uploaded (by WMDE-Fisch; author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/Kartographer@master] [POC] Use more memory efficient hash function

https://gerrit.wikimedia.org/r/823179

WMDE-Fisch moved this task from Sprint Backlog to UX/PM Review on the WMDE-TechWish-Sprint-2022-08-17 board.Aug 19 2022, 8:21 AM

Looking at the MVP in action it would feel nicer to actually add points instead of always replacing. At least when moving around. Otherwise the screen kind of "flickers" when a new set is loaded and replaces the old set with points vanishing. Lets look at this together.

gerritbot added a comment.Aug 19 2022, 2:12 PM

Change 823166 merged by jenkins-bot:

[mediawiki/extensions/Kartographer@master] Merge all incoming nearby data

https://gerrit.wikimedia.org/r/823166

gerritbot added a comment.Aug 19 2022, 2:40 PM

Change 824750 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/Kartographer@master] [POC] Refresh nearby articles via button instead of automatically

https://gerrit.wikimedia.org/r/824750

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.26; 2022-08-22).Aug 19 2022, 3:00 PM
ECohen_WMDE mentioned this in T304076: Nearby feature for maps.Aug 23 2022, 6:58 AM
gerritbot added a comment.Aug 23 2022, 9:30 AM

Change 823174 merged by jenkins-bot:

[mediawiki/extensions/Kartographer@master] Don't add duplicate points to the nearby layer

https://gerrit.wikimedia.org/r/823174

ReleaseTaggerBot edited projects, added MW-1.39-notes (1.39.0-wmf.27; 2022-08-29); removed MW-1.39-notes (1.39.0-wmf.26; 2022-08-22).Aug 23 2022, 10:00 AM
gerritbot added a comment.Aug 23 2022, 10:24 AM

Change 823179 merged by jenkins-bot:

[mediawiki/extensions/Kartographer@master] Use more memory efficient hash function

https://gerrit.wikimedia.org/r/823179

lilients_WMDE moved this task from Backlog to In sprint on the WMDE-GeoInfo-FocusArea board.Aug 23 2022, 1:34 PM
gerritbot added a comment.Aug 26 2022, 9:03 AM

Change 826799 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/Kartographer@master] Filter nearby points to not hide user-provided points

https://gerrit.wikimedia.org/r/826799

gerritbot added a comment.Aug 26 2022, 12:17 PM

Change 826837 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/Kartographer@master] Drop nearby data that's too far away from the current zoom level

https://gerrit.wikimedia.org/r/826837

gerritbot added a comment.Aug 29 2022, 12:26 PM

Change 826799 merged by jenkins-bot:

[mediawiki/extensions/Kartographer@master] Filter nearby points to not hide user-provided points

https://gerrit.wikimedia.org/r/826799

WMDE-Fisch closed subtask T315673: Add test articles to the beta cluster as Resolved.Aug 30 2022, 8:17 AM
ECohen_WMDE subscribed.Aug 30 2022, 8:38 AM

Confirmed in sprint review that the general direction is good. Not reviewed is how the points disappear when zooming out and they become too dense, since this still needs to be merged.

For now, this can move out of the PM/UX review column

WMDE-Fisch moved this task from UX/PM Review to Tech Review on the WMDE-TechWish-Sprint-2022-08-17 board.Aug 30 2022, 9:28 AM
gerritbot added a comment.Aug 30 2022, 1:39 PM

Change 828012 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/Kartographer@master] Fix nearby articles auto-refresh feature not being turned off

https://gerrit.wikimedia.org/r/828012

Lena_WMDE added a project: WMDE-TechWish-Sprint-2022-08-31.Aug 31 2022, 11:11 AM
awight moved this task from Sprint Backlog to Tech Review on the WMDE-TechWish-Sprint-2022-08-31 board.Aug 31 2022, 11:11 AM
gerritbot added a comment.Aug 31 2022, 2:43 PM

Change 828548 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/Kartographer@master] Render markers from the article's GeoJSON always on top

https://gerrit.wikimedia.org/r/828548

Lena_WMDE added a parent task: T316782: Deploy Show Nearby feature to small group of wikis.Aug 31 2022, 3:35 PM
gerritbot added a comment.Sep 1 2022, 2:46 PM

Change 828012 merged by jenkins-bot:

[mediawiki/extensions/Kartographer@master] Fix nearby articles auto-refresh feature not being turned off

https://gerrit.wikimedia.org/r/828012

ReleaseTaggerBot edited projects, added MW-1.39-notes (1.39.0-wmf.28; 2022-09-05); removed MW-1.39-notes (1.39.0-wmf.27; 2022-08-29).Sep 1 2022, 3:00 PM
awight moved this task from Tech Review to Demo on the WMDE-TechWish-Sprint-2022-08-31 board.Sep 9 2022, 12:42 PM
awight subscribed.

Let's close this task (the requested feature works), and open follow-ups for discussing further optimization.

gerritbot added a comment.Sep 9 2022, 2:00 PM

Change 826837 merged by jenkins-bot:

[mediawiki/extensions/Kartographer@master] Drop nearby data that's too far away from the current zoom level

https://gerrit.wikimedia.org/r/826837

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.1; 2022-09-12).Sep 9 2022, 3:00 PM
gerritbot added a comment.Sep 9 2022, 3:59 PM

Change 831119 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/Kartographer@master] Drop foreign nearby layers earlier

https://gerrit.wikimedia.org/r/831119

gerritbot added a comment.Sep 9 2022, 4:04 PM

Change 831121 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/Kartographer@master] Turn global state variable into a function argument

https://gerrit.wikimedia.org/r/831121

gerritbot added a comment.Sep 12 2022, 9:30 AM

Change 831119 merged by jenkins-bot:

[mediawiki/extensions/Kartographer@master] Drop foreign nearby layers earlier

https://gerrit.wikimedia.org/r/831119

gerritbot added a comment.Sep 14 2022, 7:30 AM

Change 831121 merged by jenkins-bot:

[mediawiki/extensions/Kartographer@master] Turn global state variable into a function argument

https://gerrit.wikimedia.org/r/831121

ReleaseTaggerBot edited projects, added MW-1.40-notes (1.40.0-wmf.2; 2022-09-19); removed MW-1.40-notes (1.40.0-wmf.1; 2022-09-12).Sep 14 2022, 8:00 AM
thiemowmde closed this task as Resolved.Sep 14 2022, 1:24 PM
thiemowmde mentioned this in T317859: Test performance of nearby feature on low-end devices.Sep 15 2022, 9:54 AM
thiemowmde added a parent task: T317859: Test performance of nearby feature on low-end devices.
gerritbot added a comment.Nov 17 2022, 7:18 PM

Change 824750 abandoned by Thiemo Kreuz (WMDE):

[mediawiki/extensions/Kartographer@master] [POC] Refresh nearby articles via button instead of automatically

Reason:

https://gerrit.wikimedia.org/r/824750

gerritbot added a comment.Dec 7 2022, 5:17 PM

Change 828548 abandoned by Thiemo Kreuz (WMDE):

[mediawiki/extensions/Kartographer@master] Render markers from the article's GeoJSON always on top

Reason:

https://gerrit.wikimedia.org/r/828548

gerritbot added a comment.Jan 25 2023, 4:13 PM

Change 824750 restored by Svantje Lilienthal:

[mediawiki/extensions/Kartographer@master] [POC] Refresh nearby articles via button instead of automatically

https://gerrit.wikimedia.org/r/824750

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL