Page MenuHomePhabricator
Create Task
Maniphest T315556

Update language button empty state label in sticky header
Closed, ResolvedPublic3 Estimated Story Points
Actions

Assigned To
ovasileva
Authored By
ovasileva
Aug 18 2022, 1:22 PM
Tags
Referenced Files
F35518125: Screen Shot 2022-09-12 at 9.56.18 AM.png
Sep 12 2022, 4:58 PM
F35518124: Screen Shot 2022-09-12 at 9.56.25 AM.png
Sep 12 2022, 4:58 PM
F35513752: Screen Shot 2022-09-08 at 2.50.18 PM.png
Sep 8 2022, 6:51 PM
F35513660: Screen Shot 2022-09-06 at 2.30.40 PM.png
Sep 8 2022, 4:35 PM
F35473612: Screen Shot 2022-08-18 at 10.26.40 AM.png
Aug 18 2022, 2:30 PM
F35473609: Screen Shot 2022-08-18 at 10.26.29 AM.png
Aug 18 2022, 2:30 PM
F35472624: Screen Shot 2022-08-18 at 3.26.35 PM.png
Aug 18 2022, 1:26 PM
F35472606: Screen Shot 2022-08-18 at 3.25.52 PM.png
Aug 18 2022, 1:26 PM
Subscribers
Aklapper
• alexhollender_WMF
bwang
Edtadros
Jdlrobson
Jdrewniak
ovasileva
Pginer-WMF

Description

Background

If there are no other languages available for an article the language button label is Add languages. However the language button in the sticky header has 0 languages as a label (which is incorrect, it should be Add languages). These two labels should match (but the color of the button does not need to match).

page headersticky header
Screen Shot 2022-08-18 at 10.26.29 AM.png (994×3 px, 1 MB)
Screen Shot 2022-08-18 at 10.26.40 AM.png (986×3 px, 297 KB)

Acceptance criteria

  • Change the copy of the language button within the sticky header from "0 languages" to "Add languages"

QA Results - Beta

ACStatusDetails
1✅T315556#8222312

QA Results - Prod

ACStatusDetails
1✅T315556#8229645

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Change ULS label for sticky header when 0 Languages available.mediawiki/skins/Vectormaster+20 -17
Customize query in gerrit

Event Timeline

ovasileva created this task.Aug 18 2022, 1:22 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 18 2022, 1:22 PM
ovasileva triaged this task as Medium priority.Aug 18 2022, 1:22 PM
ovasileva added a comment.Aug 18 2022, 1:26 PM

Add language button at the top of the page

Screen Shot 2022-08-18 at 3.25.52 PM.png (484×596 px, 52 KB)

Reeads "0" languages in the sticky header

Screen Shot 2022-08-18 at 3.26.35 PM.png (418×503 px, 31 KB)

ovasileva updated the task description. (Show Details)Aug 18 2022, 1:31 PM
• alexhollender_WMF renamed this task from Add "add language" button to sticky header to Update language button empty state label in sticky header.Aug 18 2022, 2:30 PM
• alexhollender_WMF updated the task description. (Show Details)
ovasileva edited projects, added Web-Team-Backlog-Archived (Kanbanana-2022-23-Q1); removed Web-Team-Backlog-Archived.Aug 22 2022, 12:30 PM
Jdlrobson moved this task from Needs Analysis to Upcoming on the Web-Team-Backlog-Archived (Kanbanana-2022-23-Q1) board.Aug 22 2022, 8:35 PM

The message to change is vector-language-button-label. You'll likely want to make the label depend on whether ULS is installed as some wikis do not have ULS.

bwang subscribed.Aug 23 2022, 5:40 PM
In T315556#8175951, @Jdlrobson wrote:

The message to change is vector-language-button-label. You'll likely want to make the label depend on whether ULS is installed as some wikis do not have ULS.

@Jdlrobson Shouldn't we just avoid rendering the ULS button if its not installed? Why make the label depend on if ULS is installed?

ovasileva set the point value for this task to 3.Aug 23 2022, 5:42 PM
Jdlrobson moved this task from Upcoming to Ready for Development on the Web-Team-Backlog-Archived (Kanbanana-2022-23-Q1) board.Aug 23 2022, 5:42 PM
Jdlrobson added a comment.Aug 23 2022, 6:03 PM
In T315556#8179111, @bwang wrote:
In T315556#8175951, @Jdlrobson wrote:

The message to change is vector-language-button-label. You'll likely want to make the label depend on whether ULS is installed as some wikis do not have ULS.

@Jdlrobson Shouldn't we just avoid rendering the ULS button if its not installed? Why make the label depend on if ULS is installed?

So I looked at this, and it seems that this is a non-issue - the sticky header only renders the button if ULS is installed.
https://gerrit.wikimedia.org/g/mediawiki/skins/Vector/+/2450fdeb99a00cba769b6f2e3b43d3fcf2eca863/skinStyles/ext.uls.interface.less#1

gerritbot added a comment.Aug 24 2022, 9:15 PM

Change 826389 had a related patch set uploaded (by Jdrewniak; author: Jdrewniak):

[mediawiki/skins/Vector@master] Change ULS label for sticky header when 0 Languages available.

https://gerrit.wikimedia.org/r/826389

gerritbot added a project: Patch-For-Review.Aug 24 2022, 9:15 PM
Jdrewniak moved this task from Ready for Development to Code Review on the Web-Team-Backlog-Archived (Kanbanana-2022-23-Q1) board.Aug 24 2022, 9:16 PM
bwang assigned this task to Jdrewniak.Aug 25 2022, 4:51 PM
bwang moved this task from Code Review to Needs More Work on the Web-Team-Backlog-Archived (Kanbanana-2022-23-Q1) board.
bwang reassigned this task from Jdrewniak to Edtadros.Aug 30 2022, 8:50 PM
bwang moved this task from Needs More Work to QA on the Web-Team-Backlog-Archived (Kanbanana-2022-23-Q1) board.
bwang added a subscriber: Jdrewniak.
gerritbot added a comment.Aug 30 2022, 9:45 PM

Change 826389 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Change ULS label for sticky header when 0 Languages available.

https://gerrit.wikimedia.org/r/826389

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.28; 2022-09-05).Aug 30 2022, 10:00 PM
Maintenance_bot removed a project: Patch-For-Review.Aug 30 2022, 10:31 PM
Edtadros moved this task from QA to QA in Prod on the Web-Team-Backlog-Archived (Kanbanana-2022-23-Q1) board.Sep 8 2022, 4:35 PM

Test Result - Beta

Status: ✅ PASS
Environment: beta
OS: macOS Monterey
Browser: Chrome
Device: MBP
Emulated Device:NA

Test Artifact(s):

QA Steps

✅ AC1: Change the copy of the language button within the sticky header from "0 languages" to "Add languages"

Screen Shot 2022-09-06 at 2.30.40 PM.png (630×1 px, 192 KB)

• alexhollender_WMF added a comment.Sep 8 2022, 6:51 PM

just confirming that it looks correct in the sticky header (@Edtadros your screenshot in the comment above is showing the language switcher in the article header)

Screen Shot 2022-09-08 at 2.50.18 PM.png (1×3 px, 1 MB)

Edtadros added a comment.Sep 12 2022, 4:54 PM

@alexhollender_WMF thanks! I had done both but forgot to attache the sticky header.

Edtadros reassigned this task from Edtadros to ovasileva.Sep 12 2022, 4:58 PM
Edtadros moved this task from QA in Prod to Ready for Signoff on the Web-Team-Backlog-Archived (Kanbanana-2022-23-Q1) board.
Edtadros subscribed.

Test Result - Prod

Status: ✅ PASS
Environment: testwiki
OS: macOS Monterey
Browser: Chrome
Device: MBP
Emulated Device:NA

Test Artifact(s):

QA Steps

✅ AC1: Change the copy of the language button within the sticky header from "0 languages" to "Add languages"

Screen Shot 2022-09-12 at 9.56.25 AM.png (379×1 px, 138 KB)

Screen Shot 2022-09-12 at 9.56.18 AM.png (604×1 px, 170 KB)

Edtadros updated the task description. (Show Details)Sep 12 2022, 4:59 PM
ovasileva closed this task as Resolved.Sep 13 2022, 8:02 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits