[Regression] Vector 2022 does not scale to full width on edit pages when you hide sidebar
Closed, DuplicatePublicBUG REPORT
Actions

Assigned To

None

Authored By

	Soda
	Aug 20 2022, 12:12 PM

Description

Steps to replicate the issue (include links if applicable):

Go to the edit form for Page:Oriental Scenery — One Hundred and Fifty Views of the Architecture, Antiquities, and Landscape Scenery of Hindoostan.djvu/8 on en.wikisource.org
Hide left sidebar

What happens?:

Screenshot from 2022-08-20 17-33-21.png (983×1 px, 209 KB)

The width of the editing area is restricted to only 60em

What should have happened instead?:

The form should scale to full width as it used to do before.

Rationale: Wikisources in general have a two column editing layout (enabled via ProofreadPage), having the editing area restricted to 60em will hurt the ability for contributors to use the two column layout to it's fullest extent since the image preview as well as the editing area become too small to use comfortably.

Details

	Subject	Repo	Branch	Lines +/-
	Prevent edit-page from being constrained by max-width	mediawiki/skins/Vector	master	+50 -11

Customize query in gerrit

Related Objects

Mentioned Here: T315460: [Regression] Pages which are supposed to have full-width no longer have full-width layout
T314579: [ToC] Content should be centered when TOC is collapsed

Event Timeline

Soda created this task.Aug 20 2022, 12:12 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 20 2022, 12:12 PM

This appears to be a side effect of the patch that fixed T314579.

Iniquity renamed this task from Vector 2022 does not scale to full width on edit pages in the Page: namespace to [Regression] Vector 2022 does not scale to full width on edit pages in the Page: namespace.Aug 20 2022, 8:55 PM

@Soda I have everything displayed well. Maybe cache?

Found, you need to hide the sidebar, then there will be a fixed width. Not only in Wikisource:

Iniquity renamed this task from [Regression] Vector 2022 does not scale to full width on edit pages in the Page: namespace to [Regression] Vector 2022 does not scale to full width on edit pages when you hide sidebar.Aug 20 2022, 9:06 PM

Iniquity updated the task description. (Show Details)Aug 20 2022, 9:34 PM

Iniquity attached a referenced file: F35481323: image.png. (Show Details)

Change 824848 had a related patch set uploaded (by Sohom Datta; author: Sohom Datta):

[mediawiki/skins/Vector@master] Prevent edit-page from being constrained by max-width

https://gerrit.wikimedia.org/r/824848

gerritbot added a project: Patch-For-Review.Aug 21 2022, 4:53 AM

I've added/uploaded a tentative fix for this task. One specific edge case that I discovered while playing around was that for included pages/main pages, the edit view was being set to max-width when it should still be max-width.

Jdlrobson added a project: Web-Team-Backlog (Kanbanana-2022-23-Q1).Aug 22 2022, 5:38 AM

Same underlying problem as T315460.

Jdlrobson closed this task as a duplicate of T315653: Regression: fixed width broken on Vector (2022).Aug 22 2022, 6:24 AM

(this one is still not fixed but we'll track fixing it at T315460. Thanks for reporting!

Change 824848 abandoned by Sohom Datta:

[mediawiki/skins/Vector@master] Prevent edit-page from being constrained by max-width

Reason:

patch not in correct direction

https://gerrit.wikimedia.org/r/824848

Maintenance_bot removed a project: Patch-For-Review.Aug 22 2022, 11:30 AM

Jdlrobson added a project: Regression.Oct 12 2022, 6:51 PM

	F35481006: Screenshot from 2022-08-20 17-33-21.png
	Aug 20 2022, 12:12 PM

	F35481328: image.png
	Aug 20 2022, 9:04 PM

[Regression] Vector 2022 does not scale to full width on edit pages when you hide sidebarClosed, DuplicatePublicBUG REPORTActions

Description

Details

Related Objects

Event Timeline

[Regression] Vector 2022 does not scale to full width on edit pages when you hide sidebar
Closed, DuplicatePublicBUG REPORT
Actions