Page MenuHomePhabricator

PAGEBANNER is not displaying at euwiki with New Vector
Closed, ResolvedPublicBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

What happens?: There is a semi-transparent black line in the top, but the PAGEBANNER is not appearing. We can see it when editing.

What should have happened instead?: It should show pagebanner in the top

Software version (skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

Event Timeline

Yes, I added the code because it was suggested here: T281974#7657925

The problem is that I get the quality indicator in the right if I remove all the code, floating.

ovasileva lowered the priority of this task from High to Medium.Aug 24 2022, 4:44 PM

You can check the problem with indicators and floating here:

irudia.png (513×1 px, 168 KB)

Change 826558 had a related patch set uploaded (by Jdrewniak; author: Jdrewniak):

[mediawiki/skins/Vector@master] Add clearfix to .mw-body-subheader

https://gerrit.wikimedia.org/r/826558

Change 826558 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Add clearfix to .mw-body-subheader

https://gerrit.wikimedia.org/r/826558

Change 826606 had a related patch set uploaded (by Jdrewniak; author: Jdrewniak):

[mediawiki/skins/Vector@wmf/1.36.0-wmf.26] Add clearfix to .mw-body-subheader

https://gerrit.wikimedia.org/r/826606

Change 826606 abandoned by Jdrewniak:

[mediawiki/skins/Vector@wmf/1.36.0-wmf.26] Add clearfix to .mw-body-subheader

Reason:

https://gerrit.wikimedia.org/r/826606

Change 826608 had a related patch set uploaded (by Jdrewniak; author: Jdrewniak):

[mediawiki/skins/Vector@wmf/1.39.0-wmf.26] Add clearfix to .mw-body-subheader

https://gerrit.wikimedia.org/r/826608

I have added .ns-0 to the css, so Txikipedia isn't affected while this is resolved.

/* Floating article quality to the left */
.ns-0 .mw-indicators {
display: flex;
width: 100%;
align-items: center;
justify-content: flex-end;
gap: 10px;
}

.ns-0 .article_quality { flex-grow: 1; }  /*will push article quality to the left */

But, somehow, this solution breaks the visual-editor:

irudia.png (422×1 px, 83 KB)

Change 826608 merged by jenkins-bot:

[mediawiki/skins/Vector@wmf/1.39.0-wmf.26] Add clearfix to .mw-body-subheader

https://gerrit.wikimedia.org/r/826608

Mentioned in SAL (#wikimedia-operations) [2022-08-25T20:31:40Z] <urbanecm@deploy1002> Synchronized php-1.39.0-wmf.26/skins/Vector/resources/skins.vector.styles/layouts/screen.less: fe3382ea74a7ca5c8954ed456f4cd100208ed1e6: Add clearfix to .mw-body-subheader (T316134, T316095) (duration: 03m 25s)

ovasileva claimed this task.
ovasileva subscribed.

Now fixed