| sgrabarczuk | |
| Aug 24 2022, 5:10 PM |
| F35503161: Screen Shot 2022-08-31 at 6.42.08 PM.png | |
| Sep 1 2022, 1:48 AM |
| F35503160: Screen Shot 2022-08-31 at 6.44.35 PM.png | |
| Sep 1 2022, 1:48 AM |
| F35488145: obraz.png | |
| Aug 24 2022, 5:10 PM |
Steps to replicate the issue (include links if applicable):
What happens?:
Page indicators are in line with content (example):
What should have happened instead?:
Content should begin with a new line after page indicators.
| AC | Status | Details |
|---|---|---|
| 1 | ❓ | T316134#8204950 |
The indicators never get cleared.
Fix should be relatively simple:
.mw-body-subheader {
.mixin-clearfix();
}Change 826558 had a related patch set uploaded (by Jdrewniak; author: Jdrewniak):
[mediawiki/skins/Vector@master] Add clearfix to .mw-body-subheader
Change 826558 merged by jenkins-bot:
[mediawiki/skins/Vector@master] Add clearfix to .mw-body-subheader
Change 826606 had a related patch set uploaded (by Jdrewniak; author: Jdrewniak):
[mediawiki/skins/Vector@wmf/1.36.0-wmf.26] Add clearfix to .mw-body-subheader
Change 826606 abandoned by Jdrewniak:
[mediawiki/skins/Vector@wmf/1.36.0-wmf.26] Add clearfix to .mw-body-subheader
Reason:
Change 826608 had a related patch set uploaded (by Jdrewniak; author: Jdrewniak):
[mediawiki/skins/Vector@wmf/1.39.0-wmf.26] Add clearfix to .mw-body-subheader
Change 826608 merged by jenkins-bot:
[mediawiki/skins/Vector@wmf/1.39.0-wmf.26] Add clearfix to .mw-body-subheader
Mentioned in SAL (#wikimedia-operations) [2022-08-25T20:31:40Z] <urbanecm@deploy1002> Synchronized php-1.39.0-wmf.26/skins/Vector/resources/skins.vector.styles/layouts/screen.less: fe3382ea74a7ca5c8954ed456f4cd100208ed1e6: Add clearfix to .mw-body-subheader (T316134, T316095) (duration: 03m 25s)
Status: ✅ PASS
Environment: hewiki
OS: macOS Monterey
Browser: Chrome
Device: MBP
Emulated Device:NA
Test Artifact(s):
Enable Vector 2022 on a wiki not using the tagline
Go to a page with page indicators
✅ AC1: Content should begin with a new line after page indicators.
@ovasileva, this technically passes since the content begins on a new line. I wanted to highlight the lack of a gap between the top of the lock and the menu line above it. Should a gap be part of this task or a new one?
The gap is unfortunately part of a different issue tracked separately. This is okay to resolve.