Page MenuHomePhabricator
Create Task
Maniphest T316771

URL in address bar is wrong after pressing back from section edit link
Closed, ResolvedPublic
Actions

Description

  1. Open a page on a single-edit-tab wiki, e.g. https://ca.wikipedia.org/wiki/Al%C3%A8xia_Putellas_i_Segura
  2. Click on a section [edit] link
  3. Observe the address bar URL as updated to action=edit
  4. Press browser back.

Observed

  1. The editor closed but the URL is still action=edit

Expected

  1. The editor closed and the URL is back to the original reading URL

Details

SubjectRepoBranchLines +/-
Fix broken history management in onEditSectionLinkClickmediawiki/extensions/VisualEditormaster+20 -15
Customize query in gerrit

Related Objects

Event Timeline

Esanders created this task.Aug 31 2022, 1:05 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 31 2022, 1:05 PM
gerritbot added a comment.Aug 31 2022, 1:07 PM

Change 828516 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/extensions/VisualEditor@master] Fix broken history management in onEditSectionLinkClick

https://gerrit.wikimedia.org/r/828516

gerritbot added a project: Patch-For-Review.Aug 31 2022, 1:07 PM
Esanders moved this task from To Triage to Triaged on the VisualEditor board.Aug 31 2022, 1:20 PM
PatchDemoBot added a comment.Aug 31 2022, 1:42 PM

Test wiki created on Patch demo by ESanders (WMF) using patch(es) linked to this task:
https://patchdemo.wmflabs.org/wikis/9cf456b71a/wiki/Template:Cite_web/doc#Template_data

matmarex added a project: Editing-team (Kanban Board).Sep 1 2022, 2:06 AM
matmarex moved this task from Incoming to Code Review on the Editing-team (Kanban Board) board.
gerritbot added a comment.Sep 1 2022, 2:23 AM

Change 828516 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Fix broken history management in onEditSectionLinkClick

https://gerrit.wikimedia.org/r/828516

Maintenance_bot removed a project: Patch-For-Review.Sep 1 2022, 2:30 AM
matmarex subscribed.Sep 1 2022, 2:57 AM

While testing the fix, I noticed that using browser forward (or back) to re-enter the editor after leaving it is also not working (in single edit tab mode).

matmarex moved this task from Code Review to QA on the Editing-team (Kanban Board) board.Sep 1 2022, 2:57 AM
matmarex added a project: Editing QA.
ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.28; 2022-09-05).Sep 1 2022, 3:00 AM
Esanders mentioned this in T316869: VE doesn't re-open when pressing browser-forward on SET wikis.Sep 1 2022, 1:55 PM
Esanders added a comment.Sep 1 2022, 3:56 PM
In T316771#8205034, @matmarex wrote:

While testing the fix, I noticed that using browser forward (or back) to re-enter the editor after leaving it is also not working (in single edit tab mode).

Filed as T316869

EAkinloose edited projects, added Verified; removed Editing QA.Sep 13 2022, 4:08 PM
EAkinloose moved this task from QA to Ready for Sign Off on the Editing-team (Kanban Board) board.
ppelberg closed this task as Resolved.Sep 22 2022, 4:42 PM
ppelberg claimed this task.
PatchDemoBot added a comment.Feb 3 2023, 3:35 PM

Test wiki on Patch demo by ESanders (WMF) using patch(es) linked to this task was deleted:

https://patchdemo.wmflabs.org/wikis/9cf456b71a/w/

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits