Maniphest T316853

ResourcesTest::testUnsatisfiableDependencies: The module 'wikibase.lexeme.lexemeview' must not depend on modules with requiresES6=true
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	kostajh
	Sep 1 2022, 7:20 AM

Tags

Referenced Files

None

Subscribers

Description

07:42:25 There was 1 failure:
07:42:25 
07:42:25 1) ResourcesTest::testUnsatisfiableDependencies
07:42:25 The module 'wikibase.lexeme.lexemeview' must not depend on modules with requiresES6=true
07:42:25 Failed asserting that two arrays are equal.
07:42:25 --- Expected
07:42:25 +++ Actual
07:42:25 @@ @@
07:42:25  Array (
07:42:25 +    0 => 'vue'
07:42:25 +    1 => 'vuex'
07:42:25  )
07:42:25 
07:42:25 /workspace/src/tests/phpunit/structure/ResourcesTest.php:139
07:42:25 /workspace/src/tests/phpunit/MediaWikiIntegrationTestCase.php:500
07:42:25 === Logs generated by test case

Seeing this on builds for GrowthExperiments.

Details

	Subject	Repo	Branch	Lines +/-
	Require ES6 for RL modules depending on vue/vuex	mediawiki/extensions/WikibaseLexeme	master	+2 -0

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved	BUG REPORT	Krinkle	T316324 ResourceLoader: Modules that are not marked as es6 that import es6 modules should log a JavaScript warning/exception
		Resolved		Jakob_WMDE	T316853 ResourcesTest::testUnsatisfiableDependencies: The module 'wikibase.lexeme.lexemeview' must not depend on modules with requiresES6=true

Event Timeline

kostajh created this task.Sep 1 2022, 7:20 AM

Restricted Application added a project: Performance-Team. · View Herald TranscriptSep 1 2022, 7:20 AM

kostajh triaged this task as Unbreak Now! priority.Sep 1 2022, 7:20 AM

kostajh edited projects, added ci-test-error (WMF-deployed Build Failure); removed ci-test-error.

Maintenance_bot added a project: Wikidata.Sep 1 2022, 7:29 AM

kostajh added a parent task: T316324: ResourceLoader: Modules that are not marked as es6 that import es6 modules should log a JavaScript warning/exception.Sep 1 2022, 8:23 AM

Change 828759 had a related patch set uploaded (by Jakob; author: Jakob):

[mediawiki/extensions/WikibaseLexeme@master] Require ES6 for RL modules depending on vue/vuex

https://gerrit.wikimedia.org/r/828759

gerritbot added a project: Patch-For-Review.Sep 1 2022, 8:38 AM

dcausse subscribed.Sep 1 2022, 8:52 AM

Silvan_WMDE subscribed.Sep 1 2022, 9:47 AM

Jakob_WMDE subscribed.Sep 1 2022, 10:10 AM

Physikerwelt added subscribers: Stegmujo, Physikerwelt.Sep 2 2022, 8:57 AM

This comment was removed by Physikerwelt.

Change 828759 merged by jenkins-bot:

[mediawiki/extensions/WikibaseLexeme@master] Require ES6 for RL modules depending on vue/vuex

https://gerrit.wikimedia.org/r/828759

This should be fixed now

Maintenance_bot removed a project: Patch-For-Review.Sep 2 2022, 10:30 AM

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.28; 2022-09-05).Sep 2 2022, 11:00 AM

Krinkle removed projects: MediaWiki-ResourceLoader, Performance-Team.Sep 2 2022, 11:31 AM

Physikerwelt mentioned this in T324525: The module 'wikibase.lexeme.lexemeview' must not have target 'mobile' because its dependency 'jquery.ui.languagesuggester' does not have it.Dec 6 2022, 4:20 PM